[jira] [Commented] (SOLR-17334) Minor bugs in Solr dedicated coordinator mode

2025-01-31 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922900#comment-17922900 ] Noble Paul commented on SOLR-17334: --- yes, this can be closed now > Minor bugs in Solr

Re: [PR] SOLR-17609: Remove HDFS module [solr]

2025-01-31 Thread via GitHub
dsmiley commented on code in PR #2923: URL: https://github.com/apache/solr/pull/2923#discussion_r1938182884 ## solr/modules/hdfs/src/java/org/apache/solr/hdfs/store/blockcache/package-info.java: ## Review Comment: I propose that the "blockcache" java package, and correspond

Re: [PR] SOLR-17609: mark deprecation of HDFS module in 9x and removal in 10 [solr]

2025-01-31 Thread via GitHub
dsmiley commented on code in PR #3041: URL: https://github.com/apache/solr/pull/3041#discussion_r1938174347 ## solr/solr-ref-guide/modules/deployment-guide/pages/solr-on-hdfs.adoc: ## @@ -20,6 +20,8 @@ The Solr HDFS Module has support for writing and reading Solr's index and t

[jira] [Updated] (SOLR-16903) Use Path instead of File in Java Code

2025-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16903: Fix Version/s: main (10.0) > Use Path instead of File in Java Code > --

[jira] [Commented] (SOLR-16903) Use Path instead of File in Java Code

2025-01-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922892#comment-17922892 ] ASF subversion and git services commented on SOLR-16903: Commit b

Re: [PR] SOLR-16903: Migrate off java.io.File to java.nio.file.Path from core files [solr]

2025-01-31 Thread via GitHub
dsmiley merged PR #2924: URL: https://github.com/apache/solr/pull/2924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-17630) Add CloudSolrClient instance for a Solr node

2025-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922889#comment-17922889 ] David Smiley commented on SOLR-17630: - The node SolrClientCache instance can be demot

[jira] [Commented] (SOLR-14423) static caches in StreamHandler ought to move to CoreContainer lifecycle

2025-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922888#comment-17922888 ] David Smiley commented on SOLR-14423: - Following up to those here; I'm discussing wit

[jira] [Resolved] (SOLR-17552) NamedList.asShallowMap improvements

2025-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17552. - Resolution: Won't Fix > NamedList.asShallowMap improvements > ---

[jira] [Resolved] (SOLR-17623) SimpleOrderedMap should implement Map

2025-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17623. - Fix Version/s: 9.9 Resolution: Fixed Nice; thanks again Renato! If you are interested in

[jira] [Updated] (SOLR-17379) ParsingFieldUpdateProcessorsTest failures using CLDR locale provider

2025-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17379: -- Labels: pull-request-available (was: ) > ParsingFieldUpdateProcessorsTest failures using CLDR

[PR] SOLR-17379: Fix date parsing in Java 23, remove Lucene TestSecurityManager [solr]

2025-01-31 Thread via GitHub
HoustonPutman opened a new pull request, #3154: URL: https://github.com/apache/solr/pull/3154 https://issues.apache.org/jira/browse/SOLR-17379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (SOLR-17641) Support Java 24

2025-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17641: -- Labels: pull-request-available (was: ) > Support Java 24 > --- > >

[jira] [Commented] (SOLR-17623) SimpleOrderedMap should implement Map

2025-01-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922865#comment-17922865 ] ASF subversion and git services commented on SOLR-17623: Commit a

[jira] [Commented] (SOLR-17582) CLUSTERSTATUS API could stream the response to save memory

2025-01-31 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922863#comment-17922863 ] Matthew Biscocho commented on SOLR-17582: - I saw SOLR-17623 merged in. I'll go ah

Re: [PR] SOLR-16903: Migrate off java.io.File to java.nio.file.Path from core files [solr]

2025-01-31 Thread via GitHub
mlbiscoc commented on code in PR #2924: URL: https://github.com/apache/solr/pull/2924#discussion_r1938046715 ## solr/core/src/java/org/apache/solr/core/DirectoryFactory.java: ## @@ -369,15 +370,17 @@ public void cleanupOldIndexDirectories( int i = 0; if (afterCoreRel

[jira] [Commented] (SOLR-17642) Knn queries use multi threaded search unintentionally

2025-01-31 Thread Varun Thacker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922850#comment-17922850 ] Varun Thacker commented on SOLR-17642: -- 👋 [~cpoerschke] ! Thanks for the tis. Yes th

Re: [PR] SOLR-16903: Migrate off java.io.File to java.nio.file.Path from core files [solr]

2025-01-31 Thread via GitHub
dsmiley commented on code in PR #2924: URL: https://github.com/apache/solr/pull/2924#discussion_r1937982261 ## solr/core/src/java/org/apache/solr/core/DirectoryFactory.java: ## @@ -369,15 +370,17 @@ public void cleanupOldIndexDirectories( int i = 0; if (afterCoreRelo

[jira] [Commented] (SOLR-17623) SimpleOrderedMap should implement Map

2025-01-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922846#comment-17922846 ] ASF subversion and git services commented on SOLR-17623: Commit d

Re: [PR] SOLR-17623: Simple ordered map should implement map [solr]

2025-01-31 Thread via GitHub
dsmiley merged PR #3048: URL: https://github.com/apache/solr/pull/3048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-16903: Migrate off java.io.File to java.nio.file.Path from core files [solr]

2025-01-31 Thread via GitHub
mlbiscoc commented on code in PR #2924: URL: https://github.com/apache/solr/pull/2924#discussion_r1937718233 ## solr/core/src/java/org/apache/solr/core/SolrPaths.java: ## @@ -94,7 +94,7 @@ public static void assertNoPathTraversal(Path pathToAssert) { /** Asserts that a path

Re: [PR] Limit Github Actions runtime and cleanup always [solr]

2025-01-31 Thread via GitHub
dsmiley commented on PR #3152: URL: https://github.com/apache/solr/pull/3152#issuecomment-2628129391 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Limit Github Actions runtime and cleanup always [solr]

2025-01-31 Thread via GitHub
dsmiley merged PR #3152: URL: https://github.com/apache/solr/pull/3152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-17646) DirectoryFactory should support any NIO FileSystemProvider

2025-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922824#comment-17922824 ] David Smiley commented on SOLR-17646: - Another comment on remote/cloud storage: A Fi

[jira] [Commented] (SOLR-17609) Remove hdfs module

2025-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922823#comment-17922823 ] David Smiley commented on SOLR-17609: - Linking to SOLR-17646, (NIO FileSystemProvider

[jira] [Commented] (SOLR-17646) DirectoryFactory should support any NIO FileSystemProvider

2025-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922820#comment-17922820 ] David Smiley commented on SOLR-17646: - As I write this, the title of this JIRA is sco

[jira] [Commented] (SOLR-17640) Support different filesystem implementations with EmbeddedSolrServer

2025-01-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922812#comment-17922812 ] David Smiley commented on SOLR-17640: - This is the tip of an iceberg. I'm tempted to

[jira] [Created] (SOLR-17646) DirectoryFactory should support any NIO FileSystemProvider

2025-01-31 Thread David Smiley (Jira)
David Smiley created SOLR-17646: --- Summary: DirectoryFactory should support any NIO FileSystemProvider Key: SOLR-17646 URL: https://issues.apache.org/jira/browse/SOLR-17646 Project: Solr Issue T

Re: [PR] Limit Github Actions runtime and cleanup always [solr]

2025-01-31 Thread via GitHub
HoustonPutman commented on PR #3152: URL: https://github.com/apache/solr/pull/3152#issuecomment-2628057773 I changed it to 40 min, because if everything is working it runs in like 20 min. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (SOLR-17642) Knn queries use multi threaded search unintentionally

2025-01-31 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922811#comment-17922811 ] Christine Poerschke commented on SOLR-17642: {quote}... The fact we initialis

Re: [PR] SOLR-17632: Text to Vector Update Request Processor [solr]

2025-01-31 Thread via GitHub
cpoerschke commented on code in PR #3151: URL: https://github.com/apache/solr/pull/3151#discussion_r1937732098 ## solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessor.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Sof

[PR] Limit Github Actions runtime and cleanup always [solr]

2025-01-31 Thread via GitHub
uvatbc opened a new pull request, #3152: URL: https://github.com/apache/solr/pull/3152 https://issues.apache.org/jira/browse/SOLR-X # Description The Solr tests ran for over 2 days - and I forgot to check them over the weekend. Keeping a 96 core machine r

Re: [PR] SOLR-17632: Text to Vector Update Request Processor [solr]

2025-01-31 Thread via GitHub
cpoerschke commented on code in PR #3151: URL: https://github.com/apache/solr/pull/3151#discussion_r1937657567 ## solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessor.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Sof

Re: [PR] SOLR-17632: Text to Vector Update Request Processor [solr]

2025-01-31 Thread via GitHub
cpoerschke commented on code in PR #3151: URL: https://github.com/apache/solr/pull/3151#discussion_r1937653570 ## solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessor.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Sof

Re: [PR] SOLR-17632: Text to Vector Update Request Processor [solr]

2025-01-31 Thread via GitHub
cpoerschke commented on code in PR #3151: URL: https://github.com/apache/solr/pull/3151#discussion_r1937657567 ## solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessor.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Sof

Re: [PR] SOLR-17632: Text to Vector Update Request Processor [solr]

2025-01-31 Thread via GitHub
cpoerschke commented on code in PR #3151: URL: https://github.com/apache/solr/pull/3151#discussion_r1937651836 ## solr/modules/llm/src/java/org/apache/solr/llm/texttovector/update/processor/TextToVectorUpdateProcessorFactory.java: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apac

Re: [PR] SOLR-17632: Text to Vector Update Request Processor [solr]

2025-01-31 Thread via GitHub
alessandrobenedetti commented on PR #3151: URL: https://github.com/apache/solr/pull/3151#issuecomment-2627858272 Let's give it a first round of discussion/brainstorming/improvements. Then I'll adjust the gradle check, documentation and changes. -- This is an automated message from t

Re: [PR] SOLR-XXXXX: Support different filesystem implementations with EmbeddedSolrServer [solr]

2025-01-31 Thread via GitHub
AndreyBozhko commented on code in PR #3146: URL: https://github.com/apache/solr/pull/3146#discussion_r1937640688 ## solr/core/src/test/org/apache/solr/client/solrj/embedded/TestEmbeddedSolrServerConstructors.java: ## @@ -58,4 +63,63 @@ public void testNodeConfigConstructor() thr

[jira] [Updated] (SOLR-17632) Text to Vector Update Request Processor

2025-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17632: -- Labels: pull-request-available (was: ) > Text to Vector Update Request Processor > ---

[PR] SOLR-17632: Text to Vector Update Request Processor [solr]

2025-01-31 Thread via GitHub
alessandrobenedetti opened a new pull request, #3151: URL: https://github.com/apache/solr/pull/3151 https://issues.apache.org/jira/browse/SOLR-17632 # Description Scope of this issue is to introduce support for automatic text vectorisation in Apache Solr. A LLM fine-tuned fo

[jira] [Updated] (SOLR-17645) Handle executor thread failures more gracefully

2025-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17645: -- Labels: pull-request-available (was: ) > Handle executor thread failures more gracefully > ---

[PR] SOLR-17645: Gracefully handle exceptions in executor threads [solr]

2025-01-31 Thread via GitHub
HoustonPutman opened a new pull request, #3150: URL: https://github.com/apache/solr/pull/3150 https://issues.apache.org/jira/browse/SOLR-17645 The main one I see in our tests are threads submitted by ZkStateReader.waitForState(), and ZkShardTerms having issues while a cluster is shut

[jira] [Created] (SOLR-17645) Handle executor thread failures more gracefully

2025-01-31 Thread Houston Putman (Jira)
Houston Putman created SOLR-17645: - Summary: Handle executor thread failures more gracefully Key: SOLR-17645 URL: https://issues.apache.org/jira/browse/SOLR-17645 Project: Solr Issue Type: Bu

Re: [PR] feat(update-security-json): Update security.json when secret is updated [solr-operator]

2025-01-31 Thread via GitHub
gerlowskija commented on code in PR #744: URL: https://github.com/apache/solr-operator/pull/744#discussion_r1937407517 ## controllers/util/solr_security_util.go: ## @@ -240,11 +245,16 @@ func cmdToPutSecurityJsonInZk() string { cmd := " solr zk cp zk:/security.json /tmp/

[jira] [Created] (SOLR-17644) Collection creation fails when replica placement plugin and basic auth are enabled

2025-01-31 Thread Colvin Cowie (Jira)
Colvin Cowie created SOLR-17644: --- Summary: Collection creation fails when replica placement plugin and basic auth are enabled Key: SOLR-17644 URL: https://issues.apache.org/jira/browse/SOLR-17644 Projec

Re: [PR] SOLR-17631: Upgrade main to Lucene 10.x [solr]

2025-01-31 Thread via GitHub
cpoerschke commented on code in PR #3053: URL: https://github.com/apache/solr/pull/3053#discussion_r1937402513 ## solr/modules/ltr/src/test/org/apache/solr/ltr/TestLTRReRankingPipeline.java: ## @@ -145,8 +145,8 @@ public void testRescorer() throws Exception { hits = resco

[PR] in tests replace deprecated IndexSearcher.doc() calls [solr]

2025-01-31 Thread via GitHub
cpoerschke opened a new pull request, #3149: URL: https://github.com/apache/solr/pull/3149 The API is deprecated since Lucene 9.5 - https://github.com/apache/lucene/blob/releases/lucene/9.5.0/lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java#L382-L391 -- and remove in Lucene

Re: [PR] SOLR-16903: Migrate off java.io.File to java.nio.file.Path from core files [solr]

2025-01-31 Thread via GitHub
epugh commented on PR #2924: URL: https://github.com/apache/solr/pull/2924#issuecomment-2627404639 Thank you @dsmiley for digging through things. Your comments and eyes is probably saving us a lot of test failures down the road ;-). -- This is an automated message from the Apache Git

Re: [PR] SOLR-17623: Simple ordered map should implement map [solr]

2025-01-31 Thread via GitHub
renatoh commented on PR #3048: URL: https://github.com/apache/solr/pull/3048#issuecomment-2627271485 > As you are a very new contributor, I can tell by your changes and your last question that you have not been running `./gradlew precommit`, which will detect issues that you can correct bef