dsmiley commented on code in PR #2923: URL: https://github.com/apache/solr/pull/2923#discussion_r1938182884
########## solr/modules/hdfs/src/java/org/apache/solr/hdfs/store/blockcache/package-info.java: ########## Review Comment: I propose that the "blockcache" java package, and corresponding tests, be moved into the solr-core module. The javadocs for the BlockCache package is misleading. It says "An HDFS blockcache implementation" but the BlockCache actually has no outwards dependencies aside from Lucene and basic stuff. A more accurate characterization of the package is: "A generic Directory layer/wrapper that caches data, on or off heap as desired". This is a hidden gem with remarkable intellectual property that our project will hopefully use on top of another Directory. For example if DirectoryFactory uses NIO better, we might very well use this with GCP FileSystemProvider, which just so happens to already be in our dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
