Houston Putman created SOLR-17645:
-------------------------------------

             Summary: Handle executor thread failures more gracefully
                 Key: SOLR-17645
                 URL: https://issues.apache.org/jira/browse/SOLR-17645
             Project: Solr
          Issue Type: Bug
    Affects Versions: 9.8
            Reporter: Houston Putman


As of SOLR-17448, we use ExecutorService.execute() much more throughout the 
codebase. This is a good thing since before we weren't doing anything with the 
Future objects that ExecutorService.submit() would return.

One drawback however, is that in our tests, we use randomizedTesting (the 
library) to listen for uncaught exceptions in threads. I believe the change to 
ExecutorService.execute() led to this, because there is no Future to return 
that an exception was thrown.

Usually we do well in catching exceptions in our threads, but certainly not 
always. We should audit this, to improve error handling in our code as well as 
limit test failures.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to