[ https://issues.apache.org/jira/browse/SOLR-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922846#comment-17922846 ]
ASF subversion and git services commented on SOLR-17623: -------------------------------------------------------- Commit dac5fe1ea8375eaaa92be37fb2831fbc7cb2c9cc in solr's branch refs/heads/main from Renato Haeberli [ https://gitbox.apache.org/repos/asf?p=solr.git;h=dac5fe1ea83 ] SOLR-17623: SimpleOrderedMap implements Map (#3048) Also added NamedList.indexOf(name) convenience method. Does *not* adjust asShallowMap() yet. Coming soon. --------- Co-authored-by: David Smiley <dsmi...@apache.org> > SimpleOrderedMap should implement Map > ------------------------------------- > > Key: SOLR-17623 > URL: https://issues.apache.org/jira/browse/SOLR-17623 > Project: Solr > Issue Type: Improvement > Reporter: David Smiley > Priority: Major > Labels: newdev, pull-request-available > Time Spent: 3h 10m > Remaining Estimate: 0h > > SimpleOrderedMap is semantically a Map; it should implement Map. > Why: This will help us transition away from NamedList (it's superclass) in a > number of places, since many (most?) places that are defined to return a > NamedList could actually be declared to be a SimpleOrderedMap and eventually > simply Map. > There's some risk that code somewhere gets this Map, a large one, and then > assumes it has better than O(N) lookup, which it doesn't provide. Perhaps a > Javadoc warning will do. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org