AndreyBozhko commented on code in PR #3146: URL: https://github.com/apache/solr/pull/3146#discussion_r1937640688
########## solr/core/src/test/org/apache/solr/client/solrj/embedded/TestEmbeddedSolrServerConstructors.java: ########## @@ -58,4 +63,63 @@ public void testNodeConfigConstructor() throws Exception { assertEquals(1, server.query("newcore", new SolrQuery("*:*")).getResults().getNumFound()); } } + + @SuppressWarnings("removal") + @Test + public void testPathConstructorZipFS() throws Exception { + assumeTrue( + """ + Test only works without Security Manager due to SecurityConfHandlerLocal + missing permission to read /1/2/3/4/security.json file""", + System.getSecurityManager() == null); Review Comment: OK, I think I will keep this PR as draft for now, and work on updating CoreContainer#getSolrHome to return Path first. Is there an existing JIRA for that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org