janhoy commented on PR #2580:
URL: https://github.com/apache/solr/pull/2580#issuecomment-2246635757
Sure, great steps in right direction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
[
https://issues.apache.org/jira/browse/SOLR-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868199#comment-17868199
]
David Smiley commented on SOLR-17378:
-
Sounds useful!
> Add a RequestHandler metric
dsmiley commented on PR #2586:
URL: https://github.com/apache/solr/pull/2586#issuecomment-2246415444
> any leaking metrics from other metrics should not override these values.
That's dodging an issue that should be investigated as it might interfere
with another metrics based test I
dsmiley commented on code in PR #2586:
URL: https://github.com/apache/solr/pull/2586#discussion_r1688787862
##
solr/core/src/test/org/apache/solr/response/TestPrometheusResponseWriter.java:
##
@@ -34,57 +38,104 @@
import org.junit.ClassRule;
import org.junit.Test;
-/** Tests
dsmiley commented on PR #2587:
URL: https://github.com/apache/solr/pull/2587#issuecomment-2246403844
I am looking at BaseHttpSolrClient again, and I see that
RemoteExecutionException is *also* something that'll need to be moved. It's
not used in many places. I think it's reasonable to inc
malliaridis commented on code in PR #2577:
URL: https://github.com/apache/solr/pull/2577#discussion_r1688758777
##
solr/bin/solr.cmd:
##
@@ -292,7 +292,6 @@ IF "%FIRST_ARG%"=="-help" goto run_solrcli
IF "%FIRST_ARG%"=="-usage" goto run_solrcli
IF "%FIRST_ARG%"=="-h" goto run_s
malliaridis commented on code in PR #2577:
URL: https://github.com/apache/solr/pull/2577#discussion_r1688763185
##
solr/packaging/test/test_adminconsole_urls.bats:
##
@@ -25,7 +25,7 @@ teardown() {
# save a snapshot of SOLR_HOME for failed tests
save_home_on_failure
- s
malliaridis commented on code in PR #2577:
URL: https://github.com/apache/solr/pull/2577#discussion_r1688759945
##
solr/bin/solr.cmd:
##
@@ -1525,10 +1524,10 @@ IF "!ZK_OP!"=="" (
set CONNECTION_PARAMS=""
IF "!ZK_OP!"=="" (
- set CONNECTION_PARAMS="-solrUrl !ZK_SOLR_URL!"
+
malliaridis commented on code in PR #2577:
URL: https://github.com/apache/solr/pull/2577#discussion_r1688758777
##
solr/bin/solr.cmd:
##
@@ -292,7 +292,6 @@ IF "%FIRST_ARG%"=="-help" goto run_solrcli
IF "%FIRST_ARG%"=="-usage" goto run_solrcli
IF "%FIRST_ARG%"=="-h" goto run_s
[
https://issues.apache.org/jira/browse/SOLR-17285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17285:
--
Labels: newdev pull-request-available (was: newdev)
> Move RemoteSolrException to SolrClient i
moistbeans23 opened a new pull request, #2587:
URL: https://github.com/apache/solr/pull/2587
https://issues.apache.org/jira/browse/SOLR-17285
# Description
Moved RemoteSolrException to SolrClient from BaseHttpSolrClient
# Solution
Moved RemoteSolrException clas
[
https://issues.apache.org/jira/browse/SOLR-17368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17368:
--
Labels: pull-request-available (was: )
> TestPrometheusResponseWriter redesign
> -
mlbiscoc opened a new pull request, #2586:
URL: https://github.com/apache/solr/pull/2586
https://issues.apache.org/jira/browse/SOLR-17368
# Description
Please provide a short description of the changes you're making with this
pull request.
The `TestPrometheus
epugh commented on PR #2479:
URL: https://github.com/apache/solr/pull/2479#issuecomment-2246259400
Okay, I think this is ready for review! I've added some docs.. I
especially liked being able to cat some local data right into a Solr
collection!
```
cat example/exampledocs/bo
epugh commented on PR #2580:
URL: https://github.com/apache/solr/pull/2580#issuecomment-2246262293
@janhoy what do you think about me merging this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
[
https://issues.apache.org/jira/browse/SOLR-14673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-14673:
--
Labels: pull-request-available (was: )
> Add CLI for Streaming Expressions
> -
Michael Gibney created SOLR-17378:
-
Summary: Add a RequestHandler metric for "number of outstanding
concurrent requests"
Key: SOLR-17378
URL: https://issues.apache.org/jira/browse/SOLR-17378
Project:
dsmiley commented on PR #2489:
URL: https://github.com/apache/solr/pull/2489#issuecomment-2246125113
@cpoerschke see the parent JIRA issue for the real state of this
controvertial PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
dsmiley commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1688607183
##
solr/solrj/src/java/org/apache/solr/common/params/CombinerParams.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1688601156
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection, Integ
dsmiley commented on code in PR #2585:
URL: https://github.com/apache/solr/pull/2585#discussion_r1688516826
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java:
##
@@ -0,0 +1,403 @@
+package org.apache.solr.common.cloud;
+
+import
dsmiley commented on PR #2585:
URL: https://github.com/apache/solr/pull/2585#issuecomment-2245945375
ZkStateReader has been getting too large; I like this change!
@gus-asf @tflobbe , I'm requesting your feedback on this pure refactoring PR
(I wish the title used the word "refactoring"
dsmiley commented on code in PR #2585:
URL: https://github.com/apache/solr/pull/2585#discussion_r1688485078
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -1191,130 +1166,27 @@ private void loadClusterProperties() {
}
/**
- * Ge
[
https://issues.apache.org/jira/browse/SOLR-17377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Salagnac updated SOLR-17377:
---
Description:
Following SOLR-17096, we can declare a custom cluster singleton in {{solr.xml}}
Pierre Salagnac created SOLR-17377:
--
Summary: ClusterSingleton defined in solr.xml cannot be loaded
from a module
Key: SOLR-17377
URL: https://issues.apache.org/jira/browse/SOLR-17377
Project: Solr
cpoerschke commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1688454713
##
solr/core/src/java/org/apache/solr/search/combining/QueriesCombiner.java:
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
cpoerschke commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1688453058
##
solr/core/src/java/org/apache/solr/search/combining/CombineQParserPlugin.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
cpoerschke commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1688438487
##
solr/solrj/src/java/org/apache/solr/common/params/CombinerParams.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
cpoerschke commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1688437190
##
solr/solrj/src/java/org/apache/solr/common/params/CombinerParams.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
cpoerschke commented on code in PR #2526:
URL: https://github.com/apache/solr/pull/2526#discussion_r1688403069
##
solr/core/src/test/org/apache/solr/handler/component/DebugComponentTest.java:
##
@@ -297,4 +297,12 @@ private void addRequestId(ResponseBuilder rb, String
requestId
[
https://issues.apache.org/jira/browse/SOLR-17337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17337:
--
Labels: pull-request-available (was: )
> Display all custom distributed stages in debug output
cpoerschke commented on code in PR #2526:
URL: https://github.com/apache/solr/pull/2526#discussion_r1688403069
##
solr/core/src/test/org/apache/solr/handler/component/DebugComponentTest.java:
##
@@ -297,4 +297,12 @@ private void addRequestId(ResponseBuilder rb, String
requestId
[
https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868123#comment-17868123
]
ASF subversion and git services commented on SOLR-13350:
Commit c
[
https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868122#comment-17868122
]
ASF subversion and git services commented on SOLR-13350:
Commit d
cpoerschke merged PR #2508:
URL: https://github.com/apache/solr/pull/2508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache
[
https://issues.apache.org/jira/browse/SOLR-17376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Veit updated SOLR-17376:
--
Environment:
Java version: 21.0.3+9-LTS
Jetty 10.0.21
Windows Server 2019
was:
Java ver
[
https://issues.apache.org/jira/browse/SOLR-17376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868121#comment-17868121
]
Alexander Veit commented on SOLR-17376:
---
I don't think that this does apply here.
cpoerschke commented on code in PR #2508:
URL: https://github.com/apache/solr/pull/2508#discussion_r1688330420
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -445,9 +445,9 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
[
https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868111#comment-17868111
]
ASF subversion and git services commented on SOLR-13350:
Commit 0
cpoerschke merged PR #2570:
URL: https://github.com/apache/solr/pull/2570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache
cpoerschke commented on PR #2546:
URL: https://github.com/apache/solr/pull/2546#issuecomment-2245629637
> As an aside, the Gradle dashboard link doesn't yet work for me, could be
local issue, not yet looked into. Does it work for anyone else?
Just removed it for now.
--
This is
dsmiley commented on PR #2585:
URL: https://github.com/apache/solr/pull/2585#issuecomment-2245620881
(not ready for review; needs to be re-done)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
cpoerschke commented on code in PR #2558:
URL: https://github.com/apache/solr/pull/2558#discussion_r1688301242
##
solr/solrj-streaming/src/test/org/apache/solr/client/solrj/io/stream/ops/ConcatOperationTest.java:
##
@@ -79,7 +79,7 @@ public void concatMultipleFields() throws Exc
epugh commented on code in PR #2558:
URL: https://github.com/apache/solr/pull/2558#discussion_r1688300989
##
solr/solrj-streaming/src/test/org/apache/solr/client/solrj/io/stream/eval/CoalesceEvaluatorTest.java:
##
@@ -1,7 +1,7 @@
/*
* Licensed to the Apache Software Foundatio
cpoerschke commented on code in PR #2558:
URL: https://github.com/apache/solr/pull/2558#discussion_r1688297743
##
solr/solrj-streaming/src/test/org/apache/solr/client/solrj/io/stream/eval/CoalesceEvaluatorTest.java:
##
@@ -1,7 +1,7 @@
/*
* Licensed to the Apache Software Foun
cpoerschke merged PR #2512:
URL: https://github.com/apache/solr/pull/2512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1688240886
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -124,7 +124,14 @@ private ClusterState fetchClusterState(
t
aparnasuresh85 opened a new pull request, #2585:
URL: https://github.com/apache/solr/pull/2585
https://issues.apache.org/jira/browse/SOLR-X
# Description
**Summary**
This PR introduces `CollectionPropertiesZkStateReader` to manage collection
property methods,
aparnasuresh85 closed pull request #2584: Delegate Collection Property
Management to CollectionPropertiesZkStateReader
URL: https://github.com/apache/solr/pull/2584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dsmiley commented on code in PR #2584:
URL: https://github.com/apache/solr/pull/2584#discussion_r1688177033
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -719,6 +695,10 @@ private void refreshCollectionList(Watcher watcher) throws
Keepe
dsmiley commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1688159135
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -246,6 +250,51 @@ public void testAliasHandling() throws Exception {
aparnasuresh85 opened a new pull request, #2584:
URL: https://github.com/apache/solr/pull/2584
…
https://issues.apache.org/jira/browse/SOLR-X
# Description
**Summary**
This PR introduces `CollectionPropertiesZkStateReader` to manage collection
property met
[
https://issues.apache.org/jira/browse/SOLR-17376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868082#comment-17868082
]
Michael Gibney commented on SOLR-17376:
---
Depending on your usage pattern, [this
po
[
https://issues.apache.org/jira/browse/SOLR-17376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Veit updated SOLR-17376:
--
Attachment: Bildschirmfoto vom 2024-07-18 13-23-06.png
Description:
We use the Solr Java c
Alexander Veit created SOLR-17376:
-
Summary: Direct buffer memory leak in Solr Java Client
Key: SOLR-17376
URL: https://issues.apache.org/jira/browse/SOLR-17376
Project: Solr
Issue Type: Bug
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1687768687
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1687768687
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1687768687
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection
aparnasuresh85 commented on code in PR #2571:
URL: https://github.com/apache/solr/pull/2571#discussion_r1687768687
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String
collection
59 matches
Mail list logo
