moistbeans23 opened a new pull request, #2587: URL: https://github.com/apache/solr/pull/2587
https://issues.apache.org/jira/browse/SOLR-17285 # Description Moved RemoteSolrException to SolrClient from BaseHttpSolrClient # Solution Moved RemoteSolrException class to SolrClient. Manually changed import statements from BaseHttpSolrClient to SolrClient if is not needed anymore for RemoteSolrException. Changed BaseHttpSolrClient.RemoteSolrException to SolrClient.RemoteSolrException # Tests [OUTPUT-org.apache.solr.cloud.HttpPartitionOnCommitTest.txt](https://github.com/user-attachments/files/16354132/OUTPUT-org.apache.solr.cloud.HttpPartitionOnCommitTest.txt) [OUTPUT-org.apache.solr.cloud.ReplaceNodeTest.txt](https://github.com/user-attachments/files/16354138/OUTPUT-org.apache.solr.cloud.ReplaceNodeTest.txt) [OUTPUT-org.apache.solr.handler.TestSolrConfigHandlerConcurrent.txt](https://github.com/user-attachments/files/16354141/OUTPUT-org.apache.solr.handler.TestSolrConfigHandlerConcurrent.txt) [OUTPUT-org.apache.solr.pkg.TestPackages.txt](https://github.com/user-attachments/files/16354145/OUTPUT-org.apache.solr.pkg.TestPackages.txt) I ran ./gradlew dev. It worked fine `./gradlew check` did not work. It said there were failing tests on unrelated files # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
