dsmiley commented on code in PR #2586:
URL: https://github.com/apache/solr/pull/2586#discussion_r1688787862
##########
solr/core/src/test/org/apache/solr/response/TestPrometheusResponseWriter.java:
##########
@@ -34,57 +38,104 @@
import org.junit.ClassRule;
import org.junit.Test;
-/** Tests the {@link PrometheusResponseWriter} behavior */
-@LuceneTestCase.AwaitsFix(bugUrl =
"https://issues.apache.org/jira/browse/SOLR-17368";)
public class TestPrometheusResponseWriter extends SolrTestCaseJ4 {
-
@ClassRule public static SolrJettyTestRule solrClientTestRule = new
SolrJettyTestRule();
public static JettySolrRunner jetty;
+ public static final List<String> VALID_PROMETHEUS_VALUES =
Arrays.asList("NaN", "+Inf", "-Inf");
@BeforeClass
public static void beforeClass() throws Exception {
solrClientTestRule.startSolr(LuceneTestCase.createTempDir());
jetty = solrClientTestRule.getJetty();
solrClientTestRule.newCollection().withConfigSet(ExternalPaths.DEFAULT_CONFIGSET).create();
jetty.getCoreContainer().waitForLoadingCoresToFinish(30000);
Review Comment:
can call solrClientTestRule.getCoreContainer() instead and same below; maybe
put in a var "cc" (a popular abbreviation in Solr for this super-common class)
##########
solr/core/src/test/org/apache/solr/response/TestPrometheusResponseWriter.java:
##########
@@ -34,57 +38,104 @@
import org.junit.ClassRule;
import org.junit.Test;
-/** Tests the {@link PrometheusResponseWriter} behavior */
-@LuceneTestCase.AwaitsFix(bugUrl =
"https://issues.apache.org/jira/browse/SOLR-17368";)
public class TestPrometheusResponseWriter extends SolrTestCaseJ4 {
-
@ClassRule public static SolrJettyTestRule solrClientTestRule = new
SolrJettyTestRule();
public static JettySolrRunner jetty;
Review Comment:
I think this field serves no purpose; we can get a jetty if needed from the
rule on the fly. Static fields in tests can have a maintenance burden to
ensure they get null'ed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
