mlbiscoc opened a new pull request, #2586: URL: https://github.com/apache/solr/pull/2586
https://issues.apache.org/jira/browse/SOLR-17368 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description Please provide a short description of the changes you're making with this pull request. The `TestPrometheusResponseWriter` was failing 100% of Jenkins builds due to leaking metrics from other tests running on the same JVM. This PR will redesigns the `TestPrometheusResponseWriter` to only test the structure of the output from the PrometheusResponseWriter and not the output of every metric that exists in Solr. # Solution Please provide a short description of the approach taken to implement your solution. Removed the `solr-prometheus-output.txt` output entirely. Filter out comments from the output (i.e `#` lines) and make an assertion that all metric names must start with `solr_metrics_*` and values must be a valid Prometheus accepted value `floating point number, NaN, +Inf, or -Inf` per Prometheus exposition format documentation. Also created `testPrometheusDummyOutput` that registers a dummy metrics for each registry and asserts against it's expected value. Because these are non-existent dummy values, any leaking metrics from other metrics should not override these values. # Tests Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. `testPrometheusStructureOutput` and `testPrometheusDummyOutput` # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
