cpoerschke commented on code in PR #2489: URL: https://github.com/apache/solr/pull/2489#discussion_r1688454713
########## solr/core/src/java/org/apache/solr/search/combining/QueriesCombiner.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.search.combining; + +import static org.apache.solr.common.params.CombinerParams.RECIPROCAl_RANK_FUSION; + +import java.io.IOException; +import java.util.List; +import org.apache.lucene.search.Explanation; +import org.apache.lucene.search.Query; +import org.apache.solr.common.SolrException; +import org.apache.solr.common.params.CombinerParams; +import org.apache.solr.common.params.SolrParams; +import org.apache.solr.common.util.NamedList; +import org.apache.solr.schema.IndexSchema; +import org.apache.solr.search.DocList; +import org.apache.solr.search.QueryResult; +import org.apache.solr.search.SolrIndexSearcher; + +/** + * Combining considers two or more query rankedLists: resultA, resultB ...<br> + * For a given query, each query result is a ranked list of documents La = (a1,a2,...), Lb = (b1, + * b2, ...)...<br> + * A combining algorithm creates a unique ranked list I = (i1, i2, ...).<br> + * This list is created by combining elements from the lists la and lb as described by the + * implementation algorithm.<br> + * since @Version 9.7 Used by {@link org.apache.solr.handler.component.QueryComponent} + */ +public abstract class QueriesCombiner { + + protected int upTo; + + public QueriesCombiner(SolrParams requestParams) { + this.upTo = + requestParams.getInt(CombinerParams.COMBINER_UP_TO, CombinerParams.COMBINER_UP_TO_DEFAULT); + } + + public abstract QueryResult combine(QueryResult[] rankedLists); + + protected QueryResult initCombinedResult(QueryResult[] rankedLists) { + QueryResult combinedRankedList = new QueryResult(); + boolean partialResults = false; + for (QueryResult result : rankedLists) { + partialResults |= result.isPartialResults(); + } + combinedRankedList.setPartialResults(partialResults); + + boolean segmentTerminatedEarly = false; + for (QueryResult result : rankedLists) { + if (result.getSegmentTerminatedEarly() != null) { + segmentTerminatedEarly |= result.getSegmentTerminatedEarly(); + } + } + combinedRankedList.setSegmentTerminatedEarly(segmentTerminatedEarly); + + combinedRankedList.setNextCursorMark(rankedLists[0].getNextCursorMark()); Review Comment: Not sure about picking the first list here and/or what does use of a cursor mark mean when combining queries. Alternative might be to just disallow cursor marks when combining queries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
