dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1507039357
##
solr/CHANGES.txt:
##
@@ -111,6 +111,8 @@ Improvements
* SOLR-16138: Throw a exception when issuing a streaming expression and all
cores are down instead of returnin
dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1506994591
##
solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java:
##
@@ -633,9 +631,10 @@ public final void doSyncOrReplicateRecovery(SolrCore core)
throws Exception {
rattle99 commented on PR #476:
URL: https://github.com/apache/solr/pull/476#issuecomment-1970457708
Trying to query for topK greater than 10 but cannot get more than 10
documents in response.
```
http://localhost:8983/solr/films/query?q={%21knn%20f=film_vector%20topK=17}[-0.1784,0.009
[
https://issues.apache.org/jira/browse/SOLR-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821934#comment-17821934
]
David Smiley commented on SOLR-16503:
-
I don't think there's a performance concern he
rahulgoswami commented on code in PR #2321:
URL: https://github.com/apache/solr/pull/2321#discussion_r1506927577
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/expr/StreamExpressionParser.java:
##
@@ -132,15 +132,12 @@ private static StreamExpressionName
epugh commented on code in PR #2321:
URL: https://github.com/apache/solr/pull/2321#discussion_r1506788112
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/expr/StreamExpressionParser.java:
##
@@ -132,15 +132,12 @@ private static StreamExpressionNamedParame
HoustonPutman commented on issue #688:
URL: https://github.com/apache/solr-operator/issues/688#issuecomment-1970058274
I think there are two issues here: The Solr Operator is deleting PVCs of
pods before the pods are being deleted. That is obviously a problem, and likely
causing the Balance
janhoy commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1506760404
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -0,0 +1,449 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
janhoy commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1506760404
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -0,0 +1,449 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
Jan Høydahl created SOLR-17188:
--
Summary: Create a solrj test without solr-core on classpath
Key: SOLR-17188
URL: https://issues.apache.org/jira/browse/SOLR-17188
Project: Solr
Issue Type: Impro
janhoy commented on PR #2320:
URL: https://github.com/apache/solr/pull/2320#issuecomment-1969969831
Created SOLR-17188 to track creation of such as new test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
rahulgoswami opened a new pull request, #2321:
URL: https://github.com/apache/solr/pull/2321
https://issues.apache.org/jira/browse/SOLR-17186
# Description
StreamExpressionParser today replaces ` with " indiscriminately which can
break queries where the tokens thems
janhoy commented on PR #2320:
URL: https://github.com/apache/solr/pull/2320#issuecomment-1969962794
I discovered this by chance. Obviously all our solrJ tests run with access
to solr-core on classpath?
We should likely have a test with only SolrJ and its dependencies on
classpath?
--
janhoy opened a new pull request, #2320:
URL: https://github.com/apache/solr/pull/2320
I discovered that the properties file `EnvToSyspropMappings.properties`
required by the new `EnvUtils` (SOLR-15960) was located in `core`. But since
`EnvUtils` class is in `solrj` and will fail static `in
epugh commented on PR #2319:
URL: https://github.com/apache/solr/pull/2319#issuecomment-1969940836
Nice find @VickieKarasic ! So, while `books.json` does work, it doesn't
quite line up with the "techproducts" concept... However, then I look at the
page, and I see we use book data in othe
VickieKarasic opened a new pull request, #2319:
URL: https://github.com/apache/solr/pull/2319
fix example data files
https://issues.apache.org/jira/browse/SOLR-X
# Description
When we ran the original command, we received the following error:
```
cu
jdyer1 commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1506599770
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -0,0 +1,453 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
jdyer1 commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1506578312
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -64,7 +66,7 @@ public class HttpSolrJdkClient extends HttpSolrClientBase {
private
jdyer1 commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1506577750
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -210,50 +243,50 @@ private HttpResponse doPutOrPost(
}
HttpRequest.BodyPu
jdyer1 commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1506575930
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpSolrJdkClientTest.java:
##
@@ -278,6 +281,15 @@ public void testUpdateDefault() throws Exception {
@Test
jdyer1 commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1506571244
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -0,0 +1,453 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
jdyer1 commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1506546804
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java:
##
@@ -38,7 +37,7 @@ public abstract class HttpSolrClientBuilderBase<
protected
dsmiley commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1506455155
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -0,0 +1,453 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/SOLR-17160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821831#comment-17821831
]
Gus Heck commented on SOLR-17160:
-
Interfering with some requests is perhaps less problem
jdyer1 commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1506446418
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -188,33 +210,52 @@ private HttpResponse doPutOrPost(
}
HttpRequest.BodyPu
[
https://issues.apache.org/jira/browse/SOLR-17184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821825#comment-17821825
]
ASF subversion and git services commented on SOLR-17184:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-17184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Sweeney resolved SOLR-17184.
---
Resolution: Fixed
> PeerSyncTest randomized failures due to result sorting
>
[
https://issues.apache.org/jira/browse/SOLR-17184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821824#comment-17821824
]
ASF subversion and git services commented on SOLR-17184:
Commit 7
justinrsweeney merged PR #2317:
URL: https://github.com/apache/solr/pull/2317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.ap
dsmiley commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1506438004
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpSolrJdkClientTest.java:
##
@@ -278,6 +281,15 @@ public void testUpdateDefault() throws Exception {
@Test
dsmiley commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1506391902
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java:
##
@@ -108,6 +118,29 @@ protected HttpSolrJdkClient(String serverBaseUrl,
HttpSolrJdkClie
[
https://issues.apache.org/jira/browse/SOLR-17160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821812#comment-17821812
]
Pierre Salagnac edited comment on SOLR-17160 at 2/28/24 6:43 PM:
--
[
https://issues.apache.org/jira/browse/SOLR-17160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821812#comment-17821812
]
Pierre Salagnac edited comment on SOLR-17160 at 2/28/24 6:43 PM:
--
[
https://issues.apache.org/jira/browse/SOLR-17160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821812#comment-17821812
]
Pierre Salagnac commented on SOLR-17160:
Thanks for raising this concern [~gus].
psalagnac commented on code in PR #286:
URL: https://github.com/apache/solr/pull/286#discussion_r1506394384
##
solr/core/src/test/org/apache/solr/cloud/TestShardsInfoResponse.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
janhoy commented on PR #2301:
URL: https://github.com/apache/solr/pull/2301#issuecomment-1969558381
Commons-io is still a core dependency and will likely be forever, so both
license and notice is still there.
But it is not a dependency of solrj.
--
This is an automated message from
gerlowskija commented on code in PR #2312:
URL: https://github.com/apache/solr/pull/2312#discussion_r1506368869
##
solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java:
##
@@ -153,7 +153,9 @@ public boolean doAuthenticate(
PKIHeaderData headerData = null
dsmiley commented on code in PR #2318:
URL: https://github.com/apache/solr/pull/2318#discussion_r1506343979
##
solr/test-framework/src/java/org/apache/solr/embedded/JettyConfig.java:
##
@@ -84,9 +86,14 @@ public static class Builder {
Long waitForLoadingCoresToFinishMs = 30
epugh commented on code in PR #2318:
URL: https://github.com/apache/solr/pull/2318#discussion_r1506331229
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpSolrClientBadInputTest.java:
##
Review Comment:
nice!
##
solr/test-framework/src/java/org/apache
gus-asf commented on PR #2301:
URL: https://github.com/apache/solr/pull/2301#issuecomment-1969475841
I haven't taken time to verify it but I presume the removal of commons-io
would have also removed references to it from NOTICE.txt? If we are pulling
their code back in that has to return. I
sabaribose opened a new issue, #688:
URL: https://github.com/apache/solr-operator/issues/688
I have configured HPA for the Solrcloud pods when I see the HPA status from
the Kubernetes cluster - it returns 10 pods are allocated, but from the nodes
page in the Solrcloud admin UI - it shows 58
HoustonPutman commented on issue #682:
URL: https://github.com/apache/solr-operator/issues/682#issuecomment-1969397940
Ok, so y'alls issues seem somewhat related.
I have seen problems with Solr failing to delete bad replicas during an
unsuccessful migration. And that's the reason why
janhoy commented on PR #2301:
URL: https://github.com/apache/solr/pull/2301#issuecomment-1969224632
Are you suggesting we add a snippet to solr/NOTICE.txt with a mention of the
copied content, in addition to the generic attribution we have in place for
commons-in?
--
This is an automated
justinrsweeney opened a new pull request, #2317:
URL: https://github.com/apache/solr/pull/2317
https://issues.apache.org/jira/browse/SOLR-17184
# Description
This is a small fix for an issue with PeerSyncTest where it would randomly
fail due to the order of documents returned.
[
https://issues.apache.org/jira/browse/SOLR-17184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821696#comment-17821696
]
ASF subversion and git services commented on SOLR-17184:
Commit 5
gus-asf commented on PR #2301:
URL: https://github.com/apache/solr/pull/2301#issuecomment-1969095838
None the less there should be some mechanism to track it so that if a CVE
for commons IO does come out somebody looks at it to verify that that CVE has
nothing to do with glob matching. This
[
https://issues.apache.org/jira/browse/SOLR-17160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821680#comment-17821680
]
Gus Heck commented on SOLR-17160:
-
This concept worries me. I think it's fine to have thi
cpoerschke merged PR #2089:
URL: https://github.com/apache/solr/pull/2089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache
tboeghk commented on code in PR #2315:
URL: https://github.com/apache/solr/pull/2315#discussion_r1505675887
##
solr/core/src/java/org/apache/solr/response/transform/ValueAugmenterFactory.java:
##
@@ -72,7 +72,7 @@ public DocTransformer create(String field, SolrParams params,
So
cpoerschke commented on code in PR #2315:
URL: https://github.com/apache/solr/pull/2315#discussion_r1505661209
##
solr/core/src/java/org/apache/solr/response/transform/ValueAugmenterFactory.java:
##
@@ -72,7 +72,7 @@ public DocTransformer create(String field, SolrParams params,
tboeghk opened a new pull request, #2316:
URL: https://github.com/apache/solr/pull/2316
https://issues.apache.org/jira/browse/SOLR-17187
# Description
In TLOG/PULL replica setups with longer commit intervals it would be great
to configure the interval to check for new commits m
Torsten Bøgh Köster created SOLR-17187:
--
Summary: Make replica poll interval configurable
Key: SOLR-17187
URL: https://issues.apache.org/jira/browse/SOLR-17187
Project: Solr
Issue Type:
mkhludnev commented on PR #2315:
URL: https://github.com/apache/solr/pull/2315#issuecomment-1968545878
Usually we add some _just compile_ test to make sure public won't go in
future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
janhoy merged PR #2132:
URL: https://github.com/apache/solr/pull/2132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
54 matches
Mail list logo
