tboeghk commented on code in PR #2315:
URL: https://github.com/apache/solr/pull/2315#discussion_r1505675887
##########
solr/core/src/java/org/apache/solr/response/transform/ValueAugmenterFactory.java:
##########
@@ -72,7 +72,7 @@ public DocTransformer create(String field, SolrParams params,
SolrQueryRequest r
return new ValueAugmenter(field, val);
}
- static class ValueAugmenter extends DocTransformer {
+ public static class ValueAugmenter extends DocTransformer {
final String name;
final Object value;
Review Comment:
I'd favor for `protected` visibility. That way, direct subclasses can access
the fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
