dsmiley commented on code in PR #2318:
URL: https://github.com/apache/solr/pull/2318#discussion_r1506343979
##########
solr/test-framework/src/java/org/apache/solr/embedded/JettyConfig.java:
##########
@@ -84,9 +86,14 @@ public static class Builder {
Long waitForLoadingCoresToFinishMs = 300000L;
Map<ServletHolder, String> extraServlets = new TreeMap<>();
Map<Class<? extends Filter>, String> extraFilters = new LinkedHashMap<>();
- SSLConfig sslConfig = null;
+ SSLConfig sslConfig;
int portRetryTime = 60;
+ {
Review Comment:
"instance initializer" --
https://blogs.oracle.com/javamagazine/post/java-instance-initializer-block
But yes I agree a field initializer can and should be used. I pushed this
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
