jdyer1 commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1506546804
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java:
##########
@@ -38,7 +37,7 @@ public abstract class HttpSolrClientBuilderBase<
protected Set<String> urlParamNames;
protected Integer maxConnectionsPerHost;
protected ExecutorService executor;
- protected CookieStore cookieStore;
+ protected boolean useHttp1_1 = Boolean.getBoolean("solr.http1");
Review Comment:
This was moved from `Http2SolrClient` so I left it as-is. I initially did
not see any value in supporting this in the new client. I reconsidered after
realizing the stream-cancelling bug was http/2-specific.
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java:
##########
@@ -38,7 +37,7 @@ public abstract class HttpSolrClientBuilderBase<
protected Set<String> urlParamNames;
protected Integer maxConnectionsPerHost;
protected ExecutorService executor;
- protected CookieStore cookieStore;
+ protected boolean useHttp1_1 = Boolean.getBoolean("solr.http1");
Review Comment:
This was moved from `Http2SolrClient` so I left it as-is. I initially did
not see any value in supporting this in the new client. I reconsidered after
realizing the stream-cancelling bug was http/2-specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
