jdyer1 commented on code in PR #2259:
URL: https://github.com/apache/solr/pull/2259#discussion_r1506575930
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpSolrJdkClientTest.java:
##########
@@ -278,6 +281,15 @@ public void testUpdateDefault() throws Exception {
@Test
public void testUpdateXml() throws Exception {
+ testUpdateXml(false);
+ }
+
+ @Test
+ public void testUpdateXmlWithHttp11() throws Exception {
+ testUpdateXml(true);
+ }
Review Comment:
I just read up a little on Junit4 Parameterized tests, and well, it seems so
much more complicated than what I have done here. Yes, randomization will make
the test suite run some ms faster, but I'd rather better know that nothing
broke with 1 green test run. In my opinion while randomization is very useful
we perhaps overuse it sometimes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
