[
https://issues.apache.org/jira/browse/SOLR-17096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17096:
Summary: Support for Cluster Singleton plugins in solr.xml (was: Support
for Cluster Singleton plu
janhoy commented on PR #2194:
URL: https://github.com/apache/solr/pull/2194#issuecomment-1890116752
This can be done before #2193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
janhoy opened a new pull request, #2194:
URL: https://github.com/apache/solr/pull/2194
https://issues.apache.org/jira/browse/SOLR-15960
More familiar name. Also renamed `getProps() -> getProperties()`
--
This is an automated message from the Apache Git Service.
To respond to the mes
janhoy merged PR #2191:
URL: https://github.com/apache/solr/pull/2191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy commented on code in PR #2190:
URL: https://github.com/apache/solr/pull/2190#discussion_r1450978270
##
.github/labeler.yml:
##
@@ -170,3 +173,104 @@ module:sql:
- changed-files:
- any-glob-to-any-file:
- solr/modules/sql/**
+
+# Any test source files
janhoy commented on code in PR #2190:
URL: https://github.com/apache/solr/pull/2190#discussion_r1450978270
##
.github/labeler.yml:
##
@@ -170,3 +173,104 @@ module:sql:
- changed-files:
- any-glob-to-any-file:
- solr/modules/sql/**
+
+# Any test source files
janhoy commented on code in PR #2190:
URL: https://github.com/apache/solr/pull/2190#discussion_r1450978720
##
.github/labeler.yml:
##
@@ -170,3 +173,104 @@ module:sql:
- changed-files:
- any-glob-to-any-file:
- solr/modules/sql/**
+
+# Any test source files
janhoy commented on code in PR #2190:
URL: https://github.com/apache/solr/pull/2190#discussion_r1450977221
##
.github/labeler.yml:
##
@@ -170,3 +173,135 @@ module:sql:
- changed-files:
- any-glob-to-any-file:
- solr/modules/sql/**
+
+# Any test source files
epugh commented on PR #2193:
URL: https://github.com/apache/solr/pull/2193#issuecomment-1890057983
> > > > LGTM. I sort of wish it was the full `getProperty`.
> > >
> > >
> > > We can rename `getProp -> getProperty` if you feel it is better. The
code has still not left the bui
janhoy commented on code in PR #2190:
URL: https://github.com/apache/solr/pull/2190#discussion_r1450976745
##
.github/labeler.yml:
##
@@ -170,3 +173,135 @@ module:sql:
- changed-files:
- any-glob-to-any-file:
- solr/modules/sql/**
+
+# Any test source files
janhoy commented on code in PR #2190:
URL: https://github.com/apache/solr/pull/2190#discussion_r1450975710
##
.github/labeler.yml:
##
@@ -170,3 +173,135 @@ module:sql:
- changed-files:
- any-glob-to-any-file:
- solr/modules/sql/**
+
+# Any test source files
janhoy commented on PR #2193:
URL: https://github.com/apache/solr/pull/2193#issuecomment-1890049339
> > > LGTM. I sort of wish it was the full `getProperty`.
> >
> >
> > We can rename `getProp -> getProperty` if you feel it is better. The
code has still not left the building i
epugh commented on code in PR #2193:
URL: https://github.com/apache/solr/pull/2193#discussion_r1450967732
##
solr/modules/s3-repository/src/java/org/apache/solr/s3/S3BackupRepositoryConfig.java:
##
@@ -59,7 +58,7 @@ public S3StorageClient buildClient() {
}
private static
epugh commented on PR #2193:
URL: https://github.com/apache/solr/pull/2193#issuecomment-1890045409
> > LGTM. I sort of wish it was the full `getProperty`.
>
> We can rename `getProp -> getProperty` if you feel it is better. The code
has still not left the building in a release...
janhoy commented on PR #2193:
URL: https://github.com/apache/solr/pull/2193#issuecomment-1890044549
> LGTM. I sort of wish it was the full `getProperty`.
We can rename `getProp -> getProperty` if you feel it is better. The code
has still not left the building in a release...
--
janhoy commented on code in PR #2193:
URL: https://github.com/apache/solr/pull/2193#discussion_r1450967237
##
solr/modules/s3-repository/src/java/org/apache/solr/s3/S3BackupRepositoryConfig.java:
##
@@ -59,7 +58,7 @@ public S3StorageClient buildClient() {
}
private stati
gerlowskija commented on code in PR #2144:
URL: https://github.com/apache/solr/pull/2144#discussion_r1450959834
##
solr/api/src/java/org/apache/solr/client/api/endpoint/RequestCoreCommandStatusApi.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/SOLR-15960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806211#comment-17806211
]
ASF subversion and git services commented on SOLR-15960:
Commit 8
gerlowskija commented on code in PR #2144:
URL: https://github.com/apache/solr/pull/2144#discussion_r1450959834
##
solr/api/src/java/org/apache/solr/client/api/endpoint/RequestCoreCommandStatusApi.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
gerlowskija commented on code in PR #2144:
URL: https://github.com/apache/solr/pull/2144#discussion_r1450960030
##
solr/api/src/java/org/apache/solr/client/api/endpoint/RequestCoreCommandStatusApi.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/SOLR-15960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806209#comment-17806209
]
ASF subversion and git services commented on SOLR-15960:
Commit 8
janhoy merged PR #2192:
URL: https://github.com/apache/solr/pull/2192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy commented on PR #2191:
URL: https://github.com/apache/solr/pull/2191#issuecomment-1889992866
Main and 9x since the 9.5 release will use wizard from branch 9x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
gerlowskija commented on PR #2178:
URL: https://github.com/apache/solr/pull/2178#issuecomment-1889968282
Yeah, I'm definitely with you - it's very confusing.
My intention with the `swagger-jaxrs2-jakarta` dep is that it's not a proper
Solr dependency - it's something needed by one of
[
https://issues.apache.org/jira/browse/SOLR-16808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman updated SOLR-16808:
--
Security: Public (was: Private (Security Issue))
> Solr publishes environment variables via th
dsmiley commented on code in PR #2190:
URL: https://github.com/apache/solr/pull/2190#discussion_r1450859664
##
.github/labeler.yml:
##
@@ -170,3 +173,135 @@ module:sql:
- changed-files:
- any-glob-to-any-file:
- solr/modules/sql/**
+
+# Any test source files
[
https://issues.apache.org/jira/browse/SOLR-16963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-16963.
---
Assignee: Houston Putman
Resolution: Fixed
> verifyClientHostName is used incorrectly
>
[
https://issues.apache.org/jira/browse/SOLR-16963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman closed SOLR-16963.
-
> verifyClientHostName is used incorrectly
>
>
>
[
https://issues.apache.org/jira/browse/SOLR-16963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman updated SOLR-16963:
--
Fix Version/s: (was: 8.11.3)
> verifyClientHostName is used incorrectly
> -
pjmcarthur commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1450781121
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -211,6 +215,17 @@ private NodeConfig(
if (null == this.solrHome) throw new NullPointerException("
pjmcarthur commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1450776885
##
solr/core/src/test/org/apache/solr/cluster/placement/impl/PlacementPluginIntegrationTest.java:
##
@@ -124,25 +124,6 @@ public void testConfigurationInSystemProps() {
pjmcarthur commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1450773853
##
solr/core/src/java/org/apache/solr/api/NodeConfigClusterPluginsSource.java:
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
alexangas closed issue #676: Resources limits and requests configuration not
set on SolrCloud pod
URL: https://github.com/apache/solr-operator/issues/676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
alexangas commented on issue #676:
URL: https://github.com/apache/solr-operator/issues/676#issuecomment-1889510096
Never mind. It is a bug in the tooling that i'm using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
raboof opened a new pull request, #95:
URL: https://github.com/apache/solr-site/pull/95
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
alexangas opened a new issue, #676:
URL: https://github.com/apache/solr-operator/issues/676
I've been attempting to set config such as
`podOptions.resources.requests.cpu` in the Helm chart for SolrCloud. However
none of the changes in the `podOptions.resources` settings appear to be
applyi
dsmiley commented on code in PR #2189:
URL: https://github.com/apache/solr/pull/2189#discussion_r1450551809
##
.gitignore:
##
@@ -24,22 +22,20 @@ out/
.editorconfig
-# syncthing
-.stignore
Review Comment:
Not a huge problem, but I guess I’m kind of a purist, preferring
[
https://issues.apache.org/jira/browse/SOLR-17111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806066#comment-17806066
]
Jan Høydahl commented on SOLR-17111:
See
[https://cwiki.apache.org/confluence/displa
[
https://issues.apache.org/jira/browse/SOLR-17115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806064#comment-17806064
]
Jan Høydahl commented on SOLR-17115:
The strategy will be to wrap either Sampler or S
[
https://issues.apache.org/jira/browse/SOLR-17117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Suleyman Ekmekci updated SOLR-17117:
Priority: Minor (was: Major)
> Proposing to add Generative Search (RAG) to Solr
>
Suleyman Ekmekci created SOLR-17117:
---
Summary: Proposing to add Generative Search (RAG) to Solr
Key: SOLR-17117
URL: https://issues.apache.org/jira/browse/SOLR-17117
Project: Solr
Issue Typ
pvcnt commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1450387463
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -211,6 +215,17 @@ private NodeConfig(
if (null == this.solrHome) throw new NullPointerException("solrH
janhoy opened a new pull request, #2191:
URL: https://github.com/apache/solr/pull/2191
As a new `branch_X_Y` branch is created, it should be added to list of
protected branches.
These commands are not tested, so please do a thorough manual review.
--
This is an automated message fr
pvcnt commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1450386197
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -211,6 +215,17 @@ private NodeConfig(
if (null == this.solrHome) throw new NullPointerException("solrH
janhoy commented on PR #1151:
URL: https://github.com/apache/solr/pull/1151#issuecomment-1888921332
Test of auto JIRA links feature: SOLR-16155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
janhoy merged PR #2185:
URL: https://github.com/apache/solr/pull/2185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy commented on code in PR #2185:
URL: https://github.com/apache/solr/pull/2185#discussion_r1450266926
##
.asf.yaml:
##
@@ -18,6 +18,18 @@ github:
merge: false
rebase: false
+ protected_branches:
+main: {}
Review Comment:
Also, `.asf.yaml` does not supp
janhoy commented on code in PR #2185:
URL: https://github.com/apache/solr/pull/2185#discussion_r1450265891
##
.asf.yaml:
##
@@ -18,6 +18,18 @@ github:
merge: false
rebase: false
+ protected_branches:
+main: {}
Review Comment:
I added lines for all current `
janhoy merged PR #2187:
URL: https://github.com/apache/solr/pull/2187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy commented on code in PR #2189:
URL: https://github.com/apache/solr/pull/2189#discussion_r1450211315
##
.gitignore:
##
@@ -24,22 +22,20 @@ out/
.editorconfig
-# syncthing
-.stignore
Review Comment:
I see no harm in this, as it reduces the chance of any future cont
janhoy opened a new pull request, #2190:
URL: https://github.com/apache/solr/pull/2190
Followup from #2180
Add GH labels based on java packages, e.g. for a package
`org.apache.solr.foo[.xxx]`, assign label `cat:foo`.
Also added label `tests` when any test is touched.
Mo
51 matches
Mail list logo
