janhoy commented on code in PR #2189: URL: https://github.com/apache/solr/pull/2189#discussion_r1450211315
########## .gitignore: ########## @@ -24,22 +22,20 @@ out/ .editorconfig -# syncthing -.stignore Review Comment: I see no harm in this, as it reduces the chance of any future contributor accidentally committing this file if they use such tool. A few extra lines in gitignore is tolerable. We’re not adding every possible tool in here, but devs will add such as they experience the pain with a certain tool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org