dsmiley commented on code in PR #2190:
URL: https://github.com/apache/solr/pull/2190#discussion_r1450859664
##########
.github/labeler.yml:
##########
@@ -170,3 +173,135 @@ module:sql:
- changed-files:
- any-glob-to-any-file:
- solr/modules/sql/**
+
+# Any test source files
+tests:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/src/test/**'
+ - '**/src/test-files/**'
+
+# Add category labels based on java pacakges
+# In essence, for a package org.apache.solr.foo[.xxx], assign label cat:foo
+cat:analysis:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/analysis/**'
+
+cat:cli:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/cli/**'
+
+cat:cloud:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/cloud/**'
+
+cat:cluster:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/cluster/**'
+
+cat:backup:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/core/backup/**'
+ - '**/org/apache/solr/hdfs/backup/**'
+
+cat:core:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/core/**'
+
+cat:filestore:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/filestore/**'
+
+cat:handler:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/handler/**'
+
+cat:highlight:
Review Comment:
too feature specific to warrant a category?
##########
.github/labeler.yml:
##########
@@ -170,3 +173,135 @@ module:sql:
- changed-files:
- any-glob-to-any-file:
- solr/modules/sql/**
+
+# Any test source files
+tests:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/src/test/**'
+ - '**/src/test-files/**'
+
+# Add category labels based on java pacakges
+# In essence, for a package org.apache.solr.foo[.xxx], assign label cat:foo
+cat:analysis:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/analysis/**'
+
+cat:cli:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/cli/**'
+
+cat:cloud:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/cloud/**'
+
+cat:cluster:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/cluster/**'
+
+cat:backup:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/core/backup/**'
+ - '**/org/apache/solr/hdfs/backup/**'
+
+cat:core:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/core/**'
+
+cat:filestore:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/filestore/**'
+
+cat:handler:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/handler/**'
+
+cat:highlight:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/highlight/**'
+
+cat:index:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/index/**'
+ - '**/org/apache/solr/hdfs/index/**'
+
+cat:logging:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/logging/**'
+
+cat:metrics:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/metrics/**'
+
+cat:packagemanager:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/packagemanager/**'
+ - '**/org/apache/solr/pkg/**'
+
+cat:query:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/parser/**'
+ - '**/org/apache/solr/query/**'
+
+cat:request:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/request/**'
+
+cat:response:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/response/**'
+
+cat:schema:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/rest/**'
+ - '**/org/apache/solr/schema/**'
+
+cat:search:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/search/**'
+
+cat:security:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/security/**'
+
+cat:servlet:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/servlet/**'
+
+cat:spelling:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/spelling/**'
+
+cat:update:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/update/**'
+ - '**/org/apache/solr/hdfs/update/**'
+ - '**/org/apache/solr/scripting/update/**'
+
+cat:util:
Review Comment:
Is such a generic category useful?
##########
.github/labeler.yml:
##########
@@ -170,3 +173,135 @@ module:sql:
- changed-files:
- any-glob-to-any-file:
- solr/modules/sql/**
+
+# Any test source files
+tests:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/src/test/**'
+ - '**/src/test-files/**'
+
+# Add category labels based on java pacakges
+# In essence, for a package org.apache.solr.foo[.xxx], assign label cat:foo
+cat:analysis:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/analysis/**'
+
+cat:cli:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/cli/**'
+
+cat:cloud:
+ - changed-files:
+ - any-glob-to-any-file:
+ - '**/org/apache/solr/cloud/**'
+
+cat:cluster:
Review Comment:
I don't think this is really distinct from SolrCloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
