epugh commented on code in PR #2193: URL: https://github.com/apache/solr/pull/2193#discussion_r1450967732
########## solr/modules/s3-repository/src/java/org/apache/solr/s3/S3BackupRepositoryConfig.java: ########## @@ -59,7 +58,7 @@ public S3StorageClient buildClient() { } private static String getStringConfig(NamedList<?> config, String property) { - String envProp = System.getenv().get(toEnvVar(property)); + String envProp = EnvUtils.getProp(property); Review Comment: Nice! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org