janhoy commented on PR #2193: URL: https://github.com/apache/solr/pull/2193#issuecomment-1890049339
> > > LGTM. I sort of wish it was the full `getProperty`..... > > > > > > We can rename `getProp -> getProperty` if you feel it is better. The code has still not left the building in a release... > > It matches the System.getProperty pattern, and just seems like one less thing to mentally parse... It has crossed my mind. Can be a followup to this.. PS: Do you think that `EnvUtils` is a covering name, or would `NodeEnv` or `SolrEnv` or similar be better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
