noblepaul commented on PR #1318:
URL: https://github.com/apache/solr/pull/1318#issuecomment-1420186434
> I wonder this optimization should go into
[get()](https://github.com/apache/solr/blob/e7e487e1694231b6e586276742e598de06acd9bf/solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/Z
hiteshk25 commented on PR #1318:
URL: https://github.com/apache/solr/pull/1318#issuecomment-1419774008
I wonder this optimization should go into
[get()](https://github.com/apache/solr/blob/e7e487e1694231b6e586276742e598de06acd9bf/solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkS
[
https://issues.apache.org/jira/browse/SOLR-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684931#comment-17684931
]
David Smiley commented on SOLR-16623:
-
More comments:
* Scope to SolrJettyTestBase w
[
https://issues.apache.org/jira/browse/SOLR-16595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684920#comment-17684920
]
Eric Pugh commented on SOLR-16595:
--
I've just opened a PR with an example of changing on
epugh opened a new pull request, #1338:
URL: https://github.com/apache/solr/pull/1338
This change is going to touch a lot of places ;-)
https://issues.apache.org/jira/browse/SOLR-16595
# Description
Introduce the `TimeUnit unit` parameter to our Builder, and then internally
[
https://issues.apache.org/jira/browse/SOLR-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684917#comment-17684917
]
Kevin Risden commented on SOLR-5707:
>From https://github.com/risdenk/lucene-jmh I add
hiteshk25 commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1097855642
##
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##
@@ -488,4 +494,27 @@ public interface CollectionStateProps {
String SHARDS = "shards";
[
https://issues.apache.org/jira/browse/SOLR-16595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-16595:
Assignee: Eric Pugh
> Standardize Builder handling of times
>
[
https://issues.apache.org/jira/browse/SOLR-16590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-16590.
--
Fix Version/s: main (10.0)
9.2
Resolution: Fixed
> Standardize Builder method
[
https://issues.apache.org/jira/browse/SOLR-16590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684913#comment-17684913
]
ASF subversion and git services commented on SOLR-16590:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-16590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684912#comment-17684912
]
ASF subversion and git services commented on SOLR-16590:
Commit e
epugh merged PR #1334:
URL: https://github.com/apache/solr/pull/1334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
Grace Sainsbury created SOLR-16648:
--
Summary: NullPointerException when using facets in More Like This
Query
Key: SOLR-16648
URL: https://issues.apache.org/jira/browse/SOLR-16648
Project: Solr
andywebb1975 commented on PR #1324:
URL: https://github.com/apache/solr/pull/1324#issuecomment-1419588565
I've updated this to use an `enum` following one of the examples above - how
does it look now?
(I've seen `gradlew check` work locally but Crave.io seems to be having
issues :-(
[
https://issues.apache.org/jira/browse/SOLR-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684861#comment-17684861
]
Mikhail Khludnev commented on SOLR-788:
---
I see, Alessandro. Take your time!
> MoreLi
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097766488
##
solr/solrj/src/test/org/apache/solr/client/solrj/request/SolrPingTest.java:
##
@@ -31,18 +30,18 @@ public class SolrPingTest extends
EmbeddedSolrServerTestBase {
@B
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097765893
##
solr/solrj/src/test/org/apache/solr/client/solrj/request/SolrPingTest.java:
##
@@ -31,18 +30,18 @@ public class SolrPingTest extends
EmbeddedSolrServerTestBase {
@B
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097765116
##
solr/solrj/src/test/org/apache/solr/client/solrj/LargeVolumeTestBase.java:
##
@@ -41,7 +41,7 @@ public abstract class LargeVolumeTestBase extends
EmbeddedSolrServerTestB
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097764373
##
solr/solrj/src/test/org/apache/solr/client/solrj/GetByIdTest.java:
##
@@ -30,7 +35,9 @@ public class GetByIdTest extends EmbeddedSolrServerTestBase {
@BeforeClass
dsmiley commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097759108
##
solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSpellCheckResponse.java:
##
@@ -34,17 +38,26 @@
* @since solr 1.3
*/
public class TestSpellCheckRespo
dsmiley commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097758339
##
solr/solrj/src/test/org/apache/solr/client/solrj/request/SolrPingTest.java:
##
@@ -31,18 +30,18 @@ public class SolrPingTest extends
EmbeddedSolrServerTestBase {
dsmiley commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097739481
##
solr/solrj/src/test/org/apache/solr/client/solrj/request/SolrPingTest.java:
##
@@ -31,18 +30,18 @@ public class SolrPingTest extends
EmbeddedSolrServerTestBase {
[
https://issues.apache.org/jira/browse/SOLR-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684837#comment-17684837
]
ASF subversion and git services commented on SOLR-16646:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16646:
Fix Version/s: 9.2
Resolution: Fixed
Status: Resolved (was: Patch Available)
Tha
dsmiley commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097734387
##
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/LargeVolumeJettyTest.java:
##
@@ -16,12 +16,17 @@
*/
package org.apache.solr.client.solrj.embedded;
+impo
dsmiley commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097733584
##
solr/solrj/src/test/org/apache/solr/client/solrj/LargeVolumeTestBase.java:
##
@@ -41,7 +41,7 @@ public abstract class LargeVolumeTestBase extends
EmbeddedSolrServerTes
[
https://issues.apache.org/jira/browse/SOLR-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16646:
Summary: Create a new function query operator isnan to verify if value is
NaN (was: Create a new f
[
https://issues.apache.org/jira/browse/SOLR-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16646:
Status: Patch Available (was: Open)
> Create a new function query operator to verify if value is N
[
https://issues.apache.org/jira/browse/SOLR-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden reassigned SOLR-16646:
---
Assignee: Kevin Risden
> Create a new function query operator to verify if value is NaN (isn
dsmiley commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097731269
##
solr/solrj/src/test/org/apache/solr/client/solrj/GetByIdTest.java:
##
@@ -30,7 +35,9 @@ public class GetByIdTest extends EmbeddedSolrServerTestBase {
@BeforeClass
[
https://issues.apache.org/jira/browse/SOLR-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684834#comment-17684834
]
ASF subversion and git services commented on SOLR-16646:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16646:
Fix Version/s: main (10.0)
> Create a new function query operator to verify if value is NaN (isnan)
risdenk commented on PR #1331:
URL: https://github.com/apache/solr/pull/1331#issuecomment-1419504090
Thanks @gabrielmagno
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
risdenk merged PR #1331:
URL: https://github.com/apache/solr/pull/1331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684830#comment-17684830
]
Alessandro Benedetti commented on SOLR-788:
---
Apologies again, a month has passed
dependabot[bot] opened a new pull request, #521:
URL: https://github.com/apache/solr-operator/pull/521
Bumps
[github.com/containerd/containerd](https://github.com/containerd/containerd)
from 1.6.6 to 1.6.12.
Release notes
Sourced from https://github.com/containerd/containerd/relea
dsmiley commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097692849
##
solr/core/src/java/org/apache/solr/update/UpdateShardHandlerConfig.java:
##
@@ -32,6 +32,15 @@ public class UpdateShardHandlerConfig {
DEFAULT_METRICNAMESTRA
HoustonPutman closed issue #134: Introduce comprehensive integration tests
URL: https://github.com/apache/solr-operator/issues/134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
HoustonPutman merged PR #507:
URL: https://github.com/apache/solr-operator/pull/507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
dsmiley commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097686717
##
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/LargeVolumeJettyTest.java:
##
@@ -16,12 +16,17 @@
*/
package org.apache.solr.client.solrj.embedded;
+impo
risdenk commented on PR #1319:
URL: https://github.com/apache/solr/pull/1319#issuecomment-1419442129
Thanks @tylerbertrand. if needed, I'm happy to help port to Lucene.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
risdenk merged PR #1319:
URL: https://github.com/apache/solr/pull/1319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
tylerbertrand commented on PR #1319:
URL: https://github.com/apache/solr/pull/1319#issuecomment-1419430398
> LGTM
>
> Could you please port over the changes to APache Lucene? It should mostly
merge across checkout (you can relatively easy cherry-pick the commit from the
solr repo int
erichaagdev commented on PR #1319:
URL: https://github.com/apache/solr/pull/1319#issuecomment-1419428027
> If it's alright with you I think it can be merged as-is, and I'll apply
those changes in a later PR.
I'm fine with this. It was only a suggestion. 👍
--
This is an automated m
[
https://issues.apache.org/jira/browse/SOLR-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-16629.
-
Fix Version/s: 9.2
Resolution: Fixed
> Replace SolrSingleThreaded and SolrThreadSafe annot
tylerbertrand commented on PR #1319:
URL: https://github.com/apache/solr/pull/1319#issuecomment-1419423953
> @tylerbertrand I see a few potentially outstanding comments on this from
@erichaagdev - do you plan to address those? If not happy to merge as is.
If it's alright with you I th
[
https://issues.apache.org/jira/browse/SOLR-16639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16639:
Status: Patch Available (was: Open)
> solr-exporter metrics node_thread_pool_completed_total occur
uschindler commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1419329442
Thanks, I created https://github.com/apache/lucene/pull/12131 for Apache
Lucene (cherrypicking was easy). Please have a look.
--
This is an automated message from the Apache Git Service
risdenk commented on PR #1203:
URL: https://github.com/apache/solr/pull/1203#issuecomment-1419320590
@raboof I pushed a change to your PR branch that moves the logic to
`gradle/validation/cyclonedx-bom.gradle` to match other build plugins. As far
as I can tell this is a decent first step.
[
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684781#comment-17684781
]
ASF subversion and git services commented on SOLR-16531:
Commit 3
mkhludnev commented on code in PR #1324:
URL: https://github.com/apache/solr/pull/1324#discussion_r1097437061
##
solr/core/src/java/org/apache/solr/search/ReRankQParserPlugin.java:
##
@@ -72,25 +74,33 @@ public Query parse() throws SyntaxError {
double reRankWeight = lo
[
https://issues.apache.org/jira/browse/SOLR-16608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684776#comment-17684776
]
Jason Gerlowski commented on SOLR-16608:
Also - I see this is backported - should
[
https://issues.apache.org/jira/browse/SOLR-16647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16647:
Fix Version/s: 9.2
> Circuit breaker examples are wrong and don't match documentation
> ---
[
https://issues.apache.org/jira/browse/SOLR-16647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684771#comment-17684771
]
ASF subversion and git services commented on SOLR-16647:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-16608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684772#comment-17684772
]
Jason Gerlowski commented on SOLR-16608:
Any sense for what sort of performance i
[
https://issues.apache.org/jira/browse/SOLR-16647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16647:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Circuit breaker examples are w
[
https://issues.apache.org/jira/browse/SOLR-16647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16647:
Fix Version/s: main (10.0)
> Circuit breaker examples are wrong and don't match documentation
> ---
risdenk merged PR #1333:
URL: https://github.com/apache/solr/pull/1333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-16647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684766#comment-17684766
]
ASF subversion and git services commented on SOLR-16647:
Commit 2
epugh commented on code in PR #1334:
URL: https://github.com/apache/solr/pull/1334#discussion_r1097552427
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -1096,38 +1096,89 @@ public Builder withTheseParamNamesInTheUrl(Set
urlParamNames) {
epugh commented on PR #1337:
URL: https://github.com/apache/solr/pull/1337#issuecomment-1419282361
thanks @cesnietor for the fix!If you are interested in doing more in the
tutorials, one thing would be to look at how they are organized in the ref
guide and update them a bit. For examp
epugh merged PR #1337:
URL: https://github.com/apache/solr/pull/1337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-16631.
--
Fix Version/s: main (10.0)
9.2
Assignee: Eric Pugh
Resolution: Fixed
[
https://issues.apache.org/jira/browse/SOLR-16647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden reassigned SOLR-16647:
---
Assignee: Kevin Risden
> Circuit breaker examples are wrong and don't match documentation
>
[
https://issues.apache.org/jira/browse/SOLR-16647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16647:
Status: Patch Available (was: Open)
> Circuit breaker examples are wrong and don't match documenta
risdenk commented on PR #1319:
URL: https://github.com/apache/solr/pull/1319#issuecomment-1419267953
@tylerbertrand I see a few potentially outstanding comments on this from
@erichaagdev - do you plan to address those? If not happy to merge as is.
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/SOLR-16641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16641:
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks [~cjcowie]
> Circular ta
[
https://issues.apache.org/jira/browse/SOLR-16641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684753#comment-17684753
]
ASF subversion and git services commented on SOLR-16641:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-16641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16641:
Fix Version/s: 9.2
> Circular task dependency in localSettings (Generate gradle.properties from
>
[
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684752#comment-17684752
]
ASF subversion and git services commented on SOLR-16531:
Commit e
gerlowskija merged PR #1335:
URL: https://github.com/apache/solr/pull/1335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
[
https://issues.apache.org/jira/browse/SOLR-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684751#comment-17684751
]
ASF subversion and git services commented on SOLR-16631:
Commit 0
risdenk commented on PR #1302:
URL: https://github.com/apache/solr/pull/1302#issuecomment-1419258816
@magibney #1313 was merged so this should be good to go resolving any
conflicts :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/SOLR-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684750#comment-17684750
]
ASF subversion and git services commented on SOLR-16631:
Commit 7
epugh merged PR #1325:
URL: https://github.com/apache/solr/pull/1325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
risdenk commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1419253143
Thanks @colvinco!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
cpoerschke commented on code in PR #1324:
URL: https://github.com/apache/solr/pull/1324#discussion_r1097524675
##
solr/core/src/java/org/apache/solr/search/ReRankQParserPlugin.java:
##
@@ -72,25 +74,33 @@ public Query parse() throws SyntaxError {
double reRankWeight = l
[
https://issues.apache.org/jira/browse/SOLR-16641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16641:
Fix Version/s: main (10.0)
> Circular task dependency in localSettings (Generate gradle.properties
[
https://issues.apache.org/jira/browse/SOLR-16641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684746#comment-17684746
]
ASF subversion and git services commented on SOLR-16641:
Commit 5
risdenk merged PR #1320:
URL: https://github.com/apache/solr/pull/1320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-16634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684744#comment-17684744
]
Kevin Risden commented on SOLR-16634:
-
SOLR-16641 is going to fix this
> "gradlew ch
[
https://issues.apache.org/jira/browse/SOLR-16641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16641:
Status: Patch Available (was: Open)
> Circular task dependency in localSettings (Generate gradle.p
[
https://issues.apache.org/jira/browse/SOLR-16641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden reassigned SOLR-16641:
---
Assignee: Kevin Risden
> Circular task dependency in localSettings (Generate gradle.properti
[
https://issues.apache.org/jira/browse/SOLR-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-15955:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Update Jetty dependency to 10
[
https://issues.apache.org/jira/browse/SOLR-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684740#comment-17684740
]
ASF subversion and git services commented on SOLR-15955:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684738#comment-17684738
]
ASF subversion and git services commented on SOLR-15955:
Commit 3
risdenk merged PR #1330:
URL: https://github.com/apache/solr/pull/1330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
risdenk commented on code in PR #1330:
URL: https://github.com/apache/solr/pull/1330#discussion_r1097506015
##
solr/CHANGES.txt:
##
@@ -51,6 +51,8 @@ New Features
* SOLR-16596: Learning To Rank - Added support for null feature values in
multiple additive trees models (Anna R
gerlowskija commented on PR #1335:
URL: https://github.com/apache/solr/pull/1335#issuecomment-1419169682
Alright, thanks for the reviews guys. Aiming to merge this later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
epugh commented on PR #1325:
URL: https://github.com/apache/solr/pull/1325#issuecomment-1419039510
@Paul-Blanchaert can you either give me ability to commit (Push?) changes to
the PR, or modify the change log to add a ` via Eric Pugh` and then I'll merge!
Thanks for the contirbution!
--
joshgog commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097325228
##
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/AbstractEmbeddedSolrServerTestCase.java:
##
@@ -104,4 +110,8 @@ protected SolrClient getSolrCore1() {
prote
epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097324599
##
solr/solrj/src/test/org/apache/solr/client/solrj/LargeVolumeTestBase.java:
##
@@ -41,7 +41,7 @@ public abstract class LargeVolumeTestBase extends
EmbeddedSolrServerTestB
joshgog commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097310816
##
solr/solrj/src/test/org/apache/solr/client/solrj/LargeVolumeTestBase.java:
##
@@ -41,7 +41,7 @@ public abstract class LargeVolumeTestBase extends
EmbeddedSolrServerTes
andywebb1975 commented on code in PR #1324:
URL: https://github.com/apache/solr/pull/1324#discussion_r1097178117
##
solr/core/src/java/org/apache/solr/search/ReRankQParserPlugin.java:
##
@@ -72,25 +74,33 @@ public Query parse() throws SyntaxError {
double reRankWeight =
94 matches
Mail list logo
