epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097764373
##########
solr/solrj/src/test/org/apache/solr/client/solrj/GetByIdTest.java:
##########
@@ -30,7 +35,9 @@ public class GetByIdTest extends EmbeddedSolrServerTestBase {
@BeforeClass
public static void beforeClass() throws Exception {
- initCore();
+ solrClientTestRule.startSolr(LuceneTestCase.createTempDir("solrhome"));
Review Comment:
Maybe it's just my love for the Rails world's view of "convention over
configuration"... I'd love to see us strongly advocate for one approach
whenever there are two approaches available because of the wide variety of
folks working on Solr. I suspect most folks are copy/pasting to decide how to
do things, and aren't thinking carefully thorugh one option or the other. If
you provide two options that appear similarily good then you will live with two
ways of doing it henceforth! I'd love to see that `startSolr()` ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
