dsmiley commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097692849
##########
solr/core/src/java/org/apache/solr/update/UpdateShardHandlerConfig.java:
##########
@@ -32,6 +32,15 @@ public class UpdateShardHandlerConfig {
DEFAULT_METRICNAMESTRATEGY,
DEFAULT_MAXRECOVERYTHREADS);
+ public static final UpdateShardHandlerConfig TEST_DEFAULT =
Review Comment:
That's debatable... because there is no obvious place where it would live
exactly. I suppose TestHarness *was* okay maybe but now that TestHarness has a
competitor, ehh....
As it's just a "config" thing and not some heavy object, its home seems
arbitrary to me -- not a problem that it's created in production. I don't have
a strong opinion though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
