dsmiley commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097686717
##########
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/LargeVolumeJettyTest.java:
##########
@@ -16,12 +16,17 @@
*/
package org.apache.solr.client.solrj.embedded;
+import java.nio.file.Paths;
+import org.apache.solr.SolrJettyTestBase;
import org.apache.solr.client.solrj.LargeVolumeTestBase;
import org.junit.BeforeClass;
public class LargeVolumeJettyTest extends LargeVolumeTestBase {
@BeforeClass
public static void beforeTest() throws Exception {
- initCore();
+ solrClientTestRule
Review Comment:
@joshgog in the new Jetty based TestRule you are working on, lets address
this issue above (a test that should be using Jetty but isn't any longer) on
this test by using the new rule! Basically, change LargeVolumeTestBase to
subclass SolrTestCase instead of EmbeddedSolrServerTestBase, and instead
declare whichever rule we want based on the test.
CC @epugh this is the TODO that wasn't clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
