epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1097324599
##########
solr/solrj/src/test/org/apache/solr/client/solrj/LargeVolumeTestBase.java:
##########
@@ -41,7 +41,7 @@ public abstract class LargeVolumeTestBase extends
EmbeddedSolrServerTestBase {
@Test
public void testMultiThreaded() throws Exception {
- SolrClient client = this.getSolrClient();
+ SolrClient client = getSolrClient();
Review Comment:
I get that.. What I'm wondering is that it appears that sometimes we use
the helper pattern of a `getSolrClient()`, but in other tests we use the full
explicit `solrClientTestRule.getSolrClient()`.... Feels like we should try
and have one pattern? Maybe just a bikeshed..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
