[
https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501631#comment-17501631
]
David Smiley commented on SOLR-16072:
-
Got it but my recommendation (a text file of f
dsmiley commented on a change in pull request #726:
URL: https://github.com/apache/solr/pull/726#discussion_r820018229
##
File path: solr/core/build.gradle
##
@@ -139,12 +139,12 @@ dependencies {
implementation 'org.apache.logging.log4j:log4j-core'
implementation 'org.apa
[
https://issues.apache.org/jira/browse/SOLR-16077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501598#comment-17501598
]
Ben commented on SOLR-16077:
Thanks for the quick response, Jan!
Sure, I wrote similar Pytho
[
https://issues.apache.org/jira/browse/SOLR-16077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501588#comment-17501588
]
Jan Høydahl commented on SOLR-16077:
Most users would likely use the HTTP API to add
janhoy commented on pull request #726:
URL: https://github.com/apache/solr/pull/726#issuecomment-1059599561
Isn't the `server/lib/` folder to be treated as "provided" (in maven speak),
i.e. libs that are provided by the container and thus should NOT be in the
webapp. Is `compileOnlyApi` an
dsmiley commented on pull request #657:
URL: https://github.com/apache/solr/pull/657#issuecomment-1059598594
Ready for review again. Pending:
* updated CHANGES.txt, major-changes-in-solr-9.adoc
* precommit fix / merge with main
* updating the Solr ref guide
--
This is an automat
madrob commented on a change in pull request #729:
URL: https://github.com/apache/solr/pull/729#discussion_r819976837
##
File path: gradle/validation/forbidden-apis/commons-io.commons-io.all.txt
##
@@ -0,0 +1,2 @@
+@defaultMessage Use
org.apache.commons.io.file.PathUtils#delet
[
https://issues.apache.org/jira/browse/SOLR-16075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501580#comment-17501580
]
ASF subversion and git services commented on SOLR-16075:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-16075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501579#comment-17501579
]
ASF subversion and git services commented on SOLR-16075:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-16075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-16075.
Fix Version/s: 9.0
Resolution: Fixed
> ShowFileHandler path parameter should be relative to
HoustonPutman commented on pull request #729:
URL: https://github.com/apache/solr/pull/729#issuecomment-1059580793
Might as well replace the method in custom method in
`LocalFileSystemRepository` used in https://github.com/apache/solr/pull/728.
Really not sure why FileUtils uses `cle
[
https://issues.apache.org/jira/browse/SOLR-16074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501569#comment-17501569
]
Kevin Risden commented on SOLR-16074:
-
Put up a PR switching over to PathUtils. I hav
risdenk opened a new pull request #729:
URL: https://github.com/apache/solr/pull/729
https://issues.apache.org/jira/browse/SOLR-16074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
HoustonPutman commented on a change in pull request #728:
URL: https://github.com/apache/solr/pull/728#discussion_r819958608
##
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
##
@@ -490,7 +490,7 @@ protected static boolean isSSLMode() {
public st
[
https://issues.apache.org/jira/browse/SOLR-16074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501563#comment-17501563
]
Kevin Risden commented on SOLR-16074:
-
Based on the linked commons-io jira:
"PathUti
[
https://issues.apache.org/jira/browse/SOLR-16070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501556#comment-17501556
]
Erick Erickson commented on SOLR-16070:
---
Pushed, I think I did it right
> Enab
[
https://issues.apache.org/jira/browse/SOLR-16041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-16041.
Fix Version/s: 9.0
Resolution: Fixed
> Prepare a Jenkins job that runs smoke tester on 9.0
>
[
https://issues.apache.org/jira/browse/SOLR-16041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501551#comment-17501551
]
ASF subversion and git services commented on SOLR-16041:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-16041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501550#comment-17501550
]
ASF subversion and git services commented on SOLR-16041:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-16076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-16076:
---
Fix Version/s: 9.0
> Update smoke test for moved bin-test scripts
> -
madrob commented on a change in pull request #728:
URL: https://github.com/apache/solr/pull/728#discussion_r819930748
##
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
##
@@ -490,7 +490,7 @@ protected static boolean isSSLMode() {
public static vo
[
https://issues.apache.org/jira/browse/SOLR-16074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501543#comment-17501543
]
David Smiley commented on SOLR-16074:
-
Congrats on finding the cause here! A week ag
HoustonPutman opened a new pull request #728:
URL: https://github.com/apache/solr/pull/728
https://issues.apache.org/jira/browse/SOLR-16074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
[
https://issues.apache.org/jira/browse/SOLR-16077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben updated SOLR-16077:
---
Description:
I'm working with Solr 7 because reasons, but the issue also seems to persist in
the current code base.
[
https://issues.apache.org/jira/browse/SOLR-16077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben updated SOLR-16077:
---
Description:
I'm working with Solr 7 because reasons, but the issue also seems to persist in
the current code base.
Ben created SOLR-16077:
--
Summary: Solr basic authentication is undocumented and a bit
strange
Key: SOLR-16077
URL: https://issues.apache.org/jira/browse/SOLR-16077
Project: Solr
Issue Type: Bug
S
[
https://issues.apache.org/jira/browse/SOLR-16074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman updated SOLR-16074:
--
Fix Version/s: 9.0
Affects Version/s: 9.0
(was: 9.1)
[
https://issues.apache.org/jira/browse/SOLR-16074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501535#comment-17501535
]
Houston Putman commented on SOLR-16074:
---
Ok after much digging, it looks like the i
dsmiley commented on a change in pull request #726:
URL: https://github.com/apache/solr/pull/726#discussion_r819900836
##
File path: solr/core/build.gradle
##
@@ -139,12 +139,12 @@ dependencies {
implementation 'org.apache.logging.log4j:log4j-core'
implementation 'org.apa
cpoerschke commented on a change in pull request #726:
URL: https://github.com/apache/solr/pull/726#discussion_r819898742
##
File path: solr/core/build.gradle
##
@@ -139,12 +139,12 @@ dependencies {
implementation 'org.apache.logging.log4j:log4j-core'
implementation 'org.
madrob opened a new pull request #727:
URL: https://github.com/apache/solr/pull/727
https://issues.apache.org/jira/browse/SOLR-16076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
risdenk commented on pull request #726:
URL: https://github.com/apache/solr/pull/726#issuecomment-1059499957
FWIW this also comes into play somehow:
https://github.com/apache/solr/blob/main/solr/webapp/build.gradle#L31
See how Solr core and then excluding solr server. I really
risdenk commented on pull request #726:
URL: https://github.com/apache/solr/pull/726#issuecomment-1059494662
FWIW it looks like this is already the case:
```
# git grep -F ' api' solr/server/build.gradle
solr/server/build.gradle: api('io.dropwizard.metrics:metrics-core', {
risdenk edited a comment on pull request #726:
URL: https://github.com/apache/solr/pull/726#issuecomment-1059492225
Yea so there is a pattern for this already related to the Jetty jars:
https://github.com/apache/solr/blob/main/solr/core/build.gradle#L96
and
https://githu
risdenk edited a comment on pull request #726:
URL: https://github.com/apache/solr/pull/726#issuecomment-1059492225
Yea so there is a pattern for this already related to the Jetty jars:
https://github.com/apache/solr/blob/main/solr/core/build.gradle#L96
and
https://githu
risdenk edited a comment on pull request #726:
URL: https://github.com/apache/solr/pull/726#issuecomment-1059492225
Yea so there is a pattern for this already related to the Jetty jars:
https://github.com/apache/solr/blob/main/solr/core/build.gradle#L96
and
https://githu
risdenk commented on pull request #726:
URL: https://github.com/apache/solr/pull/726#issuecomment-1059492225
Yea so there is a pattern for this already related to the Jetty jars:
https://github.com/apache/solr/blob/main/solr/core/build.gradle#L96
and
https://github.com/a
cpoerschke commented on pull request #726:
URL: https://github.com/apache/solr/pull/726#issuecomment-1059487680
Yes, this removes four duplicate jars, counter-intuitive that that seems to
have a positive effect!
And I just tried it twice, adding `metrics-jetty9-4.1.5.jar` in
`WEB-IN
risdenk commented on pull request #726:
URL: https://github.com/apache/solr/pull/726#issuecomment-1059483277
Wait so this change REMOVED the metrics jars from
`server/solr-webapp/webapp/WEB-INF/lib/`?
Then what @dsmiley said on the jira that metrics jars needing to be in
`WEB-INF/li
cpoerschke commented on pull request #726:
URL: https://github.com/apache/solr/pull/726#issuecomment-1059479328
> So what I think is happening here is that because this was included as
`implementation` in `core/build.gradle` - gradle thought it was smart enough to
not copy it anymore to `W
Mike Drob created SOLR-16076:
Summary: Update smoke test for moved bin-test scripts
Key: SOLR-16076
URL: https://issues.apache.org/jira/browse/SOLR-16076
Project: Solr
Issue Type: Sub-task
risdenk commented on a change in pull request #726:
URL: https://github.com/apache/solr/pull/726#discussion_r819873777
##
File path: solr/core/build.gradle
##
@@ -139,12 +139,12 @@ dependencies {
implementation 'org.apache.logging.log4j:log4j-core'
implementation 'org.apa
[
https://issues.apache.org/jira/browse/SOLR-15993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501512#comment-17501512
]
ASF subversion and git services commented on SOLR-15993:
Commit c
risdenk edited a comment on pull request #726:
URL: https://github.com/apache/solr/pull/726#issuecomment-1059472447
So what I think is happening here is that because this was included as
`implementation` in `core/build.gradle` - gradle thought it was smart enough to
not copy it anymore to
risdenk commented on pull request #726:
URL: https://github.com/apache/solr/pull/726#issuecomment-1059472447
So what I think is happening here is that because this was included as
`implementation` in `core/build.gradle` - gradle thought it was smart enough to
not copy it anymore to `server
[
https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501515#comment-17501515
]
Kevin Risden commented on SOLR-16072:
-
{quote}I strongly suspect it's no longer in th
madrob commented on a change in pull request #619:
URL: https://github.com/apache/solr/pull/619#discussion_r819866750
##
File path: solr/bin/solr
##
@@ -99,14 +102,13 @@ elif [ -r "$SOLR_INCLUDE" ]; then
. "$SOLR_INCLUDE"
fi
-if [ -z "$SOLR_PID_DIR" ]; then
- SOLR_PID_DI
[
https://issues.apache.org/jira/browse/SOLR-15993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501514#comment-17501514
]
ASF subversion and git services commented on SOLR-15993:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-15993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501513#comment-17501513
]
ASF subversion and git services commented on SOLR-15993:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501508#comment-17501508
]
David Smiley commented on SOLR-16072:
-
I'm imagining a machine generated text file li
[
https://issues.apache.org/jira/browse/SOLR-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501505#comment-17501505
]
David Smiley commented on SOLR-15984:
-
This caused SOLR-16072; for those following he
[
https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501503#comment-17501503
]
David Smiley commented on SOLR-16072:
-
{quote}Does metrics-jetty9 need to be in WEB-I
[
https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501501#comment-17501501
]
Christine Poerschke commented on SOLR-16072:
Continuing with my earlier bisec
[
https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501501#comment-17501501
]
Christine Poerschke edited comment on SOLR-16072 at 3/4/22, 7:38 PM:
--
cpoerschke opened a new pull request #726:
URL: https://github.com/apache/solr/pull/726
https://issues.apache.org/jira/browse/SOLR-16072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
risdenk commented on pull request #682:
URL: https://github.com/apache/solr/pull/682#issuecomment-1059446682
This is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501485#comment-17501485
]
ASF subversion and git services commented on SOLR-14920:
Commit 5
[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501489#comment-17501489
]
Kevin Risden commented on SOLR-14920:
-
Core non test has been pushed to main and bran
[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501487#comment-17501487
]
Kevin Risden commented on SOLR-14920:
-
Thanks [~erickerickson] appreciate all the hel
[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501484#comment-17501484
]
ASF subversion and git services commented on SOLR-14920:
Commit 7
epugh merged pull request #714:
URL: https://github.com/apache/solr/pull/714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@so
[
https://issues.apache.org/jira/browse/SOLR-16039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501479#comment-17501479
]
Kevin Risden commented on SOLR-16039:
-
3.3.2 was released -
https://lists.apache.org
risdenk commented on pull request #682:
URL: https://github.com/apache/solr/pull/682#issuecomment-1059427338
3.3.2 was released -
https://lists.apache.org/thread/z521vnzqv7vdv4gtzszbt35lrbnrovty. I'll update
this PR shortly
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501466#comment-17501466
]
ASF subversion and git services commented on SOLR-14920:
Commit c
risdenk merged pull request #705:
URL: https://github.com/apache/solr/pull/705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501457#comment-17501457
]
ASF subversion and git services commented on SOLR-14920:
Commit 7
risdenk merged pull request #720:
URL: https://github.com/apache/solr/pull/720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
risdenk commented on pull request #705:
URL: https://github.com/apache/solr/pull/705#issuecomment-1059377874
Thanks @ErickErickson! Addressed your comments in
a60dd59f7ac4f58cdf73fbdbe225426806a6e3b8
--
This is an automated message from the Apache Git Service.
To respond to the message,
cpoerschke commented on a change in pull request #619:
URL: https://github.com/apache/solr/pull/619#discussion_r819749140
##
File path: solr/bin/solr
##
@@ -99,14 +102,13 @@ elif [ -r "$SOLR_INCLUDE" ]; then
. "$SOLR_INCLUDE"
fi
-if [ -z "$SOLR_PID_DIR" ]; then
- SOLR_PI
[
https://issues.apache.org/jira/browse/SOLR-16058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob deleted SOLR-16058:
-
> Hello world
> ---
>
> Key: SOLR-16058
> URL: https://issues.apache
[
https://issues.apache.org/jira/browse/SOLR-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated SOLR-12228:
-
Parent: SOLR-11749
Issue Type: Sub-task (was: Test)
> Integrate bin-test/test with Gradle
>
[
https://issues.apache.org/jira/browse/SOLR-12227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated SOLR-12227:
-
Parent: SOLR-11749
Issue Type: Sub-task (was: Test)
> Add bin-test/test coverage for bin/solr st
[
https://issues.apache.org/jira/browse/SOLR-12226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated SOLR-12226:
-
Parent: SOLR-11749
Issue Type: Sub-task (was: Test)
> Add bin-test/test coverage for bin/solr zk
[
https://issues.apache.org/jira/browse/SOLR-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated SOLR-12225:
-
Parent: SOLR-11749
Issue Type: Sub-task (was: Test)
> Add bin-test/test coverage for bin/solr au
[
https://issues.apache.org/jira/browse/SOLR-15993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated SOLR-15993:
-
Parent: SOLR-11749
Issue Type: Sub-task (was: Test)
> Migrate bin-test functionality to BATS
> -
[
https://issues.apache.org/jira/browse/SOLR-12137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated SOLR-12137:
-
Parent: SOLR-11749
Issue Type: Sub-task (was: Test)
> Create Windows-equivalent of bin-test/test
[
https://issues.apache.org/jira/browse/SOLR-15994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated SOLR-15994:
-
Parent: SOLR-11749
Issue Type: Sub-task (was: Test)
Security: (was: Public)
> bin-test
[
https://issues.apache.org/jira/browse/SOLR-16068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated SOLR-16068:
-
Parent: SOLR-11749
Issue Type: Sub-task (was: Test)
> GitHub action for integration tests
>
[
https://issues.apache.org/jira/browse/SOLR-15994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-15994.
--
Fix Version/s: 9.0
Assignee: Mike Drob
Resolution: Fixed
> bin-test tests broken after
[
https://issues.apache.org/jira/browse/SOLR-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob reassigned SOLR-12228:
Assignee: Mike Drob
> Integrate bin-test/test with Gradle
> ---
>
[
https://issues.apache.org/jira/browse/SOLR-15993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-15993.
--
Fix Version/s: 9.0
Resolution: Fixed
> Migrate bin-test functionality to BATS
>
[
https://issues.apache.org/jira/browse/SOLR-12228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-12228.
--
Fix Version/s: 9.0
Resolution: Fixed
> Integrate bin-test/test with Gradle
> ---
radu-gheorghe commented on pull request #714:
URL: https://github.com/apache/solr/pull/714#issuecomment-1059325821
Looks perfect to me. Thanks @epugh!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/SOLR-16075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501424#comment-17501424
]
ASF subversion and git services commented on SOLR-16075:
Commit 2
janhoy merged pull request #725:
URL: https://github.com/apache/solr/pull/725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
[
https://issues.apache.org/jira/browse/SOLR-16041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501420#comment-17501420
]
ASF subversion and git services commented on SOLR-16041:
Commit 3
janhoy merged pull request #694:
URL: https://github.com/apache/solr/pull/694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
[
https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501417#comment-17501417
]
Kevin Risden edited comment on SOLR-16072 at 3/4/22, 4:18 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501417#comment-17501417
]
Kevin Risden edited comment on SOLR-16072 at 3/4/22, 4:15 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501417#comment-17501417
]
Kevin Risden commented on SOLR-16072:
-
My only guess right now is that metrics-jetty9
[
https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501417#comment-17501417
]
Kevin Risden edited comment on SOLR-16072 at 3/4/22, 4:14 PM:
-
epugh commented on pull request #714:
URL: https://github.com/apache/solr/pull/714#issuecomment-1059298851
@radu-gheorghe what do you think of this edit I made? If you like it, I
can merge this, and if you don't, I can back it out!
--
This is an automated message from the Apache Git Se
[
https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501411#comment-17501411
]
Kevin Risden commented on SOLR-16072:
-
As far as I'm aware, SOLR-15984 didn't change
[
https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501407#comment-17501407
]
Kevin Risden commented on SOLR-16072:
-
Hmmm that is not good
{code:java}
commit
janhoy edited a comment on pull request #725:
URL: https://github.com/apache/solr/pull/725#issuecomment-1059259268
> I like seeing spotless failing on the code formatting ;-). Though, I think
the format that you had is a bit nicer to read then what Spotless wants, but
regardless, I love th
janhoy commented on pull request #725:
URL: https://github.com/apache/solr/pull/725#issuecomment-1059259268
> I like seeing spotless failing on the code formatting ;-). Though, I think
the format that you had is a bit nicer to read then what Spotless wants, but
regardless, I love that we w
[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501362#comment-17501362
]
Erick Erickson commented on SOLR-14920:
---
finished reviewing 705. The usual nits, bu
ErickErickson commented on a change in pull request #705:
URL: https://github.com/apache/solr/pull/705#discussion_r819190237
##
File path: solr/core/src/java/org/apache/solr/uninverting/DocTermOrds.java
##
@@ -198,104 +189,113 @@ public long ramBytesUsed() {
public DocTermOr
epugh commented on pull request #725:
URL: https://github.com/apache/solr/pull/725#issuecomment-1059176249
I like seeing spotless failing on the code formatting ;-).Though, I
think the format that you had is a bit nicer to read then what Spotless wants,
but regardless, I love that we w
[
https://issues.apache.org/jira/browse/SOLR-16072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501332#comment-17501332
]
Christine Poerschke commented on SOLR-16072:
Based on
{code:java}
curl "http:
1 - 100 of 102 matches
Mail list logo
