risdenk commented on a change in pull request #726: URL: https://github.com/apache/solr/pull/726#discussion_r819873777
########## File path: solr/core/build.gradle ########## @@ -139,12 +139,12 @@ dependencies { implementation 'org.apache.logging.log4j:log4j-core' implementation 'org.apache.logging.log4j:log4j-slf4j-impl' - implementation 'io.dropwizard.metrics:metrics-core' - implementation ('io.dropwizard.metrics:metrics-graphite', { + compileOnlyApi 'io.dropwizard.metrics:metrics-core' Review comment: Probably worth a comment about these saying why and that it is referenced in `solr/server/build.grade`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org