cpoerschke commented on pull request #726: URL: https://github.com/apache/solr/pull/726#issuecomment-1059479328
> So what I think is happening here is that because this was included as `implementation` in `core/build.gradle` - gradle thought it was smart enough to not copy it anymore to `WEB-INF/lib` even though it was referenced in `server/build.gradle`. > > If that is the case, then any dependency defined in `server/build.gradle` should be cross checked against `core/build.gradle` and a similar change made? When you say "to not copy it anymore", what is the "it" there? I'm guessing `metrics-jetty9-4.1.5.jar`, is that right? Comparing the jars before and after the change, this is the difference: ``` < ./server/solr-webapp/webapp/WEB-INF/lib/metrics-core-4.1.5.jar < ./server/solr-webapp/webapp/WEB-INF/lib/metrics-graphite-4.1.5.jar < ./server/solr-webapp/webapp/WEB-INF/lib/metrics-jmx-4.1.5.jar < ./server/solr-webapp/webapp/WEB-INF/lib/metrics-jvm-4.1.5.jar ``` i.e. those four were duplicated between WEB-INF and server but `metrics-jetty9-4.1.5.jar` was not duplicated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
