[GitHub] [solr] suryakant261 commented on pull request #58: SOLR-15315 |LTR latency optimisation by changing recursion to loop

2021-05-07 Thread GitBox
suryakant261 commented on pull request #58: URL: https://github.com/apache/solr/pull/58#issuecomment-834810477 > > removing recursive calls kinda defeats the meaning of having the RegressionNode to have the score method, potentially only the root needs that, anyway it just a consideration,

[GitHub] [solr] suryakant261 commented on pull request #58: SOLR-15315 |LTR latency optimisation by changing recursion to loop

2021-05-07 Thread GitBox
suryakant261 commented on pull request #58: URL: https://github.com/apache/solr/pull/58#issuecomment-834808404 Hi @alessandrobenedetti and @cpoerschke Really thanks for reviewing this. Have added an entry in CHANGES.txt and made the same recursion to loop changes for explain and v

[jira] [Resolved] (SOLR-15377) Do not swallow exceptions thrown in replication

2021-05-07 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-15377. Fix Version/s: 8.9 main (9.0) Assignee: Christine Poersc

[jira] [Commented] (SOLR-15377) Do not swallow exceptions thrown in replication

2021-05-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341010#comment-17341010 ] ASF subversion and git services commented on SOLR-15377: Commit e

[jira] [Commented] (SOLR-15089) Allow backup/restoration to Amazon's S3 blobstore

2021-05-07 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340988#comment-17340988 ] Anshum Gupta commented on SOLR-15089: - [~pierre.salagnac] - thanks for the update!

[jira] [Commented] (SOLR-15377) Do not swallow exceptions thrown in replication

2021-05-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340968#comment-17340968 ] ASF subversion and git services commented on SOLR-15377: Commit 4

[GitHub] [solr] cpoerschke merged pull request #99: [SOLR-15377] Do not swallow execption stack traces in IndexFetcher

2021-05-07 Thread GitBox
cpoerschke merged pull request #99: URL: https://github.com/apache/solr/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [solr] cpoerschke commented on pull request #99: [SOLR-15377] Do not swallow execption stack traces in IndexFetcher

2021-05-07 Thread GitBox
cpoerschke commented on pull request #99: URL: https://github.com/apache/solr/pull/99#issuecomment-834651393 > Unfortunately this PR originated from an organizational fork and not from a personal repo, so I cannot enable access for maintainers ([bug in Github](https://github.com/isaacs/git

[jira] [Commented] (SOLR-12697) pure DocValues support for FieldValueFeature

2021-05-07 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340964#comment-17340964 ] Christine Poerschke commented on SOLR-12697: Perhaps a next step here could b

[jira] [Commented] (SOLR-12697) pure DocValues support for FieldValueFeature

2021-05-07 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340963#comment-17340963 ] Christine Poerschke commented on SOLR-12697: {quote} {code:java} public class

[jira] [Commented] (SOLR-12697) pure DocValues support for FieldValueFeature

2021-05-07 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340960#comment-17340960 ] Christine Poerschke commented on SOLR-12697: Hi Everyone. So from briefly re

[jira] [Updated] (SOLR-15277) Schema Designer in Admin UI

2021-05-07 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-15277: -- Description: Augment Solr’s schema-guessing (aka “schemaless”) mode with a new interactive Sch

[jira] [Updated] (SOLR-15277) Schema Designer in Admin UI

2021-05-07 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-15277: -- Attachment: schema-designer-7.png > Schema Designer in Admin UI > --- >

[GitHub] [solr] madrob commented on pull request #112: SOLR-11904: Mark ReplicationHandler's polling thread as a Solr server thread so the PKI Interceptor is activated to allow PULL replicas to replic

2021-05-07 Thread GitBox
madrob commented on pull request #112: URL: https://github.com/apache/solr/pull/112#issuecomment-834595463 Did you use anything from Torsten Bøgh Köster repro case on #100 ? If so, please include him credited in the CHANGES. -- This is an automated message from the Apache Git Service. To

[GitHub] [solr] madrob commented on a change in pull request #112: SOLR-11904: Mark ReplicationHandler's polling thread as a Solr server thread so the PKI Interceptor is activated to allow PULL replic

2021-05-07 Thread GitBox
madrob commented on a change in pull request #112: URL: https://github.com/apache/solr/pull/112#discussion_r628351285 ## File path: solr/core/src/test/org/apache/solr/cloud/TestPullReplica.java ## @@ -528,31 +511,38 @@ private void waitForNumDocsInAllActiveReplicas(int numDocs

[GitHub] [solr] tboeghk closed pull request #100: [SOLR-11904] Provide basic auth credentials for TLOG/PULL replica ensembles

2021-05-07 Thread GitBox
tboeghk closed pull request #100: URL: https://github.com/apache/solr/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please cont

[GitHub] [solr] tboeghk commented on pull request #100: [SOLR-11904] Provide basic auth credentials for TLOG/PULL replica ensembles

2021-05-07 Thread GitBox
tboeghk commented on pull request #100: URL: https://github.com/apache/solr/pull/100#issuecomment-834573185 I close this PR in favor of #112. That is the correct and best solution for the problem. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [solr] tboeghk commented on pull request #99: [SOLR-15377] Do not swallow execption stack traces in IndexFetcher

2021-05-07 Thread GitBox
tboeghk commented on pull request #99: URL: https://github.com/apache/solr/pull/99#issuecomment-834569517 Unfortunately this PR originated from an organizational fork and not from a personal repo, so I cannot enable access for maintainers ([bug in Github](https://github.com/isaacs/github/

[GitHub] [solr] thelabdude commented on pull request #100: [SOLR-11904] Provide basic auth credentials for TLOG/PULL replica ensembles

2021-05-07 Thread GitBox
thelabdude commented on pull request #100: URL: https://github.com/apache/solr/pull/100#issuecomment-834564691 The correct solution for this issue is in this PR: https://github.com/apache/solr/pull/112. Let's not merge this one please. -- This is an automated message from the Apache Git

[GitHub] [solr] thelabdude commented on a change in pull request #112: SOLR-11904: Mark ReplicationHandler's polling thread as a Solr server thread so the PKI Interceptor is activated to allow PULL re

2021-05-07 Thread GitBox
thelabdude commented on a change in pull request #112: URL: https://github.com/apache/solr/pull/112#discussion_r628330395 ## File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java ## @@ -1208,6 +1208,7 @@ private void setupPolling(String intervalStr) {

[GitHub] [solr-operator] HoustonPutman opened a new pull request #269: Various fixes for the release wizard and accompanying scripts.

2021-05-07 Thread GitBox
HoustonPutman opened a new pull request #269: URL: https://github.com/apache/solr-operator/pull/269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Updated] (SOLR-15324) High security vulnerability in Apache Thrift - CVE-2020-13949 (+1) bundled within Solr

2021-05-07 Thread WCM RnD (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WCM RnD updated SOLR-15324: --- Description: Latest Version of Solr 8.8.1 bundles Apache v0.13.0. Thrift jar that has the following vulnerab

[GitHub] [solr-operator] HoustonPutman merged pull request #265: Implement support for hostpath solr data volumes.

2021-05-07 Thread GitBox
HoustonPutman merged pull request #265: URL: https://github.com/apache/solr-operator/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servi

[GitHub] [solr-operator] HoustonPutman closed issue #266: Allow use of hostPath for ephemeral solr data storage.

2021-05-07 Thread GitBox
HoustonPutman closed issue #266: URL: https://github.com/apache/solr-operator/issues/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [solr] cpoerschke commented on pull request #99: [SOLR-15377] Do not swallow execption stack traces in IndexFetcher

2021-05-07 Thread GitBox
cpoerschke commented on pull request #99: URL: https://github.com/apache/solr/pull/99#issuecomment-834494687 Hmm, I just tried to merge in the latest `origin/main` and add the `solr/CHANGES.txt` entry before merging here but then github wouldn't let me push the commits to the pull request

[GitHub] [solr] madrob commented on a change in pull request #117: SOLR-15389: Create JUnit QueryMatchers

2021-05-07 Thread GitBox
madrob commented on a change in pull request #117: URL: https://github.com/apache/solr/pull/117#discussion_r628272287 ## File path: solr/core/src/test/org/apache/solr/hamcrest/QueryMatchers.java ## @@ -0,0 +1,184 @@ +package org.apache.solr.hamcrest; + +import org.apache.lucene

[jira] [Resolved] (SOLR-15398) Faceting page in ref guide doesn't mention the json.nl parameter.

2021-05-07 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh resolved SOLR-15398. Fix Version/s: main (9.0) Resolution: Fixed > Faceting page in ref guide doesn't men

[GitHub] [solr] epugh merged pull request #118: SOLR-15398: Faceting page in ref guide doesn't mention the json.nl parameter

2021-05-07 Thread GitBox
epugh merged pull request #118: URL: https://github.com/apache/solr/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contac

[GitHub] [solr] epugh commented on pull request #118: SOLR-15398: Faceting page in ref guide doesn't mention the json.nl parameter

2021-05-07 Thread GitBox
epugh commented on pull request #118: URL: https://github.com/apache/solr/pull/118#issuecomment-834468730 Thanks! Going to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [solr] cpoerschke commented on a change in pull request #99: [SOLR-15377] Do not swallow execption stack traces in IndexFetcher

2021-05-07 Thread GitBox
cpoerschke commented on a change in pull request #99: URL: https://github.com/apache/solr/pull/99#discussion_r628262149 ## File path: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java ## @@ -677,12 +677,12 @@ IndexFetchResult fetchLatestIndex(boolean forceReplicatio

[GitHub] [solr] madrob commented on pull request #117: SOLR-15389: Create JUnit QueryMatchers

2021-05-07 Thread GitBox
madrob commented on pull request #117: URL: https://github.com/apache/solr/pull/117#issuecomment-834461633 > > QueryMatchers could probably go into Lucene, but we're separate projects now so c'est la vie > > Could it not go into the lucene test-framework jar? It probably does

[GitHub] [solr] madrob commented on a change in pull request #117: SOLR-15389: Create JUnit QueryMatchers

2021-05-07 Thread GitBox
madrob commented on a change in pull request #117: URL: https://github.com/apache/solr/pull/117#discussion_r628257660 ## File path: solr/core/src/test/org/apache/solr/search/TestExtendedDismaxParser.java ## @@ -45,6 +45,14 @@ import org.junit.BeforeClass; import org.junit.Te

[GitHub] [solr] madrob commented on a change in pull request #117: SOLR-15389

2021-05-07 Thread GitBox
madrob commented on a change in pull request #117: URL: https://github.com/apache/solr/pull/117#discussion_r628253601 ## File path: solr/core/src/test/org/apache/solr/hamcrest/QueryMatchers.java ## @@ -0,0 +1,184 @@ +package org.apache.solr.hamcrest; + +import org.apache.lucene

[GitHub] [solr] cpoerschke commented on a change in pull request #112: SOLR-11904: Mark ReplicationHandler's polling thread as a Solr server thread so the PKI Interceptor is activated to allow PULL re

2021-05-07 Thread GitBox
cpoerschke commented on a change in pull request #112: URL: https://github.com/apache/solr/pull/112#discussion_r628251956 ## File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java ## @@ -1208,6 +1208,7 @@ private void setupPolling(String intervalStr) {

[jira] [Commented] (SOLR-12697) pure DocValues support for FieldValueFeature

2021-05-07 Thread Tom Gilke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340860#comment-17340860 ] Tom Gilke commented on SOLR-12697: -- Hello, Tobi and I used the following approach to ta

[jira] [Updated] (SOLR-15338) High security vulnerability in Jetty library CVE-2021-28163 (+5) bundled within Solr

2021-05-07 Thread WCM RnD (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WCM RnD updated SOLR-15338: --- Description: High security vulnerability ahs been reported in the Jetty jar bundled within Solr:       h2

[jira] [Updated] (SOLR-15324) High security vulnerability in Apache Thrift - CVE-2020-13949 (+1) bundled within Solr

2021-05-07 Thread WCM RnD (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WCM RnD updated SOLR-15324: --- Description: Latest Version of Solr 8.8.1 bundles Apache v0.13.0. Thrift jar that has the following vulnerab

[jira] [Updated] (SOLR-15325) High security vulnerability in Jetty library bundled within Solr - CVE-2020-27223 (+1)

2021-05-07 Thread WCM RnD (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WCM RnD updated SOLR-15325: --- Description: High security vulnerability ahs been reported in the Jetty jar bundled within Solr: *Jetty: Ja

[jira] [Updated] (SOLR-15325) High security vulnerability in Jetty library bundled within Solr - CVE-2020-27223 (+1)

2021-05-07 Thread WCM RnD (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WCM RnD updated SOLR-15325: --- Description: High security vulnerability ahs been reported in the Jetty jar bundled within Solr: *Jetty: Ja

[jira] [Updated] (SOLR-15325) High security vulnerability in Jetty library bundled within Solr - CVE-2020-27223 (+1)

2021-05-07 Thread WCM RnD (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WCM RnD updated SOLR-15325: --- Description: High security vulnerability ahs been reported in the Jetty jar bundled within Solr: *Jetty: Ja

[jira] [Updated] (SOLR-15324) High security vulnerability in Apache Thrift - CVE-2020-13949 (+1) bundled within Solr

2021-05-07 Thread WCM RnD (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WCM RnD updated SOLR-15324: --- Description: Latest Version of Solr 8.8.1 bundles Apache v0.13.0. Thrift jar that has the following vulnerab

[GitHub] [solr-site] thelabdude edited a comment on pull request #24: Add content for exploring the features of the v0.3.0 operator on GKE

2021-05-07 Thread GitBox
thelabdude edited a comment on pull request #24: URL: https://github.com/apache/solr-site/pull/24#issuecomment-834391223 The cert-manager defines the `acme-letsencrypt-issuer-pk` secret, here's a good explanation from one of cert-manager's main contributors: https://github.com/jetstack/cer

[GitHub] [solr-operator] thelabdude opened a new issue #268: Allow specifying the name of a TLS secret for the Ingress to support TLS termination at the Ingress

2021-05-07 Thread GitBox
thelabdude opened a new issue #268: URL: https://github.com/apache/solr-operator/issues/268 Currently, the operator doesn't support TLS termination at the Ingress. Users can configure TLS all the way through from Ingress to Solr pods and between them. This would be an easy enhancement, but

[GitHub] [solr-site] thelabdude commented on pull request #24: Add content for exploring the features of the v0.3.0 operator on GKE

2021-05-07 Thread GitBox
thelabdude commented on pull request #24: URL: https://github.com/apache/solr-site/pull/24#issuecomment-834391223 The cert-manager defines the `acme-letsencrypt-issuer-pk` secret, here's a good explanation from one of cert-manager's main contributors: https://github.com/jetstack/cert-manag

[jira] [Commented] (SOLR-15089) Allow backup/restoration to Amazon's S3 blobstore

2021-05-07 Thread Pierre Salagnac (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340821#comment-17340821 ] Pierre Salagnac commented on SOLR-15089: Hi [~gerlowskija]! I'm working with [~a

[GitHub] [solr] cpoerschke commented on pull request #58: SOLR-15315 |LTR latency optimisation by changing recursion to loop

2021-05-07 Thread GitBox
cpoerschke commented on pull request #58: URL: https://github.com/apache/solr/pull/58#issuecomment-834365032 > removing recursive calls kinda defeats the meaning of having the RegressionNode to have the score method, potentially only the root needs that, anyway it just a consideration, ..

[GitHub] [solr] cpoerschke commented on pull request #58: SOLR-15315 |LTR latency optimisation by changing recursion to loop

2021-05-07 Thread GitBox
cpoerschke commented on pull request #58: URL: https://github.com/apache/solr/pull/58#issuecomment-834342508 Sorry, I'd put this on my TODO list for this week but didn't say so here, only on the JIRA ticket. Thanks @alessandrobenedetti for also taking a look! I agree it makes

[GitHub] [solr] alessandrobenedetti commented on a change in pull request #58: SOLR-15315 |LTR latency optimisation by changing recursion to loop

2021-05-07 Thread GitBox
alessandrobenedetti commented on a change in pull request #58: URL: https://github.com/apache/solr/pull/58#discussion_r628159012 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/model/MultipleAdditiveTreesModel.java ## @@ -170,19 +170,21 @@ public boolean isLeaf() {

[GitHub] [solr] romseygeek commented on a change in pull request #117: SOLR-15389

2021-05-07 Thread GitBox
romseygeek commented on a change in pull request #117: URL: https://github.com/apache/solr/pull/117#discussion_r628089732 ## File path: solr/core/src/test/org/apache/solr/hamcrest/QueryMatchers.java ## @@ -0,0 +1,184 @@ +package org.apache.solr.hamcrest; + +import org.apache.lu

[GitHub] [solr] romseygeek commented on pull request #117: SOLR-15389

2021-05-07 Thread GitBox
romseygeek commented on pull request #117: URL: https://github.com/apache/solr/pull/117#issuecomment-834233906 > QueryMatchers could probably go into Lucene, but we're separate projects now so c'est la vie Could it not go into the lucene test-framework jar? -- This is an automated

[jira] [Comment Edited] (SOLR-15397) Expose zookeeper status in the exporter

2021-05-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340697#comment-17340697 ] Jan Høydahl edited comment on SOLR-15397 at 5/7/21, 9:44 AM: -

[jira] [Commented] (SOLR-15397) Expose zookeeper status in the exporter

2021-05-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340697#comment-17340697 ] Jan Høydahl commented on SOLR-15397: Just committed a fix to the PR branch, that make

[jira] [Comment Edited] (SOLR-12697) pure DocValues support for FieldValueFeature

2021-05-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340684#comment-17340684 ] Tobias Kässmann edited comment on SOLR-12697 at 5/7/21, 9:04 AM: --

[jira] [Commented] (SOLR-12697) pure DocValues support for FieldValueFeature

2021-05-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340684#comment-17340684 ] Tobias Kässmann commented on SOLR-12697: Hello [~erickerickson] and [~slivotov],

[GitHub] [solr-site] janhoy commented on pull request #24: Add content for exploring the features of the v0.3.0 operator on GKE

2021-05-07 Thread GitBox
janhoy commented on pull request #24: URL: https://github.com/apache/solr-site/pull/24#issuecomment-834147738 This was a bit of a mouthful :) Skimmed it and it looks thorough, but did not have time to read it all just now. A few initial questions: 1. ``` spec: acme:

[jira] [Commented] (SOLR-15397) Expose zookeeper status in the exporter

2021-05-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340637#comment-17340637 ] Jan Høydahl commented on SOLR-15397: While testing I discover that with a 3 node ZK e