thelabdude commented on a change in pull request #112:
URL: https://github.com/apache/solr/pull/112#discussion_r628330395
##########
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##########
@@ -1208,6 +1208,7 @@ private void setupPolling(String intervalStr) {
log.info("Poll disabled");
return;
}
+ ExecutorUtil.setServerThreadFlag(true); // so PKI auth works
Review comment:
I don't think it's needed to unset this `ThreadLocal` given it's a
single thread running in a dedicated scheduled executor, so the thread is not
shared for other purposes. It doesn't hurt to unset either if we think that
makes the code easier to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
