suryakant261 commented on pull request #58: URL: https://github.com/apache/solr/pull/58#issuecomment-834810477
> > removing recursive calls kinda defeats the meaning of having the RegressionNode to have the score method, potentially only the root needs that, anyway it just a consideration, ... > > And not having the method would also remove the potential for implementation mishaps such as `threshold` i.e. `this.threshold` being used instead of `regressionTreeNode.threshold` in the loop, or for code readers to need to consider that those three possibilities exist. Added a commit to try this out, feel free to revert or adapt. What do you think? Makes sense to keep like this to avoid errors coming because of this. vs regressionTreeNode. Followed the same approach in validate and explain methods -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
