cpoerschke commented on a change in pull request #112:
URL: https://github.com/apache/solr/pull/112#discussion_r628251956
##########
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##########
@@ -1208,6 +1208,7 @@ private void setupPolling(String intervalStr) {
log.info("Poll disabled");
return;
}
+ ExecutorUtil.setServerThreadFlag(true); // so PKI auth works
Review comment:
The existing two `ExecutorUtil.setServerThreadFlag(true/BOOLEAN.true)`
calls have a matching `setServerThreadFlag(false/null)` afterwards. Any
thoughts on having the same here? Perhaps it's not necessary but having it even
then (or a comment about why it's not necessary to unset) would help with code
reading?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
