[jira] [Created] (FLINK-36818) Securing credentials in SQL connectors

2024-11-28 Thread Kunal Rohitas (Jira)
Kunal Rohitas created FLINK-36818: - Summary: Securing credentials in SQL connectors Key: FLINK-36818 URL: https://issues.apache.org/jira/browse/FLINK-36818 Project: Flink Issue Type: Improvem

[jira] [Created] (FLINK-36819) [state/forst] Support link() in ForStFlinkFileSystem

2024-11-28 Thread Yanfei Lei (Jira)
Yanfei Lei created FLINK-36819: -- Summary: [state/forst] Support link() in ForStFlinkFileSystem Key: FLINK-36819 URL: https://issues.apache.org/jira/browse/FLINK-36819 Project: Flink Issue Type:

Re: [PR] [FLINK-33265] Support source parallelism setting for Kafka connector [flink-connector-kafka]

2024-11-28 Thread via GitHub
RocMarshal commented on code in PR #134: URL: https://github.com/apache/flink-connector-kafka/pull/134#discussion_r1863022748 ## docs/content.zh/docs/connectors/table/upsert-kafka.md: ## @@ -180,6 +180,14 @@ of all available metadata fields. + +

Re: [PR] [FLINK-33265] Support source parallelism setting for Kafka connector [flink-connector-kafka]

2024-11-28 Thread via GitHub
RocMarshal commented on code in PR #134: URL: https://github.com/apache/flink-connector-kafka/pull/134#discussion_r1863022594 ## docs/content.zh/docs/connectors/table/kafka.md: ## @@ -342,6 +342,14 @@ CREATE TABLE KafkaTable ( Duration Consumer 定期探测动态创建的 Kafka top

Re: [PR] [FLINK-36809][table] Support ignoreIfExists param for createTable [flink]

2024-11-28 Thread via GitHub
gustavodemorais commented on code in PR #25704: URL: https://github.com/apache/flink/pull/25704#discussion_r1861756363 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java: ## @@ -745,6 +745,35 @@ void createTemporarySystemFunction(

Re: [PR] [FLINK-36578][MySQL] Added modified JsonStringFormatter and option use.legacy.json.format [flink-cdc]

2024-11-28 Thread via GitHub
SML0127 commented on code in PR #3658: URL: https://github.com/apache/flink-cdc/pull/3658#discussion_r1861728840 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/resources/ddl/column_type_test_mysql8.sql: ## Review Comment: it was my mista

[PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
twalthr opened a new pull request, #25707: URL: https://github.com/apache/flink/pull/25707 ## What is the purpose of the change Adds the initial interfaces of `ProcessTableFunction` and `StateHint` mentioned in FLIP-440 to the code base. This is a requirement to continue with the `Ty

[jira] [Updated] (FLINK-36705) Add ProcessTableFunction class and annotations

2024-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36705: --- Labels: pull-request-available (was: ) > Add ProcessTableFunction class and annotations > -

[jira] [Closed] (FLINK-36801) Update CI image to Ubuntu 22.04

2024-11-28 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-36801. Resolution: Duplicate > Update CI image to Ubuntu 22.04 > ---

[jira] [Assigned] (FLINK-34194) Upgrade Flink CI Docker container to Ubuntu 22.04

2024-11-28 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-34194: Assignee: Chesnay Schepler (was: Matthias Pohl) > Upgrade Flink CI Docker contai

[jira] [Created] (FLINK-36817) Give users ability to provide their own KafkaConsumer when using flink-connector-kafka

2024-11-28 Thread Levani Kokhreidze (Jira)
Levani Kokhreidze created FLINK-36817: - Summary: Give users ability to provide their own KafkaConsumer when using flink-connector-kafka Key: FLINK-36817 URL: https://issues.apache.org/jira/browse/FLINK-36817

Re: [PR] FLINK-36817: Introduce KafkaConsumerFactory [flink-connector-kafka]

2024-11-28 Thread via GitHub
boring-cyborg[bot] commented on PR #137: URL: https://github.com/apache/flink-connector-kafka/pull/137#issuecomment-2505689926 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[jira] [Updated] (FLINK-36817) Give users ability to provide their own KafkaConsumer when using flink-connector-kafka

2024-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36817: --- Labels: pull-request-available (was: ) > Give users ability to provide their own KafkaConsu

Re: [PR] [FLINK-36817] Introduce KafkaConsumerFactory [flink-connector-kafka]

2024-11-28 Thread via GitHub
lkokhreidze commented on PR #137: URL: https://github.com/apache/flink-connector-kafka/pull/137#issuecomment-2505694480 Will add the javadocs. But first wanted to get the initial feedback if this makes sense. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-36817] Introduce KafkaConsumerFactory [flink-connector-kafka]

2024-11-28 Thread via GitHub
lkokhreidze commented on code in PR #137: URL: https://github.com/apache/flink-connector-kafka/pull/137#discussion_r1861855542 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaConsumerFactory.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
snuyanzin commented on code in PR #25707: URL: https://github.com/apache/flink/pull/25707#discussion_r1861852208 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/annotation/FunctionHint.java: ## @@ -175,13 +178,40 @@ ArgumentHint[] arguments() default

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
snuyanzin commented on code in PR #25707: URL: https://github.com/apache/flink/pull/25707#discussion_r1861853852 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/annotation/StateHint.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [FLINK-35136][docs] Bump HBase connector docs version to v4.0 [flink]

2024-11-28 Thread via GitHub
ferenc-csaky merged PR #25702: URL: https://github.com/apache/flink/pull/25702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2024-11-28 Thread via GitHub
snuyanzin commented on code in PR #25708: URL: https://github.com/apache/flink/pull/25708#discussion_r1861953820 ## azure-pipelines.yml: ## @@ -73,16 +73,16 @@ stages: parameters: # see template file for a definition of the parameters. stage_name: ci_build

[PR] [FLINK-36643][filesystems] Backport: Update aws-java-sdk-core to 1.12.779 to fix CVE [flink]

2024-11-28 Thread via GitHub
tomncooper opened a new pull request, #25709: URL: https://github.com/apache/flink/pull/25709 ## What is the purpose of the change This is backport of #25600. The current version of `aws-java-sdk-core`, used in the `flink-s3-fs-base` module, has a high severity vulnerability

Re: [PR] [FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25708: URL: https://github.com/apache/flink/pull/25708#discussion_r1862049614 ## azure-pipelines.yml: ## @@ -73,16 +73,16 @@ stages: parameters: # see template file for a definition of the parameters. stage_name: ci_build

Re: [PR] [hotfix][javadocs] Remove duplicated word 'the' in Javadocs [flink]

2024-11-28 Thread via GitHub
naferx commented on PR #24829: URL: https://github.com/apache/flink/pull/24829#issuecomment-2505902456 @snuyanzin just rebased this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-36643][filesystems] Backport: Update aws-java-sdk-core to 1.12.779 [flink]

2024-11-28 Thread via GitHub
flinkbot commented on PR #25709: URL: https://github.com/apache/flink/pull/25709#issuecomment-2505933359 ## CI report: * f04105fca97ddc88b5e4359b428ec5a8455bdfdf UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25707: URL: https://github.com/apache/flink/pull/25707#discussion_r1862058735 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/annotation/FunctionHint.java: ## @@ -175,13 +178,40 @@ ArgumentHint[] arguments() default

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25707: URL: https://github.com/apache/flink/pull/25707#discussion_r1862058735 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/annotation/FunctionHint.java: ## @@ -175,13 +178,40 @@ ArgumentHint[] arguments() default

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25707: URL: https://github.com/apache/flink/pull/25707#discussion_r1862058735 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/annotation/FunctionHint.java: ## @@ -175,13 +178,40 @@ ArgumentHint[] arguments() default

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25707: URL: https://github.com/apache/flink/pull/25707#discussion_r1862076676 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/ProcessTableFunction.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] [FLINK-36578][MySQL] Added modified JsonStringFormatter and option use.legacy.json.format [flink-cdc]

2024-11-28 Thread via GitHub
SML0127 commented on code in PR #3658: URL: https://github.com/apache/flink-cdc/pull/3658#discussion_r1861766911 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/table/MySqlTableSourceFactory.java: ##

Re: [PR] [FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2024-11-28 Thread via GitHub
flinkbot commented on PR #25708: URL: https://github.com/apache/flink/pull/25708#issuecomment-2505643498 ## CI report: * 3a9c69c677f25a4be5a3168d830e3ced77ff4369 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]

2024-11-28 Thread via GitHub
mehdid93 commented on PR #25670: URL: https://github.com/apache/flink/pull/25670#issuecomment-2505664022 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-36816) Support source parallelism setting for JDBC connector

2024-11-28 Thread Jira
Grzegorz Kołakowski created FLINK-36816: --- Summary: Support source parallelism setting for JDBC connector Key: FLINK-36816 URL: https://issues.apache.org/jira/browse/FLINK-36816 Project: Flink

Re: [PR] [FLINK-36578][MySQL] Added modified JsonStringFormatter and option use.legacy.json.format [flink-cdc]

2024-11-28 Thread via GitHub
SML0127 commented on code in PR #3658: URL: https://github.com/apache/flink-cdc/pull/3658#discussion_r1861726630 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlFullTypesITCase.java: ##

[jira] [Commented] (FLINK-28897) Fail to use udf in added jar when enabling checkpoint

2024-11-28 Thread Ammu Parvathy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901640#comment-17901640 ] Ammu Parvathy commented on FLINK-28897: --- [~Jiangang] [~lsy] I have raised a PR [h

Re: [PR] [FLINK-36809][table] Support ignoreIfExists param for createTable [flink]

2024-11-28 Thread via GitHub
gustavodemorais commented on code in PR #25704: URL: https://github.com/apache/flink/pull/25704#discussion_r1861751435 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/api/TableEnvironmentTest.java: ## @@ -100,6 +101,55 @@ void testCreateTableFromDescript

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
flinkbot commented on PR #25707: URL: https://github.com/apache/flink/pull/25707#issuecomment-2505633651 ## CI report: * e8c2ec88bf59239f3c40a88d228905772eab9459 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-36816] Support source parallelism setting for JDBC connector [flink-connector-jdbc]

2024-11-28 Thread via GitHub
grzegorz8 opened a new pull request, #148: URL: https://github.com/apache/flink-connector-jdbc/pull/148 # Purpose of the change Add new option `scan.parallelism` support for JDBC connector. Part of [FLINK-33261](https://issues.apache.org/jira/browse/FLINK-33261) FLIP-367: Suppo

[jira] [Updated] (FLINK-36816) Support source parallelism setting for JDBC connector

2024-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36816: --- Labels: pull-request-available (was: ) > Support source parallelism setting for JDBC connec

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
dawidwys commented on code in PR #25707: URL: https://github.com/apache/flink/pull/25707#discussion_r1861980546 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/extraction/TypeInferenceExtractorTest.java: ## @@ -632,7 +633,9 @@ private static Stream f

Re: [PR] [FLINK-36535][autoscaler] Optimize the scale down logic based on historical parallelism to reduce the rescale frequency [flink-kubernetes-operator]

2024-11-28 Thread via GitHub
mxm commented on code in PR #920: URL: https://github.com/apache/flink-kubernetes-operator/pull/920#discussion_r1861986603 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ## @@ -181,15 +178,15 @@ private void updateRecommendedParallelism(

Re: [PR] [FLINK-36535][autoscaler] Optimize the scale down logic based on historical parallelism to reduce the rescale frequency [flink-kubernetes-operator]

2024-11-28 Thread via GitHub
mxm commented on code in PR #920: URL: https://github.com/apache/flink-kubernetes-operator/pull/920#discussion_r1861985148 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java: ## @@ -289,21 +274,26 @@ private ParallelismChange applyScaleDownInterv

Re: [PR] [FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2024-11-28 Thread via GitHub
zentol commented on code in PR #25708: URL: https://github.com/apache/flink/pull/25708#discussion_r1861989731 ## azure-pipelines.yml: ## @@ -73,16 +73,16 @@ stages: parameters: # see template file for a definition of the parameters. stage_name: ci_build

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25707: URL: https://github.com/apache/flink/pull/25707#discussion_r1862082959 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/annotation/FunctionHint.java: ## @@ -175,13 +178,40 @@ ArgumentHint[] arguments() default

[jira] [Updated] (FLINK-35114) Remove old Table API implementations, update Schema stack

2024-11-28 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Csaky updated FLINK-35114: - Summary: Remove old Table API implementations, update Schema stack (was: Remove old Table API i

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
twalthr commented on code in PR #25707: URL: https://github.com/apache/flink/pull/25707#discussion_r1862101386 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/ProcessTableFunction.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
twalthr commented on code in PR #25707: URL: https://github.com/apache/flink/pull/25707#discussion_r1862101386 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/ProcessTableFunction.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software

[PR] [FLINK-35114] Remove old Table API implementations, update Table API and Schema stack [flink-connector-kudu]

2024-11-28 Thread via GitHub
ferenc-csaky opened a new pull request, #3: URL: https://github.com/apache/flink-connector-kudu/pull/3 Main logical changes: - Removed old Table API source/sink/factory. - Moved the Dynamic implementations up from the `dymanic` package. - Updated the schema stack from `TableSchema` t

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
twalthr commented on code in PR #25707: URL: https://github.com/apache/flink/pull/25707#discussion_r1862114539 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/ProcessTableFunction.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (FLINK-35114) Remove old Table API implementations, update Schema stack

2024-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35114: --- Labels: pull-request-available (was: ) > Remove old Table API implementations, update Schem

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
twalthr commented on code in PR #25707: URL: https://github.com/apache/flink/pull/25707#discussion_r1862103659 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/annotation/FunctionHint.java: ## @@ -175,13 +178,40 @@ ArgumentHint[] arguments() default {}

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
twalthr commented on PR #25707: URL: https://github.com/apache/flink/pull/25707#issuecomment-2506035053 > ideally testing the behavior documented in the comments. This is a feature under development. The behavior in comments is not fully implemented yet. As can be seen in the umbrella

Re: [PR] [FLINK-36809][table] Support ignoreIfExists param for createTable [flink]

2024-11-28 Thread via GitHub
twalthr commented on code in PR #25704: URL: https://github.com/apache/flink/pull/25704#discussion_r1862089260 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java: ## @@ -718,6 +718,36 @@ void createTemporarySystemFunction( */

Re: [PR] [FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2024-11-28 Thread via GitHub
zentol commented on code in PR #25708: URL: https://github.com/apache/flink/pull/25708#discussion_r1862177938 ## azure-pipelines.yml: ## @@ -73,16 +73,16 @@ stages: parameters: # see template file for a definition of the parameters. stage_name: ci_build

Re: [PR] [FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2024-11-28 Thread via GitHub
zentol commented on code in PR #25708: URL: https://github.com/apache/flink/pull/25708#discussion_r1862177938 ## azure-pipelines.yml: ## @@ -73,16 +73,16 @@ stages: parameters: # see template file for a definition of the parameters. stage_name: ci_build

Re: [PR] [FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2024-11-28 Thread via GitHub
zentol commented on code in PR #25708: URL: https://github.com/apache/flink/pull/25708#discussion_r1862177938 ## azure-pipelines.yml: ## @@ -73,16 +73,16 @@ stages: parameters: # see template file for a definition of the parameters. stage_name: ci_build

Re: [PR] [FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2024-11-28 Thread via GitHub
zentol commented on code in PR #25708: URL: https://github.com/apache/flink/pull/25708#discussion_r1862185553 ## .github/workflows/template.flink-ci.yml: ## @@ -72,7 +72,7 @@ jobs: name: "Compile" runs-on: ubuntu-22.04 container: - image: mapohl/flink-ci:FLIN

Re: [PR] [FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2024-11-28 Thread via GitHub
zentol commented on code in PR #25708: URL: https://github.com/apache/flink/pull/25708#discussion_r1862177938 ## azure-pipelines.yml: ## @@ -73,16 +73,16 @@ stages: parameters: # see template file for a definition of the parameters. stage_name: ci_build

Re: [PR] [FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2024-11-28 Thread via GitHub
zentol commented on code in PR #25708: URL: https://github.com/apache/flink/pull/25708#discussion_r1862177938 ## azure-pipelines.yml: ## @@ -73,16 +73,16 @@ stages: parameters: # see template file for a definition of the parameters. stage_name: ci_build

Re: [PR] [FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2024-11-28 Thread via GitHub
snuyanzin commented on code in PR #25708: URL: https://github.com/apache/flink/pull/25708#discussion_r1862207540 ## .github/workflows/template.flink-ci.yml: ## @@ -72,7 +72,7 @@ jobs: name: "Compile" runs-on: ubuntu-22.04 container: - image: mapohl/flink-ci:F

Re: [PR] [FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2024-11-28 Thread via GitHub
snuyanzin commented on code in PR #25708: URL: https://github.com/apache/flink/pull/25708#discussion_r1862207540 ## .github/workflows/template.flink-ci.yml: ## @@ -72,7 +72,7 @@ jobs: name: "Compile" runs-on: ubuntu-22.04 container: - image: mapohl/flink-ci:F

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
twalthr commented on code in PR #25707: URL: https://github.com/apache/flink/pull/25707#discussion_r1862211415 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/annotation/FunctionHint.java: ## @@ -175,13 +178,40 @@ ArgumentHint[] arguments() default {}

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
twalthr commented on code in PR #25707: URL: https://github.com/apache/flink/pull/25707#discussion_r1862212335 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/annotation/StateHint.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2024-11-28 Thread via GitHub
snuyanzin commented on PR #25708: URL: https://github.com/apache/flink/pull/25708#issuecomment-2506147084 one minor comment which probably relates to image rather than this PR: since jdk8 support was dropped (https://github.com/apache/flink/pull/25406) it could be removed from image as well

Re: [PR] [FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2024-11-28 Thread via GitHub
zentol commented on PR #25708: URL: https://github.com/apache/flink/pull/25708#issuecomment-2506155540 So long as we maintain 1.x branches I'd suggest to keep java 8 in there so we are able to use the same CI image for all versions (in case the need arised to bump the CI image in the 1.x br

Re: [PR] [FLINK-36529] Allow Flink version configs to be set to greater than given version [flink-kubernetes-operator]

2024-11-28 Thread via GitHub
gyfora merged PR #918: URL: https://github.com/apache/flink-kubernetes-operator/pull/918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-36809][table] Support ignoreIfExists param for createTable [flink]

2024-11-28 Thread via GitHub
gustavodemorais commented on code in PR #25704: URL: https://github.com/apache/flink/pull/25704#discussion_r1862788331 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java: ## @@ -745,6 +745,35 @@ void createTemporarySystemFunction(

Re: [PR] [FLINK-36809][table] Support ignoreIfExists param for createTable [flink]

2024-11-28 Thread via GitHub
gustavodemorais commented on PR #25704: URL: https://github.com/apache/flink/pull/25704#issuecomment-2506886668 @twalthr @davidradl thanks for the reviews 👍 I think I've addressed all comments, take a look. Updating the python api was a bit tricky with the setup (curious to see if l

Re: [PR] [FLINK-36573][cdc-connector][mysql] Add table information of binlog offsets when checkpointing [flink-cdc]

2024-11-28 Thread via GitHub
herunkang2018 commented on PR #3656: URL: https://github.com/apache/flink-cdc/pull/3656#issuecomment-2506898687 @leonardBang @yuxiqian Would you like to review again since the CI is passed? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] [FLINK-34874][cdc-connector][mongodb] Support initial.snapshotting.pipeline related configs in table api [flink-cdc]

2024-11-28 Thread via GitHub
Jiabao-Sun commented on PR #3707: URL: https://github.com/apache/flink-cdc/pull/3707#issuecomment-2506910528 Thanks @herunkang2018 for this contribution. Hi @yuxiqian, could you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [fix][cdc-connector][oracle] Fix oracle server time zone option missing in table api. [flink-cdc]

2024-11-28 Thread via GitHub
LiuBodong closed pull request #2985: [fix][cdc-connector][oracle] Fix oracle server time zone option missing in table api. URL: https://github.com/apache/flink-cdc/pull/2985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-36698][pipeline-connector][elasticsearch] Elasticsearch pipeline sink support authentication [flink-cdc]

2024-11-28 Thread via GitHub
beryllw commented on PR #3728: URL: https://github.com/apache/flink-cdc/pull/3728#issuecomment-2506921020 @lvyanquan @proletarians cc, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-36809][table] Support ignoreIfExists param for createTable [flink]

2024-11-28 Thread via GitHub
gustavodemorais commented on code in PR #25704: URL: https://github.com/apache/flink/pull/25704#discussion_r1862771988 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java: ## @@ -718,6 +718,36 @@ void createTemporarySystemFunction(

Re: [PR] [FLINK-36809][table] Support ignoreIfExists param for createTable [flink]

2024-11-28 Thread via GitHub
gustavodemorais commented on code in PR #25704: URL: https://github.com/apache/flink/pull/25704#discussion_r1862772602 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java: ## @@ -718,6 +718,36 @@ void createTemporarySystemFunction(

Re: [PR] [FLINK-35444][pipeline-connector][paimon] Paimon Pipeline Connector support changing column names to lowercase for Hive metastore [flink-cdc]

2024-11-28 Thread via GitHub
github-actions[bot] commented on PR #3569: URL: https://github.com/apache/flink-cdc/pull/3569#issuecomment-2506867619 This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encou

Re: [PR] [FLINK-35444][pipeline-connector][paimon] Paimon Pipeline Connector support changing column names to lowercase for Hive metastore [flink-cdc]

2024-11-28 Thread via GitHub
github-actions[bot] closed pull request #3569: [FLINK-35444][pipeline-connector][paimon] Paimon Pipeline Connector support changing column names to lowercase for Hive metastore URL: https://github.com/apache/flink-cdc/pull/3569 -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-36809][table] Support ignoreIfExists param for createTable [flink]

2024-11-28 Thread via GitHub
gustavodemorais commented on code in PR #25704: URL: https://github.com/apache/flink/pull/25704#discussion_r1862775007 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java: ## @@ -718,6 +718,36 @@ void createTemporarySystemFunction(

Re: [PR] [FLINK-36809][table] Support ignoreIfExists param for createTable [flink]

2024-11-28 Thread via GitHub
gustavodemorais commented on code in PR #25704: URL: https://github.com/apache/flink/pull/25704#discussion_r1862779370 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/api/TableEnvironmentTest.java: ## @@ -49,55 +50,78 @@ class TableEnvironmentTest {

Re: [PR] [FLINK-36809][table] Support ignoreIfExists param for createTable [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25704: URL: https://github.com/apache/flink/pull/25704#discussion_r1862341867 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java: ## @@ -718,6 +718,36 @@ void createTemporarySystemFunction(

Re: [PR] [FLINK-33571][table] Override json-path version for Calcite 1.32 to deal with CVE [flink]

2024-11-28 Thread via GitHub
MartijnVisser commented on PR #25602: URL: https://github.com/apache/flink/pull/25602#issuecomment-2506290502 It looks like we've pivoted from the original intent of the Jira ticket (upgrade to Calcite 1.38). That means that we'll either have to create a new Jira ticket for what's done in t

[jira] [Updated] (FLINK-36602) Upgrade Calcite version to 1.38.0

2024-11-28 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-36602: --- Labels: (was: pull-request-available) > Upgrade Calcite version to 1.38.0 > --

Re: [PR] [FLINK-36809][table] Support ignoreIfExists param for createTable [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25704: URL: https://github.com/apache/flink/pull/25704#discussion_r1862333839 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java: ## @@ -718,6 +718,36 @@ void createTemporarySystemFunction(

Re: [PR] [FLINK-36800] Upgrade hadoop-aws to 3.3.6 [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25692: URL: https://github.com/apache/flink/pull/25692#discussion_r1862403736 ## flink-filesystems/pom.xml: ## @@ -34,7 +34,7 @@ under the License. pom - 3.3.4 + 3.3.6 Review Comment: There are

Re: [PR] [FLINK-36688][table-planner] Sort metadata keys when reusing source [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25681: URL: https://github.com/apache/flink/pull/25681#discussion_r1862411403 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuser.java: ## @@ -165,7 +166,7 @@ public List reuseDuplicatedScan(Lis

Re: [PR] [FLINK-36756][sql-gateway] Bump up the sql gateway rest version [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25705: URL: https://github.com/apache/flink/pull/25705#discussion_r1862326643 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/util/SqlGatewayRestAPIVersion.java: ## @@ -51,7 +51,10 @@ public enum SqlGatewayRes

Re: [PR] [FLINK-36809][table] Support ignoreIfExists param for createTable [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25704: URL: https://github.com/apache/flink/pull/25704#discussion_r1862384619 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java: ## @@ -718,6 +718,36 @@ void createTemporarySystemFunction(

Re: [PR] [hotfix][javadocs] Remove duplicated word 'the' in Javadocs [flink]

2024-11-28 Thread via GitHub
snuyanzin merged PR #24829: URL: https://github.com/apache/flink/pull/24829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [hotfix][javadocs] Remove duplicated word 'the' in Javadocs [flink]

2024-11-28 Thread via GitHub
snuyanzin commented on PR #24829: URL: https://github.com/apache/flink/pull/24829#issuecomment-2506518447 @naferx can you please also create backports for 1.19, 1.20? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Closed] (FLINK-36529) Support greater or equals logic for operator flink version default configs

2024-11-28 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-36529. -- Fix Version/s: kubernetes-operator-1.11.0 Resolution: Fixed merged to main 9bab0286dc152ba5dbf8

Re: [PR] [FLINK-36809][table] Support ignoreIfExists param for createTable [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25704: URL: https://github.com/apache/flink/pull/25704#discussion_r1862354231 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java: ## @@ -718,6 +718,36 @@ void createTemporarySystemFunction(

Re: [PR] [FLINK-36809][table] Support ignoreIfExists param for createTable [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25704: URL: https://github.com/apache/flink/pull/25704#discussion_r1862333839 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java: ## @@ -718,6 +718,36 @@ void createTemporarySystemFunction(

Re: [PR] [FLINK-36739] [WebFrontend] Update the NodeJS to v22.11.0 (LTS) [flink]

2024-11-28 Thread via GitHub
mehdid93 commented on PR #25670: URL: https://github.com/apache/flink/pull/25670#issuecomment-2506492367 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-28897] [TABLE-SQL] Fail to use udf in added jar when enabling checkpoint [flink]

2024-11-28 Thread via GitHub
ammu20-dev commented on code in PR #25656: URL: https://github.com/apache/flink/pull/25656#discussion_r1861721487 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java: ## @@ -1542,6 +1542,19 @@ void testUsingAddJa

Re: [PR] [FLINK-36578][MySQL] Added modified JsonStringFormatter and option use.legacy.json.format [flink-cdc]

2024-11-28 Thread via GitHub
SML0127 commented on code in PR #3658: URL: https://github.com/apache/flink-cdc/pull/3658#discussion_r1861726630 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlFullTypesITCase.java: ##

Re: [PR] [FLINK-36749][state/forst] Implement rescaling for ForStStateBackend [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25676: URL: https://github.com/apache/flink/pull/25676#discussion_r1862415650 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/v2/StateBackendTestV2Base.java: ## @@ -177,8 +182,8 @@ protected AsyncKeyedStateBackend restoreAsyncKe

Re: [PR] [FLINK-36451][runtime] Replaces LeaderElection#hasLeadership with LeaderElection#runAsLeader [flink]

2024-11-28 Thread via GitHub
XComp commented on code in PR #25679: URL: https://github.com/apache/flink/pull/25679#discussion_r1862280134 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java: ## @@ -1246,6 +1200,62 @@ private void testNonBlockingCall(

Re: [PR] [FLINK-36809][table] Support ignoreIfExists param for createTable [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25704: URL: https://github.com/apache/flink/pull/25704#discussion_r1862333839 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java: ## @@ -718,6 +718,36 @@ void createTemporarySystemFunction(

Re: [PR] [FLINK-36705] Add initial ProcessTableFunction class and annotations [flink]

2024-11-28 Thread via GitHub
twalthr commented on PR #25707: URL: https://github.com/apache/flink/pull/25707#issuecomment-2506316008 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36702][sql-gateway] Introduce ScripExecutor to run the script [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25700: URL: https://github.com/apache/flink/pull/25700#discussion_r1862393806 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/application/ScriptExecutor.java: ## @@ -0,0 +1,332 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-36809][table] Support ignoreIfExists param for createTable [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25704: URL: https://github.com/apache/flink/pull/25704#discussion_r1862391147 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/api/TableEnvironmentTest.java: ## @@ -49,55 +50,78 @@ class TableEnvironmentTest { @Test

Re: [PR] [hotfix][javadocs] Remove duplicated word 'the' in Javadocs [flink]

2024-11-28 Thread via GitHub
snuyanzin commented on PR #24829: URL: https://github.com/apache/flink/pull/24829#issuecomment-2506443102 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-28897] [TABLE-SQL] Fail to use udf in added jar when enabling checkpoint [flink]

2024-11-28 Thread via GitHub
davidradl commented on code in PR #25656: URL: https://github.com/apache/flink/pull/25656#discussion_r1862450447 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java: ## @@ -1542,6 +1542,19 @@ void testUsingAddJar

  1   2   >