mxm commented on code in PR #920:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/920#discussion_r1861986603
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java:
##########
@@ -181,15 +178,15 @@ private void updateRecommendedParallelism(
}
@VisibleForTesting
- static boolean allRequiredVerticesWithinUtilizationTarget(
+ static boolean allChangedVerticesWithinUtilizationTarget(
Map<JobVertexID, Map<ScalingMetric, EvaluatedScalingMetric>>
evaluatedMetrics,
- Set<JobVertexID> requiredVertices) {
- // All vertices' ParallelismChange is optional, rescaling will be
ignored.
- if (requiredVertices.isEmpty()) {
+ Set<JobVertexID> changedVertices) {
+ // No any vertex is changed.
+ if (changedVertices.isEmpty()) {
return true;
}
- for (JobVertexID vertex : requiredVertices) {
+ for (var vertex : changedVertices) {
Review Comment:
I generally avoid `var` because it makes the code harder to read without
type information, but that's just me. Moreover, I avoid refactoring existing
code to use var, because it adds noise to the diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
