davidradl commented on code in PR #25681:
URL: https://github.com/apache/flink/pull/25681#discussion_r1862411403
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuser.java:
##########
@@ -165,7 +166,7 @@ public List<RelNode> reuseDuplicatedScan(List<RelNode>
relNodes) {
}
int[][] allProjectFields = allProjectFieldSet.toArray(new
int[0][]);
- List<String> allMetaKeys = new ArrayList<>(allMetaKeySet);
+ List<String> allMetaKeys = sortMetadataKeys(allMetaKeySet,
pickTable.tableSource());
Review Comment:
NIT: method name could be `enforceMetadataKeyOrder` or
`copyMetadataKeyOrder`; sort implies there is a sort order like ascending.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
