XComp commented on code in PR #25679:
URL: https://github.com/apache/flink/pull/25679#discussion_r1862280134


##########
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java:
##########
@@ -1246,6 +1200,62 @@ private void testNonBlockingCall(
         testInstance.close();
     }
 
+    /**
+     * This test is used to verify FLINK-36451 where we observed concurrent 
nested locks being
+     * acquired from the {@link LeaderContender} and from the {@link 
DefaultLeaderElectionService}.
+     */
+    @Test
+    void testNestedDeadlockInLeadershipConfirmation() throws Exception {

Review Comment:
   That's the test that I added to verify the findings. I kept it in a separate 
commit to prove that the test runs into a deadlock before applying the changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to