twalthr commented on code in PR #25707:
URL: https://github.com/apache/flink/pull/25707#discussion_r1862103659


##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/annotation/FunctionHint.java:
##########
@@ -175,13 +178,40 @@
     ArgumentHint[] arguments() default {};
 
     /**
-     * Explicitly defines the intermediate result type that a function uses as 
accumulator.
+     * Explicitly defines the intermediate result type (i.e. state entry) that 
an aggregating
+     * function uses as its accumulator. The entry is managed by the framework 
(usually via Flink's
+     * managed state).

Review Comment:
   This is hard to say and might be too implementation specific. It varies from 
operator to operator. Sometimes its MemorySegments, sometimes its just Java 
heap.



##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/annotation/FunctionHint.java:
##########
@@ -175,13 +178,40 @@
     ArgumentHint[] arguments() default {};
 
     /**
-     * Explicitly defines the intermediate result type that a function uses as 
accumulator.
+     * Explicitly defines the intermediate result type (i.e. state entry) that 
an aggregating
+     * function uses as its accumulator. The entry is managed by the framework 
(usually via Flink's
+     * managed state).

Review Comment:
   This is hard to say and might be too implementation specific. It varies from 
operator to operator. Sometimes its MemorySegments, sometimes it's just Java 
heap.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to