[jira] [Updated] (FLINK-33531) Nightly Python fails with NPE at metadataHandlerProvider on AZP (StreamDependencyTests.test_add_python_archive)

2023-11-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-33531: -- Summary: Nightly Python fails with NPE at metadataHandlerProvider on AZP (StreamDependencyTest

[jira] [Commented] (FLINK-31275) Flink supports reporting and storage of source/sink tables relationship

2023-11-14 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785782#comment-17785782 ] Fang Yong commented on FLINK-31275: --- [~mobuchowski] Sorry for the late reply, I think

[jira] [Assigned] (FLINK-33328) Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable

2023-11-14 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-33328: -- Assignee: Peter Vary > Allow TwoPhaseCommittingSink WithPreCommitTopology to alter th

Re: [PR] [FLINK-33208] Support the writable metadata timestamp [flink-connector-hbase]

2023-11-14 Thread via GitHub
Tan-JiaLiang commented on PR #24: URL: https://github.com/apache/flink-connector-hbase/pull/24#issuecomment-1809722599 > I think handling WritableMetadata as an enum makes interactions with the class kinf of hard to read. I didn't think much of it at first, I just followed the Writab

[jira] [Created] (FLINK-33540) Test CI on arm

2023-11-14 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33540: - Summary: Test CI on arm Key: FLINK-33540 URL: https://issues.apache.org/jira/browse/FLINK-33540 Project: Flink Issue Type: Sub-task Reporter: M

Re: [PR] [FLINK-33401][connectors/kafka] Fix the wrong download link and version in the connector doc [flink-connector-kafka]

2023-11-14 Thread via GitHub
MartijnVisser merged PR #64: URL: https://github.com/apache/flink-connector-kafka/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

Re: [PR] [FLINK-33401][connectors/kafka] Fix the wrong download link and version in the connector doc [flink-connector-kafka]

2023-11-14 Thread via GitHub
boring-cyborg[bot] commented on PR #64: URL: https://github.com/apache/flink-connector-kafka/pull/64#issuecomment-1809784080 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Closed] (FLINK-33401) Kafka connector has broken version

2023-11-14 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-33401. -- Fix Version/s: kafka-3.0.1 Assignee: Yuxin Tan Resolution: Fixed Fixed in apac

Re: [PR] [FLINK-33401][connectors/kafka] Fix the wrong download link and version in the connector doc [flink-connector-kafka]

2023-11-14 Thread via GitHub
TanYuxin-tyx commented on PR #64: URL: https://github.com/apache/flink-connector-kafka/pull/64#issuecomment-1809787649 @MartijnVisser Thanks a lot for the careful review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [FLINK-33448][runtime] Introduce a new configuration item 'taskmanager.load-balance.mode' [flink]

2023-11-14 Thread via GitHub
RocMarshal commented on PR #23658: URL: https://github.com/apache/flink/pull/23658#issuecomment-1809790375 Thanks @zhuzhurk for the comment & @1996fanrui for the ping. I'll drive a simple jira & pr to advance it. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [FLINK-33448][runtime] Introduce a new configuration item 'taskmanager.load-balance.mode' [flink]

2023-11-14 Thread via GitHub
1996fanrui commented on PR #23658: URL: https://github.com/apache/flink/pull/23658#issuecomment-1809801025 > Thanks @zhuzhurk for the comment & @1996fanrui for the ping. I'll drive a simple jira & pr to advance it. @RocMarshal No, don't need extra PR and JIRA. As @KarmaGYZ 's suggesti

[jira] [Commented] (FLINK-33483) Why is “UNDEFINED” defined in the Flink task status?

2023-11-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785809#comment-17785809 ] Matthias Pohl commented on FLINK-33483: --- I guess {{ApplicationStatus.UNKNOWN}} is

Re: [PR] [FLINK-33482] Flink benchmark regression check in new machines hosted on Aliyun [flink-benchmarks]

2023-11-14 Thread via GitHub
fredia commented on PR #81: URL: https://github.com/apache/flink-benchmarks/pull/81#issuecomment-1809813232 @Zakelly Thanks for the PR, LGTM, the Java Version logs make the results more readable👍. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Commented] (FLINK-18356) flink-table-planner Exit code 137 returned from process

2023-11-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785810#comment-17785810 ] Matthias Pohl commented on FLINK-18356: --- * https://dev.azure.com/apache-flink/apa

[jira] [Commented] (FLINK-33531) Nightly Python fails with NPE at metadataHandlerProvider on AZP (StreamDependencyTests.test_add_python_archive)

2023-11-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785811#comment-17785811 ] Matthias Pohl commented on FLINK-33531: --- * https://dev.azure.com/apache-flink/apa

[jira] [Commented] (FLINK-31278) exit code 137 (i.e. OutOfMemoryError) in core module

2023-11-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785812#comment-17785812 ] Matthias Pohl commented on FLINK-31278: --- https://dev.azure.com/apache-flink/apache

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-14 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785813#comment-17785813 ] david radley commented on FLINK-33365: -- [~qingwei91] thank you very much for you su

[jira] [Commented] (FLINK-32917) Other announcements

2023-11-14 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785816#comment-17785816 ] Sergey Nuyanzin commented on FLINK-32917: - * 1.18.0 has been registered wit

[jira] [Comment Edited] (FLINK-32917) Other announcements

2023-11-14 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785816#comment-17785816 ] Sergey Nuyanzin edited comment on FLINK-32917 at 11/14/23 9:28 AM: ---

[jira] [Resolved] (FLINK-32917) Other announcements

2023-11-14 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-32917. - Resolution: Fixed > Other announcements > --- > > Key: F

[jira] [Commented] (FLINK-33531) Nightly Python fails with NPE at metadataHandlerProvider on AZP (StreamDependencyTests.test_add_python_archive)

2023-11-14 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785823#comment-17785823 ] lincoln lee commented on FLINK-33531: - [~dianfu] it would be appreciated if you have

[PR] [FLINK-32563] add additionalExcludes property to add exclusions to surefire tests [flink-connector-shared-utils]

2023-11-14 Thread via GitHub
echauchot opened a new pull request, #26: URL: https://github.com/apache/flink-connector-shared-utils/pull/26 Related to what was discussed [here](https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1383402031), this PR adds an optional property to add exclusions to s

Re: [PR] [FLINK-33527] Simplify state store cleanup logic [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
gyfora commented on code in PR #710: URL: https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r1392315670 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ConfigMapStore.java: ## @@ -44,13 +43,44 @@ public class Conf

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-14 Thread Lim Qing Wei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785826#comment-17785826 ] Lim Qing Wei commented on FLINK-33365: -- I am not familiar with Calcite, not able to

Re: [PR] [FLINK-32563] Allow to execute archunit tests only with Flink version that connectors were built against [flink-connector-shared-utils]

2023-11-14 Thread via GitHub
echauchot commented on code in PR #23: URL: https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1392333918 ## .github/workflows/ci.yml: ## @@ -88,6 +93,10 @@ jobs: if: ${{ inputs.run_dependency_convergence }} run: echo "MVN_DEPENDENCY_C

Re: [PR] [FLINK-32563] Allow to execute archunit tests only with Flink version that connectors were built against [flink-connector-shared-utils]

2023-11-14 Thread via GitHub
echauchot commented on PR #23: URL: https://github.com/apache/flink-connector-shared-utils/pull/23#issuecomment-1809912563 > > @zentol I fixed the PR: mainly separated dep convergence checks and archunit tests. > > I have also simulated an archunit violation with the behavior of the jir

Re: [PR] [FLINK-32563] Allow to execute archunit tests only with Flink version that connectors were built against [flink-connector-shared-utils]

2023-11-14 Thread via GitHub
echauchot commented on code in PR #23: URL: https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1392333918 ## .github/workflows/ci.yml: ## @@ -88,6 +93,10 @@ jobs: if: ${{ inputs.run_dependency_convergence }} run: echo "MVN_DEPENDENCY_C

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
tagarr closed pull request #689: [Flink 31966] Flink Kubernetes operator lacks TLS support URL: https://github.com/apache/flink-kubernetes-operator/pull/689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
tagarr commented on PR #689: URL: https://github.com/apache/flink-kubernetes-operator/pull/689#issuecomment-1809928500 @gaborgsomogyi I'm going to close this PR and submit a new one with all the new changes -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Created] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-14 Thread Guojun Li (Jira)
Guojun Li created FLINK-33541: - Summary: RAND_INTEGER can't be existed in a IF statement Key: FLINK-33541 URL: https://issues.apache.org/jira/browse/FLINK-33541 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-30593) Determine restart time on the fly for Autoscaler

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30593: --- Labels: pull-request-available (was: ) > Determine restart time on the fly for Autoscaler >

Re: [PR] [FLINK-33148] Update Web UI to adopt the new "endpoint" field in REST API [flink]

2023-11-14 Thread via GitHub
huwh commented on code in PR #23698: URL: https://github.com/apache/flink/pull/23698#discussion_r1392411663 ## flink-runtime-web/web-dashboard/src/app/interfaces/job-exception.ts: ## @@ -44,7 +44,8 @@ export interface ExceptionInfo { stacktrace: string; timestamp: number;

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-14 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785849#comment-17785849 ] Benchao Li commented on FLINK-33365: [~davidradl] "lookup table source" is a special

[jira] [Commented] (FLINK-32927) Verify that no exclusions were erroneously added to the japicmp plugin

2023-11-14 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785853#comment-17785853 ] Sergey Nuyanzin commented on FLINK-32927: - Based on local check there is no excl

Re: [PR] [hotfix][build] Bump lowest supported flink version to 1.17.0 [flink-connector-gcp-pubsub]

2023-11-14 Thread via GitHub
leonardBang commented on PR #20: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/20#issuecomment-181005 Hello, @dannycranmer @MartijnVisser Any more comments on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (FLINK-33542) Update HBase connector tests to JUnit5

2023-11-14 Thread Ferenc Csaky (Jira)
Ferenc Csaky created FLINK-33542: Summary: Update HBase connector tests to JUnit5 Key: FLINK-33542 URL: https://issues.apache.org/jira/browse/FLINK-33542 Project: Flink Issue Type: Improvemen

[jira] [Commented] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-14 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785864#comment-17785864 ] Martijn Visser commented on FLINK-33541: Isn't this by design, per the 1.15 rele

Re: [PR] [FLINK-33208] Support the writable metadata timestamp [flink-connector-hbase]

2023-11-14 Thread via GitHub
ferenc-csaky commented on PR #24: URL: https://github.com/apache/flink-connector-hbase/pull/24#issuecomment-1810089915 > And one more question, i want to keep your changes, but i want to squash all the commit in one too (maybe it can good for maintainer merge my PR), any suggestion? Seems

[jira] [Created] (FLINK-33543) Move Java 17-specific code into its own module to please Intellij

2023-11-14 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33543: - Summary: Move Java 17-specific code into its own module to please Intellij Key: FLINK-33543 URL: https://issues.apache.org/jira/browse/FLINK-33543 Project: Flink

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-14 Thread via GitHub
dawidwys closed pull request #23660: [FLINK-33455] Implement restore tests for SortLimit node URL: https://github.com/apache/flink/pull/23660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[PR] [FLINK-33542] Update tests to JUnit5 [flink-connector-hbase]

2023-11-14 Thread via GitHub
ferenc-csaky opened a new pull request, #32: URL: https://github.com/apache/flink-connector-hbase/pull/32 Update the existing tests to JUnit5. Except `HBaseTablePlanTest`, which is based on `TableTestBase` from the core Flink repo, that is still on JUnit4. -- This is an automated m

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-11-14 Thread via GitHub
afedulov commented on PR #23553: URL: https://github.com/apache/flink/pull/23553#issuecomment-1810121992 @snuyanzin thanks for the pointer, is seems to be related, albite a somewhat different issue. The constructor for which ArchUnit previously added a violation was removed, but running it

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-11-14 Thread via GitHub
afedulov commented on PR #23553: URL: https://github.com/apache/flink/pull/23553#issuecomment-1810122266 @zentol CI is green -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Closed] (FLINK-33455) Implement restore tests for SortLimit node

2023-11-14 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33455. Resolution: Implemented Implemented in 32d31cb8b838451182d1949414b73ed585b13336 > Impleme

[jira] [Updated] (FLINK-33455) Implement restore tests for SortLimit node

2023-11-14 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-33455: - Fix Version/s: 1.19.0 > Implement restore tests for SortLimit node > ---

[jira] [Updated] (FLINK-33542) Update HBase connector tests to JUnit5

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33542: --- Labels: pull-request-available (was: ) > Update HBase connector tests to JUnit5 > -

Re: [PR] [FLINK-33208] Support the writable metadata timestamp [flink-connector-hbase]

2023-11-14 Thread via GitHub
Tan-JiaLiang commented on PR #24: URL: https://github.com/apache/flink-connector-hbase/pull/24#issuecomment-1810128742 > > And one more question, i want to keep your changes, but i want to squash all the commit in one too (maybe it can good for maintainer merge my PR), any suggestion? Seem

[PR] [FLINK-33543][core] Move Java record related tests into their own module since they only compile under JDK17 [flink]

2023-11-14 Thread via GitHub
XComp opened a new pull request, #23709: URL: https://github.com/apache/flink/pull/23709 ## What is the purpose of the change It appears that the way Java record support is introduced in FLINK-32380 doesn't work well together with Intellij. The class exclusion isn't picked up by Inte

[jira] [Updated] (FLINK-33543) Move Java 17-specific code into its own module to please Intellij

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33543: --- Labels: pull-request-available (was: ) > Move Java 17-specific code into its own module to

Re: [PR] [FLINK-33543][core] Move Java record related tests into their own module since they only compile under JDK17 [flink]

2023-11-14 Thread via GitHub
flinkbot commented on PR #23709: URL: https://github.com/apache/flink/pull/23709#issuecomment-1810142940 ## CI report: * ce4217faa2064336ad06d060742df634286a1d18 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32918) Update reference data for Migration Tests

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32918: --- Labels: pull-request-available (was: ) > Update reference data for Migration Tests > --

Re: [PR] [FLINK-32918][tests] Upgraded migration test data [flink]

2023-11-14 Thread via GitHub
flinkbot commented on PR #23710: URL: https://github.com/apache/flink/pull/23710#issuecomment-1810222931 ## CI report: * ff91a0f8cec1e8c4c0b1baec6f6e42054028fd4d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [BP-18][FLINK-32918][tests] Upgraded migration test data [flink]

2023-11-14 Thread via GitHub
flinkbot commented on PR #23711: URL: https://github.com/apache/flink/pull/23711#issuecomment-1810231300 ## CI report: * 2dfc3c203adb76b682bf2142f7a134fb0b37ac88 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33543][core] Move Java record related tests into their own module since they only compile under JDK17 [flink]

2023-11-14 Thread via GitHub
gyfora commented on code in PR #23709: URL: https://github.com/apache/flink/pull/23709#discussion_r1392606354 ## pom.xml: ## @@ -1088,6 +1087,10 @@ under the License. 2.12.15 + +

Re: [PR] [FLINK-33543][core] Move Java record related tests into their own module since they only compile under JDK17 [flink]

2023-11-14 Thread via GitHub
zentol commented on code in PR #23709: URL: https://github.com/apache/flink/pull/23709#discussion_r1392613425 ## tools/maven/suppressions-tests-java17.xml: ## @@ -0,0 +1,28 @@ + + + +http://www.puppycrawl.com/dtds/suppressions_1_1.dtd";> + + + Review Comment: Good job

[PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
tagarr opened a new pull request, #712: URL: https://github.com/apache/flink-kubernetes-operator/pull/712 ## What is the purpose of the change If the FlinkDeployment CR is configured to use ssl, the operator is unable to properly reconcile the deployment as the underlying RestClient t

Re: [PR] [FLINK-33543][core] Move Java record related tests into their own module since they only compile under JDK17 [flink]

2023-11-14 Thread via GitHub
XComp commented on code in PR #23709: URL: https://github.com/apache/flink/pull/23709#discussion_r1392624431 ## pom.xml: ## @@ -1088,6 +1087,10 @@ under the License. 2.12.15 + +

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
tagarr commented on PR #712: URL: https://github.com/apache/flink-kubernetes-operator/pull/712#issuecomment-1810259167 @gaborgsomogyi Please see this new PR which I hope provides the correct functionality. Looking forward to your feedback -- This is an automated message from the Apache G

Re: [PR] [FLINK-33208] Support the writable metadata timestamp [flink-connector-hbase]

2023-11-14 Thread via GitHub
MartijnVisser merged PR #24: URL: https://github.com/apache/flink-connector-hbase/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[jira] [Assigned] (FLINK-33208) Support the writable metadata timestamp for hbase connector

2023-11-14 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-33208: -- Assignee: tanjialiang > Support the writable metadata timestamp for hbase connector >

[jira] [Closed] (FLINK-33208) Support the writable metadata timestamp for hbase connector

2023-11-14 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-33208. -- Fix Version/s: hbase-3.0.1 Resolution: Fixed Fixed in apache/flink-connector-hbase mai

[jira] [Created] (FLINK-33544) Flink documentation fails to build

2023-11-14 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-33544: -- Summary: Flink documentation fails to build Key: FLINK-33544 URL: https://issues.apache.org/jira/browse/FLINK-33544 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-33527] Simplify state store cleanup logic [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
mxm commented on code in PR #710: URL: https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r1392784565 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ConfigMapStore.java: ## @@ -44,13 +43,44 @@ public class ConfigM

Re: [PR] [FLINK-33527] Simplify state store cleanup logic [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
mxm commented on code in PR #710: URL: https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r1392785211 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ConfigMapStore.java: ## @@ -44,13 +43,44 @@ public class ConfigM

Re: [PR] [FLINK-33527] Simplify state store cleanup logic [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
mxm commented on code in PR #710: URL: https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r1392786446 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ConfigMapStore.java: ## @@ -44,13 +43,44 @@ public class ConfigM

Re: [PR] [FLINK-33527] Simplify state store cleanup logic [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
mxm commented on code in PR #710: URL: https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r1392788100 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ConfigMapStore.java: ## @@ -63,29 +93,29 @@ protected void putSe

Re: [PR] [FLINK-33527] Simplify state store cleanup logic [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
mxm commented on code in PR #710: URL: https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r1392788916 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ConfigMapStore.java: ## @@ -44,13 +43,44 @@ public class ConfigM

Re: [PR] [FLINK-33527] Simplify state store cleanup logic [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
mxm commented on code in PR #710: URL: https://github.com/apache/flink-kubernetes-operator/pull/710#discussion_r1392789442 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -121,37 +120,10 @@ public void cleanup(KEY jobKey) { }

[PR] [FLINK-33276][ci] Merges connect_1 and connect_2 stages into a single one [flink]

2023-11-14 Thread via GitHub
XComp opened a new pull request, #23712: URL: https://github.com/apache/flink/pull/23712 ## What is the purpose of the change * Merged `connect_2` stage into `connect_1` and renamed it into `connect` ## Verifying this change This change is a trivial rework / code cleanup

[jira] [Updated] (FLINK-33276) Reorganize CI stages

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33276: --- Labels: pull-request-available (was: ) > Reorganize CI stages > > >

[jira] [Assigned] (FLINK-33276) Reorganize CI stages

2023-11-14 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-33276: - Assignee: Matthias Pohl > Reorganize CI stages > > >

Re: [PR] [FLINK-33276][ci] Merges connect_1 and connect_2 stages into a single one [flink]

2023-11-14 Thread via GitHub
flinkbot commented on PR #23712: URL: https://github.com/apache/flink/pull/23712#issuecomment-1810476514 ## CI report: * c29e9dde95a33523a13b2ac25f2f7bae041c3458 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-14 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785940#comment-17785940 ] Benchao Li commented on FLINK-33541: [~martijnvisser] Could you point out the ticket

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
mxm commented on PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#issuecomment-1810524690 Commenting on some of the requests: > 1. Remove the newly introduced configs, this should be automatic and always on I think it is fair to have a ON/OFF switch.

[jira] [Commented] (FLINK-33528) Externalize Python connector code

2023-11-14 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-33528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785947#comment-17785947 ] Márton Balassi commented on FLINK-33528: [~pvary] is taking a stab at an example

[PR] include filters with Lookup joins [flink-connector-jdbc]

2023-11-14 Thread via GitHub
davidradl opened a new pull request, #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] include filters with Lookup joins [flink-connector-jdbc]

2023-11-14 Thread via GitHub
boring-cyborg[bot] commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1810573453 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is an

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
afedulov commented on PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#issuecomment-1810584902 @gyfora @mxm thanks for the feedback. >We already have the start time of the last scaling in memory via the scaling history. We can then keep note of the end time once

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-14 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785967#comment-17785967 ] david radley commented on FLINK-33365: -- [~qingwei91] I have had a play and have som

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-14 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785967#comment-17785967 ] david radley edited comment on FLINK-33365 at 11/14/23 4:31 PM: --

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-14 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785967#comment-17785967 ] david radley edited comment on FLINK-33365 at 11/14/23 4:32 PM: --

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-14 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785967#comment-17785967 ] david radley edited comment on FLINK-33365 at 11/14/23 4:33 PM: --

[jira] [Updated] (FLINK-33410) Implement type inference for Over function

2023-11-14 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-33410: - Summary: Implement type inference for Over function (was: Implement type inference for

[jira] [Assigned] (FLINK-33410) Implement type inference for Over offsets functions

2023-11-14 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz reassigned FLINK-33410: Assignee: Dawid Wysakowicz > Implement type inference for Over offsets functions

[jira] [Updated] (FLINK-33410) Implement type inference for Over function

2023-11-14 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-33410: - Description: https://github.com/apache/flink/blob/91d81c427aa6312841ca868d54e8ce6ea721cd

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
mxm commented on PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#issuecomment-1810649406 >Are we talking about having a field in the ScalingExecutor? Because fetching scalingHistory won't be sufficient - we need some indication that a new rescaling was applied by

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
afedulov commented on PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#issuecomment-1810668734 >I meant a flag in the ConfigMap. I guess something like startTime: endTime would be sufficient? The endTime would initially be null. Got it, this is how it actual

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-14 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785967#comment-17785967 ] david radley edited comment on FLINK-33365 at 11/14/23 4:49 PM: --

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-14 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785967#comment-17785967 ] david radley edited comment on FLINK-33365 at 11/14/23 4:50 PM: --

[PR] Over window [flink]

2023-11-14 Thread via GitHub
dawidwys opened a new pull request, #23713: URL: https://github.com/apache/flink/pull/23713 ## What is the purpose of the change It implements type inference for `OVER`, `STREAM_RECORD` and `THROW_EXCEPTION` functions. ## Verifying this change * all available tests pass

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-14 Thread via GitHub
mxm commented on PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#issuecomment-1810690806 > Got it, this is how it actually works currently (modulo additional target vertices parallelism tracking that I will attempt to fetch from the history instead) - I thought i

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
jnh5y commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1392927090 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2057,35 +2057,8 @@ ANY, and(logical(LogicalTypeRo

[jira] [Updated] (FLINK-33410) Implement type inference for Over function

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33410: --- Labels: pull-request-available (was: ) > Implement type inference for Over function > -

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
flinkbot commented on PR #23713: URL: https://github.com/apache/flink/pull/23713#issuecomment-1810695279 ## CI report: * 671eca40d099b2c3303a410ada5cbd321843b65e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] add failed offset to Flink error messages [flink-statefun]

2023-11-14 Thread via GitHub
kazimirov999 commented on code in PR #336: URL: https://github.com/apache/flink-statefun/pull/336#discussion_r1392929689 ## statefun-flink/statefun-flink-io-bundle/src/main/java/org/apache/flink/statefun/flink/io/kafka/binders/ingress/v1/RoutableKafkaIngressDeserializer.java: ##

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
dawidwys commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1392930722 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2057,35 +2057,8 @@ ANY, and(logical(LogicalTyp

Re: [PR] add failed offset to Flink error messages [flink-statefun]

2023-11-14 Thread via GitHub
kazimirov999 commented on code in PR #336: URL: https://github.com/apache/flink-statefun/pull/336#discussion_r1392929689 ## statefun-flink/statefun-flink-io-bundle/src/main/java/org/apache/flink/statefun/flink/io/kafka/binders/ingress/v1/RoutableKafkaIngressDeserializer.java: ##

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
jnh5y commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1392931305 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/expressions/PlannerExpressionConverter.scala: ## @@ -79,12 +79,6 @@ class PlannerExpressi

Re: [PR] add failed offset to Flink error messages [flink-statefun]

2023-11-14 Thread via GitHub
kazimirov999 commented on code in PR #336: URL: https://github.com/apache/flink-statefun/pull/336#discussion_r1392929689 ## statefun-flink/statefun-flink-io-bundle/src/main/java/org/apache/flink/statefun/flink/io/kafka/binders/ingress/v1/RoutableKafkaIngressDeserializer.java: ##

Re: [PR] [FLINK-33410] Implement type inference for OVER function [flink]

2023-11-14 Thread via GitHub
jnh5y commented on code in PR #23713: URL: https://github.com/apache/flink/pull/23713#discussion_r1392936413 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -2302,7 +2302,8 @@ ANY, and(logical(LogicalTypeRoo

  1   2   >