echauchot commented on PR #23: URL: https://github.com/apache/flink-connector-shared-utils/pull/23#issuecomment-1809912563
> > @zentol I fixed the PR: mainly separated dep convergence checks and archunit tests. > > I have also simulated an archunit violation with the behavior of the jira ticket: a rule was fixed in a snapshot leading to a new violation (ConnectorRules#CONNECTOR_CLASSES_ONLY_DEPEND_ON_PUBLIC_API that I fixed and that you reviewed). See [this commit](https://github.com/apache/flink-connector-shared-utils/pull/23/commits/eb28d4ba4f5434e356fd09120c9420f726004266). I think we can leave such a violation in the test project to serve for future tests. > > @zentol do you agree to keep this simulated violation for testing purpose ? > > > After playing a lot with this simulation locally, I find that the comments in `archunit.properties` could be improved because not precise enough and even a bit misleading. I propose [this comments change](https://github.com/apache/flink-connector-shared-utils/pull/23/commits/a16852321a829fc0c42271570563655c41dc8d14). If you agree with the change, I'll do a PR to flink-architecture-tests module. > > @zentol do you agree with my proposed modifications to the doc in the conf so that I can do the related flink-architecture-tests PR ? any comments on there 2 questions ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
