echauchot commented on code in PR #23:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1392333918
##########
.github/workflows/ci.yml:
##########
@@ -88,6 +93,10 @@ jobs:
if: ${{ inputs.run_dependency_convergence }}
run: echo
"MVN_DEPENDENCY_CONVERGENCE=-Dflink.convergence.phase=install
-Pcheck-convergence" >> $GITHUB_ENV
+ - name: "Disable archunit tests"
+ if: ${{ inputs.skip_archunit_tests }}
+ run: echo "MVN_ARCHUNIT_TESTS=-Dtest='!*ArchitectureTest'" >>
$GITHUB_ENV
Review Comment:
I have updated the PR as discussed above:
- use new **additionalExcludes** property to exclude archunit tests. This
property is added in [this
PR](https://github.com/apache/flink-connector-shared-utils/pull/26) that needs
to be merged and released (v 1.0.1) before merging the current PR. See
[here](https://github.com/apache/flink-connector-shared-utils/pull/26#issue-1992394911)
how it was tested.
- move to **org.apache.flink**:flink-connector-parent instead of
**io.github.zentol.flink**:flink-connector-parent in test project.
- changed the test project structure to include 2 submodules. Test-project
is now a parent and there is 1 module with tests (the former test project) and
one without tests. This is to illustrate the case discussed above of the sql
module containing no tests.
@zentol PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
