Tan-JiaLiang commented on PR #24: URL: https://github.com/apache/flink-connector-hbase/pull/24#issuecomment-1809722599
> I think handling WritableMetadata as an enum makes interactions with the class kinf of hard to read. I didn't think much of it at first, I just followed the WritableMetadata design of [flink-connector-kafka.](https://github.com/apache/flink-connector-kafka). Because I think it's best to be consistent with these kinds of implementations. But I rethink about it, for now the connectors have split into two different projects, and your refactor is better IMO, so +1 for your suggestion. > I also wondered about is it make sense to handle interactions with WritableMetadata as it has multiple different metadata, while we only have TIMESTAMP for now? Yes, there also FLINK-30460 should also be supported IMO. After this PR merged, I'll support it ASAP. I cherry-pick your PR and do a little bit of optimization, PTAL. And one more question, i want to keep your changes, but i want to squash all the commit in one too (maybe it can good for maintainer merge my PR), any suggestion? Seems git can not keep one commit two authors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
