dawidwys commented on code in PR #23713:
URL: https://github.com/apache/flink/pull/23713#discussion_r1392930722
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -2057,35 +2057,8 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
BuiltInFunctionDefinition.newBuilder()
.name("over")
.kind(OTHER)
- .outputTypeStrategy(TypeStrategies.MISSING)
- .build();
-
- public static final BuiltInFunctionDefinition UNBOUNDED_RANGE =
- BuiltInFunctionDefinition.newBuilder()
- .name("unboundedRange")
- .kind(OTHER)
- .outputTypeStrategy(TypeStrategies.MISSING)
- .build();
-
- public static final BuiltInFunctionDefinition UNBOUNDED_ROW =
- BuiltInFunctionDefinition.newBuilder()
- .name("unboundedRow")
- .kind(OTHER)
- .outputTypeStrategy(TypeStrategies.MISSING)
- .build();
-
- public static final BuiltInFunctionDefinition CURRENT_RANGE =
- BuiltInFunctionDefinition.newBuilder()
- .name("currentRange")
- .kind(OTHER)
- .outputTypeStrategy(TypeStrategies.MISSING)
- .build();
-
- public static final BuiltInFunctionDefinition CURRENT_ROW =
Review Comment:
With a symbol. Those were actually not really functions, but a poor
imitation of a symbol.
If I implement them properly as symbols I can also do the validation and
check for those in `OverTypeStrategy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
