[jira] [Commented] (FLINK-25699) Use HashMap for MAP value constructors

2022-01-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482313#comment-17482313 ] Sergey Nuyanzin commented on FLINK-25699: - thanks for your comments. Regarding c

[jira] [Comment Edited] (FLINK-25699) Use HashMap for MAP value constructors

2022-01-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482313#comment-17482313 ] Sergey Nuyanzin edited comment on FLINK-25699 at 1/26/22, 7:59 AM: ---

[GitHub] [flink] flinkbot edited a comment on pull request #18418: [FLINK-25719][python] Support General Python UDF in Thread Mode

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18418: URL: https://github.com/apache/flink/pull/18418#issuecomment-1017307428 ## CI report: * 4e95ae2d0e8a2e2a2e3d85640d5ab125e86ede6c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[jira] [Comment Edited] (FLINK-25699) Use HashMap for MAP value constructors

2022-01-26 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482313#comment-17482313 ] Sergey Nuyanzin edited comment on FLINK-25699 at 1/26/22, 8:01 AM: ---

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-26 Thread GitBox
slinkydeveloper commented on a change in pull request #18479: URL: https://github.com/apache/flink/pull/18479#discussion_r792385485 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/JsonSerdeUtil.java ## @@ -21,8 +

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-26 Thread GitBox
slinkydeveloper commented on a change in pull request #18479: URL: https://github.com/apache/flink/pull/18479#discussion_r792385485 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/JsonSerdeUtil.java ## @@ -21,8 +

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-26 Thread GitBox
slinkydeveloper commented on a change in pull request #18479: URL: https://github.com/apache/flink/pull/18479#discussion_r792386400 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java ## @@ -0,0 +1,94

[GitHub] [flink] KarmaGYZ commented on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…

2022-01-26 Thread GitBox
KarmaGYZ commented on pull request #18434: URL: https://github.com/apache/flink/pull/18434#issuecomment-1021955008 @dawidwys I'll fill that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [flink] dawidwys commented on pull request #18434: [FLINK-25742][akka] Remove the serialization of rpc invocation at Fli…

2022-01-26 Thread GitBox
dawidwys commented on pull request #18434: URL: https://github.com/apache/flink/pull/18434#issuecomment-1021956202 Thanks @KarmaGYZ ! I know from personal experience it might be daunting at times :sweat_smile: -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [flink-benchmarks] wsry opened a new pull request #44: [FLINK-25704] Fix the blocking partition benchmark regression caused by FLINK-25637

2022-01-26 Thread GitBox
wsry opened a new pull request #44: URL: https://github.com/apache/flink-benchmarks/pull/44 FLINK-25637 changed the default blocking shuffle implementation from hash-shuffle to sort-shuffle which caused some benchmark regression. This PR tries to fix the regression. For more information ab

[jira] [Updated] (FLINK-25704) Performance regression on 18.01.2022 in batch network benchmarks

2022-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25704: --- Labels: pull-request-available (was: ) > Performance regression on 18.01.2022 in batch netw

[GitHub] [flink] XComp commented on a change in pull request #18189: [FLINK-25430] Replace RunningJobRegistry by JobResultStore

2022-01-26 Thread GitBox
XComp commented on a change in pull request #18189: URL: https://github.com/apache/flink/pull/18189#discussion_r792392290 ## File path: flink-clients/src/test/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrapITCase.java ## @@ -147,6 +157,67 @@

[GitHub] [flink] slinkydeveloper commented on pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-26 Thread GitBox
slinkydeveloper commented on pull request #18479: URL: https://github.com/apache/flink/pull/18479#issuecomment-1021961660 > Because, with the upgrade story, we can have an @ExecNodeMetadata annotation with the same name, on a subclass of a current ExecNode class, which does something new/d

[GitHub] [flink] infoverload commented on a change in pull request #18431: [FLINK-25024][docs] Add Changelog backend docs

2022-01-26 Thread GitBox
infoverload commented on a change in pull request #18431: URL: https://github.com/apache/flink/pull/18431#discussion_r792382240 ## File path: docs/content/docs/ops/metrics.md ## @@ -1203,6 +1203,59 @@ Note that for failed checkpoints, metrics are updated on a best efforts basi

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #14: [FLINK-25803] Implement partition and bucket filter in FileStoreScanImpl

2022-01-26 Thread GitBox
JingsongLi commented on a change in pull request #14: URL: https://github.com/apache/flink-table-store/pull/14#discussion_r792393666 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreWriteImpl.java ## @@ -0,0 +1,107 @@ +/*

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #14: [FLINK-25803] Implement partition and bucket filter in FileStoreScanImpl

2022-01-26 Thread GitBox
JingsongLi commented on a change in pull request #14: URL: https://github.com/apache/flink-table-store/pull/14#discussion_r792394148 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreWriteImpl.java ## @@ -0,0 +1,107 @@ +/*

[GitHub] [flink] flinkbot edited a comment on pull request #18500: [FLINK-25312][hive] HiveCatalog supports Flink's managed table

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18500: URL: https://github.com/apache/flink/pull/18500#issuecomment-1021030168 ## CI report: * d7dc483a078a947fe4d397c17e3ec3fa9ec8db72 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resu

[GitHub] [flink] flinkbot edited a comment on pull request #18505: [FLINK-25796][network] Avoid record copy for result partition of sort-shuffle if there are enough buffers for better performance

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18505: URL: https://github.com/apache/flink/pull/18505#issuecomment-1021169033 ## CI report: * 7937706340bfa394537cc62380693fa12abe3d38 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #14: [FLINK-25803] Implement partition and bucket filter in FileStoreScanImpl

2022-01-26 Thread GitBox
JingsongLi commented on a change in pull request #14: URL: https://github.com/apache/flink-table-store/pull/14#discussion_r792405101 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreWriteImpl.java ## @@ -0,0 +1,107 @@ +/*

[GitHub] [flink] flinkbot edited a comment on pull request #18505: [FLINK-25796][network] Avoid record copy for result partition of sort-shuffle if there are enough buffers for better performance

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18505: URL: https://github.com/apache/flink/pull/18505#issuecomment-1021169033 ## CI report: * 7937706340bfa394537cc62380693fa12abe3d38 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] Myasuka commented on a change in pull request #18391: [FLINK-25478][chaneglog] Correct the state register logic of ChangelogStateBackendHandle

2022-01-26 Thread GitBox
Myasuka commented on a change in pull request #18391: URL: https://github.com/apache/flink/pull/18391#discussion_r792406221 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java ## @@ -130,14 +155,51 @@ public Strin

[GitHub] [flink] matriv commented on pull request #18479: [FLINK-25387] Introduce ExecNodeMetadata

2022-01-26 Thread GitBox
matriv commented on pull request #18479: URL: https://github.com/apache/flink/pull/18479#issuecomment-1021979678 > > Because, with the upgrade story, we can have an @ExecNodeMetadata annotation with the same name, on a subclass of a current ExecNode class, which does something new/differen

[GitHub] [flink] flinkbot edited a comment on pull request #18353: [FLINK-25129][docs]project configuation changes in docs

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18353: URL: https://github.com/apache/flink/pull/18353#issuecomment-1012981377 ## CI report: * 80fd50ad46865be06e2c83b2470fb3eb2d35cd96 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #18428: [FLINK-25575] Add Sink V2 operators and translation

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18428: URL: https://github.com/apache/flink/pull/18428#issuecomment-1017677769 ## CI report: * 3705b617ac596bd4be08fd9ef2e4db40bef586f2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] XComp commented on pull request #17819: [FLINK-15816][k8s] Prevent labels using kubernetes.cluster-id to exceed the limit of 63 characters

2022-01-26 Thread GitBox
XComp commented on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-1021982073 Ok, my understanding was that we're using service names in labels which forces us to set some limitation on the cluster ID. Reiterating over the comments of FLINK-15816, I conclu

[GitHub] [flink] XComp edited a comment on pull request #17819: [FLINK-15816][k8s] Prevent labels using kubernetes.cluster-id to exceed the limit of 63 characters

2022-01-26 Thread GitBox
XComp edited a comment on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-1021982073 Ok, my understanding was that we're using service names in labels which forces us to set some limitation on the cluster ID. Reiterating over the comments of FLINK-15816, I

[GitHub] [flink] pnowojski commented on a change in pull request #18475: [FLINK-25728] Protential memory leaks in StreamMultipleInputProcessor

2022-01-26 Thread GitBox
pnowojski commented on a change in pull request #18475: URL: https://github.com/apache/flink/pull/18475#discussion_r792408057 ## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/MultipleInputStreamTaskTest.java ## @@ -101,10 +101,15 @@ im

[GitHub] [flink] flinkbot edited a comment on pull request #18353: [FLINK-25129][docs]project configuation changes in docs

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18353: URL: https://github.com/apache/flink/pull/18353#issuecomment-1012981377 ## CI report: * 80fd50ad46865be06e2c83b2470fb3eb2d35cd96 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #18428: [FLINK-25575] Add Sink V2 operators and translation

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18428: URL: https://github.com/apache/flink/pull/18428#issuecomment-1017677769 ## CI report: * 3705b617ac596bd4be08fd9ef2e4db40bef586f2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] pnowojski commented on a change in pull request #18505: [FLINK-25796][network] Avoid record copy for result partition of sort-shuffle if there are enough buffers for better performanc

2022-01-26 Thread GitBox
pnowojski commented on a change in pull request #18505: URL: https://github.com/apache/flink/pull/18505#discussion_r792418842 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java ## @@ -41,7 +41,7 @@ * ResultPart

[GitHub] [flink] flinkbot edited a comment on pull request #18145: [FLINK-25368][connectors/kafka] Substitute KafkaConsumer with AdminClient when getting offsets

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18145: URL: https://github.com/apache/flink/pull/18145#issuecomment-997131565 ## CI report: * 83ad01c2346a5e46106e0aef530285aed68d966f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] Thesharing commented on a change in pull request #18480: [FLINK-25789][docs-zh] Translate the formats/hadoop page into Chinese.

2022-01-26 Thread GitBox
Thesharing commented on a change in pull request #18480: URL: https://github.com/apache/flink/pull/18480#discussion_r792409930 ## File path: docs/content.zh/docs/connectors/datastream/formats/hadoop.md ## @@ -57,20 +55,13 @@ a `hadoop-client` dependency such as: ## Using Had

[GitHub] [flink] fapaul merged pull request #18145: [FLINK-25368][connectors/kafka] Substitute KafkaConsumer with AdminClient when getting offsets

2022-01-26 Thread GitBox
fapaul merged pull request #18145: URL: https://github.com/apache/flink/pull/18145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Commented] (FLINK-25368) Use AdminClient to get offsets rather than KafkaConsumer

2022-01-26 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482329#comment-17482329 ] Fabian Paul commented on FLINK-25368: - Merged in master: c6f14ca5b10d30232966bce2f52

[jira] [Commented] (FLINK-25704) Performance regression on 18.01.2022 in batch network benchmarks

2022-01-26 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482328#comment-17482328 ] Piotr Nowojski commented on FLINK-25704: Thanks for the investigation [~kevin.cy

[jira] [Assigned] (FLINK-25368) Use AdminClient to get offsets rather than KafkaConsumer

2022-01-26 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul reassigned FLINK-25368: --- Assignee: dengziming > Use AdminClient to get offsets rather than KafkaConsumer > -

[jira] [Updated] (FLINK-25368) Use AdminClient to get offsets rather than KafkaConsumer

2022-01-26 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul updated FLINK-25368: Affects Version/s: 1.15.0 > Use AdminClient to get offsets rather than KafkaConsumer > ---

[jira] [Resolved] (FLINK-25368) Use AdminClient to get offsets rather than KafkaConsumer

2022-01-26 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul resolved FLINK-25368. - Fix Version/s: 1.15.0 Resolution: Fixed > Use AdminClient to get offsets rather than Kafk

[GitHub] [flink] imaffe commented on a change in pull request #17452: [FLINK-20732][connector/pulsar] Introduction of Pulsar Sink

2022-01-26 Thread GitBox
imaffe commented on a change in pull request #17452: URL: https://github.com/apache/flink/pull/17452#discussion_r792420132 ## File path: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/sink/PulsarSinkBuilder.java ## @@ -0,0 +1,335 @@ +/*

[GitHub] [flink] pnowojski merged pull request #18392: [FLINK-25590][metrics] Introduce RequestedMemoryUsage and log warnings if usage exceeds 100%

2022-01-26 Thread GitBox
pnowojski merged pull request #18392: URL: https://github.com/apache/flink/pull/18392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [flink] pnowojski commented on pull request #18392: [FLINK-25590][metrics] Introduce RequestedMemoryUsage and log warnings if usage exceeds 100%

2022-01-26 Thread GitBox
pnowojski commented on pull request #18392: URL: https://github.com/apache/flink/pull/18392#issuecomment-1021993369 Ops, I forgot to squash commits before merging :| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Closed] (FLINK-25590) Logging warning of insufficient memory for all configured buffers

2022-01-26 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-25590. -- Fix Version/s: 1.15.0 Assignee: Piotr Nowojski Resolution: Fixed Merged to mas

[GitHub] [flink] zentol merged pull request #18501: [FLINK-25348][build] Clear japicmp exclusions

2022-01-26 Thread GitBox
zentol merged pull request #18501: URL: https://github.com/apache/flink/pull/18501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Closed] (FLINK-25348) Update release guide to reset japicmp exceptions for every release

2022-01-26 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-25348. Resolution: Fixed master: d9bb8d7946fa09bb77ffddcc6eea98435ef7f825 I've also updated the

[GitHub] [flink] zhuzhurk commented on a change in pull request #18462: [FLINK-25045][runtime] Introduce AdaptiveBatchScheduler

2022-01-26 Thread GitBox
zhuzhurk commented on a change in pull request #18462: URL: https://github.com/apache/flink/pull/18462#discussion_r791884986 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java ## @@ -190,10 +191,24 @@ private

[GitHub] [flink] TanYuxin-tyx opened a new pull request #18515: [FLINK-21788][network] Throw PartitionNotFoundException if the partition file has been lost for blocking shuffle

2022-01-26 Thread GitBox
TanYuxin-tyx opened a new pull request #18515: URL: https://github.com/apache/flink/pull/18515 ## What is the purpose of the change Currently, if the partition file has been lost for blocking shuffle, FileNotFoundException will be thrown and the partition data will no

[GitHub] [flink] dannycranmer commented on pull request #18512: [FLINK-25811][hotfix][connector/base] changing failed requests handler to accept List in AsyncSinkWriter

2022-01-26 Thread GitBox
dannycranmer commented on pull request #18512: URL: https://github.com/apache/flink/pull/18512#issuecomment-1022002473 Thanks for the improvement @vahmed-hamdy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] dannycranmer merged pull request #18512: [FLINK-25811][hotfix][connector/base] changing failed requests handler to accept List in AsyncSinkWriter

2022-01-26 Thread GitBox
dannycranmer merged pull request #18512: URL: https://github.com/apache/flink/pull/18512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[jira] [Updated] (FLINK-25811) Fix generic AsyncSinkWriter retrying requests in reverse order

2022-01-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-25811: -- Fix Version/s: 1.15.0 > Fix generic AsyncSinkWriter retrying requests in reverse order > -

[jira] [Updated] (FLINK-25816) Changelog keyed state backend would come across NPE during notification

2022-01-26 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-25816: -- Affects Version/s: 1.15.0 > Changelog keyed state backend would come across NPE during

[jira] [Updated] (FLINK-25811) Fix generic AsyncSinkWriter retrying requests in reverse order

2022-01-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-25811: -- Affects Version/s: (was: 1.15.0) > Fix generic AsyncSinkWriter retrying requests in revers

[jira] [Assigned] (FLINK-25811) Fix generic AsyncSinkWriter retrying requests in reverse order

2022-01-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-25811: - Assignee: Ahmed Hamdy > Fix generic AsyncSinkWriter retrying requests in reverse order

[GitHub] [flink-benchmarks] wsry commented on pull request #44: [FLINK-25704] Fix the blocking partition benchmark regression caused by FLINK-25637

2022-01-26 Thread GitBox
wsry commented on pull request #44: URL: https://github.com/apache/flink-benchmarks/pull/44#issuecomment-1022004795 > NETWORK_SORT_SHUFFLE_MIN_PARALLELISM @pnowojski Thanks for the review. ```NETWORK_SORT_SHUFFLE_MIN_PARALLELISM``` is a config option to config which blocking s

[jira] [Resolved] (FLINK-25811) Fix generic AsyncSinkWriter retrying requests in reverse order

2022-01-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-25811. --- Resolution: Fixed > Fix generic AsyncSinkWriter retrying requests in reverse order > ---

[GitHub] [flink] flinkbot commented on pull request #18515: [FLINK-21788][network] Throw PartitionNotFoundException if the partition file has been lost for blocking shuffle

2022-01-26 Thread GitBox
flinkbot commented on pull request #18515: URL: https://github.com/apache/flink/pull/18515#issuecomment-1022004860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[jira] [Commented] (FLINK-25811) Fix generic AsyncSinkWriter retrying requests in reverse order

2022-01-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482338#comment-17482338 ] Danny Cranmer commented on FLINK-25811: --- Also related to https://github.com/apache

[jira] [Commented] (FLINK-25816) Changelog keyed state backend would come across NPE during notification

2022-01-26 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482339#comment-17482339 ] Roman Khachatryan commented on FLINK-25816: --- I think the bug confirms my previ

[jira] [Comment Edited] (FLINK-25816) Changelog keyed state backend would come across NPE during notification

2022-01-26 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482339#comment-17482339 ] Roman Khachatryan edited comment on FLINK-25816 at 1/26/22, 9:14 AM: -

[jira] (FLINK-25816) Changelog keyed state backend would come across NPE during notification

2022-01-26 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25816 ] Roman Khachatryan deleted comment on FLINK-25816: --- was (Author: roman_khachatryan): I think the bug confirms my previous [apprehension|https://github.com/apache/flink/pull/18382#discus

[GitHub] [flink] fapaul commented on a change in pull request #18412: [FLINK-25696][datastream] Introduce metadataConsumer to InitContext in Sink

2022-01-26 Thread GitBox
fapaul commented on a change in pull request #18412: URL: https://github.com/apache/flink/pull/18412#discussion_r792434481 ## File path: flink-core/src/main/java/org/apache/flink/api/connector/sink/Sink.java ## @@ -170,6 +171,15 @@ * previous execution. */

[GitHub] [flink] dannycranmer commented on a change in pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-26 Thread GitBox
dannycranmer commented on a change in pull request #18483: URL: https://github.com/apache/flink/pull/18483#discussion_r792438959 ## File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsSink.java ##

[GitHub] [flink] dannycranmer commented on a change in pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-26 Thread GitBox
dannycranmer commented on a change in pull request #18483: URL: https://github.com/apache/flink/pull/18483#discussion_r792439657 ## File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsSinkElementC

[GitHub] [flink] flinkbot edited a comment on pull request #18515: [FLINK-21788][network] Throw PartitionNotFoundException if the partition file has been lost for blocking shuffle

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18515: URL: https://github.com/apache/flink/pull/18515#issuecomment-1022004860 ## CI report: * 7ddd8e3928e4c3defabb6ed8cc167a3b1e832b3c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@fl

[jira] [Commented] (FLINK-25816) Changelog keyed state backend would come across NPE during notification

2022-01-26 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482342#comment-17482342 ] Roman Khachatryan commented on FLINK-25816: --- I think the bug confirms my previ

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-26 Thread GitBox
CrynetLogistics commented on a change in pull request #18483: URL: https://github.com/apache/flink/pull/18483#discussion_r792442692 ## File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsSinkEleme

[GitHub] [flink] flinkbot edited a comment on pull request #18515: [FLINK-21788][network] Throw PartitionNotFoundException if the partition file has been lost for blocking shuffle

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18515: URL: https://github.com/apache/flink/pull/18515#issuecomment-1022004860 ## CI report: * 7ddd8e3928e4c3defabb6ed8cc167a3b1e832b3c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-26 Thread GitBox
CrynetLogistics commented on a change in pull request #18483: URL: https://github.com/apache/flink/pull/18483#discussion_r792444851 ## File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsSink.java

[GitHub] [flink] wsry commented on pull request #18470: [FLINK-25774][network] Restrict the maximum number of buffers can be used per result partition for sort-shuffle

2022-01-26 Thread GitBox
wsry commented on pull request #18470: URL: https://github.com/apache/flink/pull/18470#issuecomment-1022016135 Rebased master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [flink] fapaul commented on a change in pull request #18428: [FLINK-25575] Add Sink V2 operators and translation

2022-01-26 Thread GitBox
fapaul commented on a change in pull request #18428: URL: https://github.com/apache/flink/pull/18428#discussion_r792447708 ## File path: flink-architecture-tests/violations/5b9eed8a-5fb6-4373-98ac-3be2a71941b8 ## @@ -93,7 +93,6 @@ org.apache.flink.connector.file.src.util.Pool.

[jira] [Commented] (FLINK-25806) Remove legacy high availability services

2022-01-26 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482344#comment-17482344 ] Matthias Pohl commented on FLINK-25806: --- I linked FLINK-25432 as well: We can remo

[GitHub] [flink] flinkbot edited a comment on pull request #18505: [FLINK-25796][network] Avoid record copy for result partition of sort-shuffle if there are enough buffers for better performance

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18505: URL: https://github.com/apache/flink/pull/18505#issuecomment-1021169033 ## CI report: * 62ce77fe716ae2cfa26fb5cc04948683acc33e40 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resu

[GitHub] [flink] XComp commented on a change in pull request #17485: [FLINK-24038] Add support for single leader election per JobManager process

2022-01-26 Thread GitBox
XComp commented on a change in pull request #17485: URL: https://github.com/apache/flink/pull/17485#discussion_r786874117 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/highavailability/KubernetesCheckpointRecoveryFactory.java ## @@ -78,21 +84,46 @@ p

[GitHub] [flink] wsry commented on a change in pull request #18474: [FLINK-25786][network] Adjust the generation of subpartition data storage order for sort-shuffle from random shuffle to random shift

2022-01-26 Thread GitBox
wsry commented on a change in pull request #18474: URL: https://github.com/apache/flink/pull/18474#discussion_r792449522 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SortMergeResultPartition.java ## @@ -492,10 +490,13 @@ public int ge

[GitHub] [flink] ruanhang1993 opened a new pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe

2022-01-26 Thread GitBox
ruanhang1993 opened a new pull request #18516: URL: https://github.com/apache/flink/pull/18516 ## What is the purpose of the change This pull request adds savepoint and metric test cases in source suite of the connector testfram. ## Brief change log - Add savepoi

[jira] [Updated] (FLINK-25288) Add savepoint and metric cases in DataStream source suite of connector testing framework

2022-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25288: --- Labels: pull-request-available (was: ) > Add savepoint and metric cases in DataStream sourc

[GitHub] [flink] flinkbot edited a comment on pull request #18418: [FLINK-25719][python] Support General Python UDF in Thread Mode

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18418: URL: https://github.com/apache/flink/pull/18418#issuecomment-1017307428 ## CI report: * 65bbedd87b4b4962bf1b11764ad284419cbf24ee Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resu

[GitHub] [flink] flinkbot edited a comment on pull request #18470: [FLINK-25774][network] Restrict the maximum number of buffers can be used per result partition for sort-shuffle

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18470: URL: https://github.com/apache/flink/pull/18470#issuecomment-1020036276 ## CI report: * decf33d57cf16564786d77240287fb1aeb034b39 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink-web] tillrohrmann commented on a change in pull request #501: Release announcement for Statefun 3.2.0

2022-01-26 Thread GitBox
tillrohrmann commented on a change in pull request #501: URL: https://github.com/apache/flink-web/pull/501#discussion_r792452976 ## File path: _posts/2022-01-27-release-statefun-3.2.0.md ## @@ -0,0 +1,111 @@ +--- +layout: post +title: "Stateful Functions 3.2.0 Release Announce

[GitHub] [flink] flinkbot commented on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe

2022-01-26 Thread GitBox
flinkbot commented on pull request #18516: URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934 ## CI report: * 741b593b95d9501c69f8f7014729b0983350bfe7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe

2022-01-26 Thread GitBox
flinkbot commented on pull request #18516: URL: https://github.com/apache/flink/pull/18516#issuecomment-1022022034 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pr

[GitHub] [flink] LadyForest commented on pull request #18500: [FLINK-25312][hive] HiveCatalog supports Flink's managed table

2022-01-26 Thread GitBox
LadyForest commented on pull request #18500: URL: https://github.com/apache/flink/pull/18500#issuecomment-1022024594 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Commented] (FLINK-25771) CassandraConnectorITCase.testRetrialAndDropTables fails on AZP

2022-01-26 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482349#comment-17482349 ] Etienne Chauchot commented on FLINK-25771: -- [~gaoyunhaii] thanks for the pointe

[GitHub] [flink] rkhachatryan commented on a change in pull request #18514: [FLINK-25816][changelog] Refactor the logic of notifying materialization id to nested state backend

2022-01-26 Thread GitBox
rkhachatryan commented on a change in pull request #18514: URL: https://github.com/apache/flink/pull/18514#discussion_r792455364 ## File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java ## @@

[GitHub] [flink] flinkbot edited a comment on pull request #18470: [FLINK-25774][network] Restrict the maximum number of buffers can be used per result partition for sort-shuffle

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18470: URL: https://github.com/apache/flink/pull/18470#issuecomment-1020036276 ## CI report: * decf33d57cf16564786d77240287fb1aeb034b39 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[jira] [Created] (FLINK-25817) FLIP-201: Persist local state in working directory

2022-01-26 Thread Till Rohrmann (Jira)
Till Rohrmann created FLINK-25817: - Summary: FLIP-201: Persist local state in working directory Key: FLINK-25817 URL: https://issues.apache.org/jira/browse/FLINK-25817 Project: Flink Issue Ty

[GitHub] [flink] flinkbot edited a comment on pull request #18514: [FLINK-25816][changelog] Refactor the logic of notifying materialization id to nested state backend

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18514: URL: https://github.com/apache/flink/pull/18514#issuecomment-1021939543 ## CI report: * db5af6253d30f1e4e782269f07a24eeb72a9857f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18516: URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934 ## CI report: * 741b593b95d9501c69f8f7014729b0983350bfe7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #18500: [FLINK-25312][hive] HiveCatalog supports Flink's managed table

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18500: URL: https://github.com/apache/flink/pull/18500#issuecomment-1021030168 ## CI report: * d7dc483a078a947fe4d397c17e3ec3fa9ec8db72 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] flinkbot edited a comment on pull request #18514: [FLINK-25816][changelog] Refactor the logic of notifying materialization id to nested state backend

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18514: URL: https://github.com/apache/flink/pull/18514#issuecomment-1021939543 ## CI report: * db5af6253d30f1e4e782269f07a24eeb72a9857f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

[GitHub] [flink] wsry commented on a change in pull request #18505: [FLINK-25796][network] Avoid record copy for result partition of sort-shuffle if there are enough buffers for better performance

2022-01-26 Thread GitBox
wsry commented on a change in pull request #18505: URL: https://github.com/apache/flink/pull/18505#discussion_r792462118 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java ## @@ -41,7 +41,7 @@ * ResultPartition

[GitHub] [flink] SteNicholas commented on pull request #18502: [hotfix][docs][kafka] Add explanation how Kafka Source deals with idl…

2022-01-26 Thread GitBox
SteNicholas commented on pull request #18502: URL: https://github.com/apache/flink/pull/18502#issuecomment-1022031621 @fapaul , help to merge this pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-26 Thread GitBox
CrynetLogistics commented on a change in pull request #18483: URL: https://github.com/apache/flink/pull/18483#discussion_r792465363 ## File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsSink.java

[GitHub] [flink] rkhachatryan opened a new pull request #18517: [FLINK-25816][state] Remove checkpoint abortion notification of notify backend

2022-01-26 Thread GitBox
rkhachatryan opened a new pull request #18517: URL: https://github.com/apache/flink/pull/18517 ## What is the purpose of the change ``` The notification currently causes an exception and adds complexity. It's also not necessary, unlikely to be delivered (because of the differ

[GitHub] [flink] beyond1920 commented on a change in pull request #18331: [FLINK-25614][table/runtime] Let LocalWindowAggregate be chained with upstream

2022-01-26 Thread GitBox
beyond1920 commented on a change in pull request #18331: URL: https://github.com/apache/flink/pull/18331#discussion_r792467756 ## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/slicing/SliceAssigners.java ## @@ -401,7 +

[jira] [Created] (FLINK-25818) Add explanation how Kafka Source deals with idleness when parallelism is higher then the number of partitions

2022-01-26 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-25818: -- Summary: Add explanation how Kafka Source deals with idleness when parallelism is higher then the number of partitions Key: FLINK-25818 URL: https://issues.apache.org/jira/bro

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18483: [FLINK-24041][connectors] Removed public setter for elementConverter in As…

2022-01-26 Thread GitBox
CrynetLogistics commented on a change in pull request #18483: URL: https://github.com/apache/flink/pull/18483#discussion_r792468424 ## File path: flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsSinkEleme

[GitHub] [flink] YuriGusev opened a new pull request #18518: [FLINK-24229][connectors/dynamodb] Added DynamoDB connector

2022-01-26 Thread GitBox
YuriGusev opened a new pull request #18518: URL: https://github.com/apache/flink/pull/18518 ## What is the purpose of the change _User stories:_ As a Flink user, I’d like to use DynamoDB as sink for my data pipeline. _Scope:_ * Implement an asynchronous si

[GitHub] [flink] flinkbot commented on pull request #18517: [FLINK-25816][state] Remove checkpoint abortion notification of notify backend

2022-01-26 Thread GitBox
flinkbot commented on pull request #18517: URL: https://github.com/apache/flink/pull/18517#issuecomment-1022038055 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pr

[jira] [Assigned] (FLINK-25818) Add explanation how Kafka Source deals with idleness when parallelism is higher then the number of partitions

2022-01-26 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-25818: -- Assignee: Martijn Visser > Add explanation how Kafka Source deals with idleness when

[GitHub] [flink] flinkbot edited a comment on pull request #18502: [FLINK-25818][Docs][Kafka] Add explanation how Kafka Source deals with idl…

2022-01-26 Thread GitBox
flinkbot edited a comment on pull request #18502: URL: https://github.com/apache/flink/pull/18502#issuecomment-1021048562 ## CI report: * d446d2d97b5b87ed87a923b1122c32602dc526b3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/resul

  1   2   3   4   5   6   >