pnowojski commented on a change in pull request #18505:
URL: https://github.com/apache/flink/pull/18505#discussion_r792418842
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
##########
@@ -41,7 +41,7 @@
* ResultPartitionWriter#fail(Throwable)} still needs to be called afterwards
to fully release all
* resources associated the partition and propagate failure cause to the
consumer if possible.
*/
-public interface ResultPartitionWriter extends AutoCloseable,
AvailabilityProvider {
+public interface ResultPartitionWriter extends AvailabilityProvider {
Review comment:
(One small comment as I'm not able to do full review): Why did you
remove `AutoCloseable`?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
##########
@@ -41,7 +41,7 @@
* ResultPartitionWriter#fail(Throwable)} still needs to be called afterwards
to fully release all
* resources associated the partition and propagate failure cause to the
consumer if possible.
*/
-public interface ResultPartitionWriter extends AutoCloseable,
AvailabilityProvider {
+public interface ResultPartitionWriter extends AvailabilityProvider {
Review comment:
(One small comment as I'm not able to do full review): Can you explain
why did you remove `AutoCloseable`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
