wsry commented on a change in pull request #18505:
URL: https://github.com/apache/flink/pull/18505#discussion_r792462118



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
##########
@@ -41,7 +41,7 @@
  * ResultPartitionWriter#fail(Throwable)} still needs to be called afterwards 
to fully release all
  * resources associated the partition and propagate failure cause to the 
consumer if possible.
  */
-public interface ResultPartitionWriter extends AutoCloseable, 
AvailabilityProvider {
+public interface ResultPartitionWriter extends AvailabilityProvider {

Review comment:
       It is removed by accident. When I am checking where the close method is 
called, the IDE gives all places calling AutoCloseable#close, I removed it to 
reduce the result set size but forgot to add it back. Thanks for pointing it 
out. I will add it back.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to