XComp commented on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-1021982073
Ok, my understanding was that we're using service names in labels which forces us to set some limitation on the cluster ID. Reiterating over the comments of FLINK-15816, I conclude that it's really only about adding the check for the `clusterIds` maximum length also for standalone mode. Essentially, the only change that's needed is to add a check similar to [AbstractKubernetesParameters:73](https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/AbstractKubernetesParameters.java#L73) in [KubernetesHaServices:99](https://github.com/apache/flink/blob/a115a3c52f0e305c139666b35ec952365049738d/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/highavailability/KubernetesHaServices.java#L99). I'm just wondering why we should limit ourselves with 45 characters. Don't we have to restart the Flink cluster anyway in case of a version update? That would give the user the possibility to update the cluster ID if it becomes necessary. In any case, we should add some in-code documentation about this to the [MAXIMUM_CHARACTERS_OF_CLUSTER_ID declaration in Constants:86]https://github.com/apache/flink/blob/d532f5fc81f9acf611541cab440eb3d5a9de08cc/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/utils/Constants.java#L86) to explain the reason for this constant being set in that way (i.e. that it's left at `45` to be prepared for future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
