dannycranmer commented on a change in pull request #18483:
URL: https://github.com/apache/flink/pull/18483#discussion_r792438959
##########
File path:
flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsSink.java
##########
@@ -111,7 +111,7 @@
return new KinesisDataStreamsSinkBuilder<>();
}
- @Experimental
+ @Internal
Review comment:
Having an `@Internal` public method on a `@Public` class seems like a
bad design to me. How does this annotation stop users using it? Is this smell
inherited from the base `SInk` or something we have added here
##########
File path:
flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisDataStreamsSink.java
##########
@@ -111,7 +111,7 @@
return new KinesisDataStreamsSinkBuilder<>();
}
- @Experimental
+ @Internal
Review comment:
Having an `@Internal` public method on a `@Public` class seems like a
bad design to me. How does this annotation stop users using it? Is this smell
inherited from the base `SInk` or something we have added here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
