[
https://issues.apache.org/jira/browse/FLINK-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066022#comment-16066022
]
ASF GitHub Bot commented on FLINK-6407:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4205
Please don't cc in on every pull request. Other people do reviews as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066021#comment-16066021
]
Piotr Nowojski commented on FLINK-6996:
---
[~tzulitai] I guess we were both wrong. I a
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/4206
[FLINK-6996] FlinkKafkaProducer010 doesn't guarantee at-least-once semantic
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pnowojski/flink at
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066023#comment-16066023
]
ASF GitHub Bot commented on FLINK-6996:
---
GitHub user pnowojski opened a pull request
[
https://issues.apache.org/jira/browse/FLINK-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066039#comment-16066039
]
Pengcheng Xiong commented on FLINK-6173:
May I ask if this issue is resolved? I am
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4206#discussion_r124466523
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer010.java
---
@@ -411,6 +4
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4206#discussion_r124467315
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka08ProducerITCase.java
---
@@ -18,17 +18
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4206#discussion_r124467541
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka08ProducerITCase.java
---
@@ -18,17 +18
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4206#discussion_r124468424
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
---
@@ -116,6
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4206#discussion_r124467929
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
---
@@ -28,6 +
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4206#discussion_r124467740
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka09ProducerITCase.java
---
@@ -18,17 +18
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066050#comment-16066050
]
ASF GitHub Bot commented on FLINK-6996:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066051#comment-16066051
]
ASF GitHub Bot commented on FLINK-6996:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066048#comment-16066048
]
ASF GitHub Bot commented on FLINK-6996:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066047#comment-16066047
]
ASF GitHub Bot commented on FLINK-6996:
---
Github user tzulitai commented on a diff in
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4206#discussion_r124466733
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
---
@@ -26,6
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066052#comment-16066052
]
ASF GitHub Bot commented on FLINK-6996:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066046#comment-16066046
]
ASF GitHub Bot commented on FLINK-6996:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066049#comment-16066049
]
ASF GitHub Bot commented on FLINK-6996:
---
Github user tzulitai commented on a diff in
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4205
Okay. I remember.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
[
https://issues.apache.org/jira/browse/FLINK-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066069#comment-16066069
]
ASF GitHub Bot commented on FLINK-6407:
---
Github user zhangminglei commented on the i
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4200
Thanks for updating and rebasing, the changes look good to me now.
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
[
https://issues.apache.org/jira/browse/FLINK-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066071#comment-16066071
]
ASF GitHub Bot commented on FLINK-7014:
---
Github user wuchong commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3942
Really good work @EronWright. I've completed the review and rebased it on
the latest master. While doing the review I applied one fix for a race
condition in the tests, another fix to address th
[
https://issues.apache.org/jira/browse/FLINK-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066083#comment-16066083
]
ASF GitHub Bot commented on FLINK-6379:
---
Github user tillrohrmann commented on the i
[
https://issues.apache.org/jira/browse/FLINK-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066101#comment-16066101
]
Fabian Hueske commented on FLINK-7025:
--
I agree. IMO, we should go for the keyed stat
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4206#discussion_r124476235
--- Diff:
flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
---
@@ -116,
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066103#comment-16066103
]
ASF GitHub Bot commented on FLINK-6996:
---
Github user pnowojski commented on a diff i
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4206#discussion_r124476992
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka08ProducerITCase.java
---
@@ -18,17 +1
[
https://issues.apache.org/jira/browse/FLINK-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066110#comment-16066110
]
ASF GitHub Bot commented on FLINK-6996:
---
Github user pnowojski commented on a diff i
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4183
Hi @wuchong, that's an interesting idea but I think it has the drawback
that it might add latency.
A timestamp extractor is only called with records and doesn't see
watermarks. Since an ope
[
https://issues.apache.org/jira/browse/FLINK-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066115#comment-16066115
]
ASF GitHub Bot commented on FLINK-6969:
---
Github user fhueske commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-7013.
---
Resolution: Fixed
Fixed in a78b48a721b595eec56c94567ae52c2879ee1a2e
> Add shaded netty depend
[
https://issues.apache.org/jira/browse/FLINK-7007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066167#comment-16066167
]
ASF GitHub Bot commented on FLINK-7007:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-7007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-7007.
---
Resolution: Fixed
Fixed in 236b7430d2b302e5f6785b210109c3978d11a690
> Add README to "flink-sh
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r124489316
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SortITCase.scala
---
@@ -0,0 +1,127 @@
+/*
+ * Lic
[
https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066176#comment-16066176
]
ASF GitHub Bot commented on FLINK-6075:
---
Github user rtudoran commented on a diff in
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4187
I don't think it matters to much whether a metric is completely measured by
Flink or just forwarded from kafka classes. Having "kafka" in the name also
introduces an inherent redundancy, since the sco
[
https://issues.apache.org/jira/browse/FLINK-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066180#comment-16066180
]
ASF GitHub Bot commented on FLINK-6998:
---
Github user zentol commented on the issue:
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/4172
@dianfu So this is a plan that can work to avoid having to generate the
code of the `IterativeCondition` every time. This came also after discussion
with @fhueske who also explained me how things are do
[
https://issues.apache.org/jira/browse/FLINK-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066183#comment-16066183
]
ASF GitHub Bot commented on FLINK-6983:
---
Github user kl0u commented on the issue:
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4183
Hi @fhueske @wuchong Thanks for your reviewing and comments. Thanks!
1. For the param rename I am not sure whether it can be shared with `early
fire` feature or not. I suggest using c
[
https://issues.apache.org/jira/browse/FLINK-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066186#comment-16066186
]
ASF GitHub Bot commented on FLINK-6969:
---
Github user sunjincheng121 commented on the
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r124491150
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonSort.scala
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed to th
[
https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066189#comment-16066189
]
ASF GitHub Bot commented on FLINK-6075:
---
Github user rtudoran commented on a diff in
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r124491949
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonSort.scala
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed to th
[
https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066193#comment-16066193
]
ASF GitHub Bot commented on FLINK-6075:
---
Github user rtudoran commented on a diff in
Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r124492156
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonSort.scala
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed to th
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4183
Hi, @fhueske I write comments for a long time, so i have not seen your
reply util i send out my reply.
I think we do not need the current trigger if we custom operators, we only
chang
[
https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066196#comment-16066196
]
ASF GitHub Bot commented on FLINK-6075:
---
Github user rtudoran commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066194#comment-16066194
]
ASF GitHub Bot commented on FLINK-6969:
---
Github user sunjincheng121 commented on the
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4195#discussion_r124491313
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFATest.java
---
@@ -324,6 +328,89 @@ public boolean filter(Event value) throws
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4195#discussion_r124492768
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java
---
@@ -114,6 +115,28 @@ public DeweyNumber getVersion() {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4195#discussion_r124491510
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
---
@@ -270,10 +270,12 @@ private void
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4195#discussion_r124492599
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -237,8 +254,15 @@ public boolean isEmpty() {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4195#discussion_r124481149
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
---
@@ -270,10 +270,12 @@ private void
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4195#discussion_r124491894
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -152,6 +153,12 @@
private TypeSerializer eventSeria
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4195#discussion_r124491446
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFATest.java
---
@@ -324,6 +328,89 @@ public boolean filter(Event value) throws
[
https://issues.apache.org/jira/browse/FLINK-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066202#comment-16066202
]
ASF GitHub Bot commented on FLINK-7008:
---
Github user dawidwys commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066206#comment-16066206
]
ASF GitHub Bot commented on FLINK-7008:
---
Github user dawidwys commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066204#comment-16066204
]
ASF GitHub Bot commented on FLINK-7008:
---
Github user dawidwys commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066203#comment-16066203
]
ASF GitHub Bot commented on FLINK-7008:
---
Github user dawidwys commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066208#comment-16066208
]
ASF GitHub Bot commented on FLINK-7008:
---
Github user dawidwys commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066205#comment-16066205
]
ASF GitHub Bot commented on FLINK-7008:
---
Github user dawidwys commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066207#comment-16066207
]
ASF GitHub Bot commented on FLINK-7008:
---
Github user dawidwys commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066213#comment-16066213
]
sunjincheng commented on FLINK-7025:
Yes, Sounds good.:)
> Using NullByteKeySelector
[
https://issues.apache.org/jira/browse/FLINK-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske updated FLINK-7025:
-
Component/s: Table API & SQL
> Using NullByteKeySelector for Unbounded ProcTime NonPartitioned Ove
[
https://issues.apache.org/jira/browse/FLINK-6173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066217#comment-16066217
]
Chesnay Schepler commented on FLINK-6173:
-
could you try maven 3.2.5? For this ver
[
https://issues.apache.org/jira/browse/FLINK-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fabian Hueske updated FLINK-7025:
-
Affects Version/s: 1.4.0
1.3.1
> Using NullByteKeySelector for Unbounded Pr
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4195#discussion_r124494317
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
---
@@ -270,10 +270,12 @@ private void u
[
https://issues.apache.org/jira/browse/FLINK-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066218#comment-16066218
]
ASF GitHub Bot commented on FLINK-7008:
---
Github user dianfu commented on a diff in t
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4195#discussion_r124496350
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
---
@@ -270,10 +270,12 @@ private void
[
https://issues.apache.org/jira/browse/FLINK-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066225#comment-16066225
]
ASF GitHub Bot commented on FLINK-7008:
---
Github user dawidwys commented on a diff in
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4195#discussion_r124499732
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java
---
@@ -114,6 +115,28 @@ public DeweyNumber getVersion() {
[
https://issues.apache.org/jira/browse/FLINK-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066251#comment-16066251
]
ASF GitHub Bot commented on FLINK-7008:
---
Github user dianfu commented on a diff in t
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/4195#discussion_r124500395
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
---
@@ -270,10 +270,12 @@ private void upd
[
https://issues.apache.org/jira/browse/FLINK-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066258#comment-16066258
]
ASF GitHub Bot commented on FLINK-7008:
---
Github user kl0u commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066261#comment-16066261
]
ASF GitHub Bot commented on FLINK-7008:
---
Github user dianfu commented on a diff in t
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4195#discussion_r124500774
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -237,8 +254,15 @@ public boolean isEmpty() {
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4195#discussion_r124501193
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/ComputationState.java
---
@@ -114,6 +115,28 @@ public DeweyNumber getVersion() {
[
https://issues.apache.org/jira/browse/FLINK-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066265#comment-16066265
]
ASF GitHub Bot commented on FLINK-7008:
---
Github user dawidwys commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4200#discussion_r124504426
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ExpressionReductionTest.scala
---
@@ -458,4 +459,52 @@ class ExpressionReduction
[
https://issues.apache.org/jira/browse/FLINK-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066288#comment-16066288
]
ASF GitHub Bot commented on FLINK-7014:
---
Github user fhueske commented on a diff in
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r124504146
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java
---
@@ -33,6 +33,45 @@
.key("resourcemanager.jo
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066290#comment-16066290
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in t
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r124503662
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java
---
@@ -33,6 +33,45 @@
.key("resourcemanager.jo
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r124501969
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/configuration/MesosConfigOptions.java
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4075#discussion_r124504177
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java
---
@@ -33,6 +33,45 @@
.key("resourcemanager.jo
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066293#comment-16066293
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in t
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066292#comment-16066292
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in t
[
https://issues.apache.org/jira/browse/FLINK-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066291#comment-16066291
]
ASF GitHub Bot commented on FLINK-6494:
---
Github user zentol commented on a diff in t
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4183
Hi @fhueske , jincheng and me have discussed offline and have an unified
opinion.
We think the approach of window(with custom trigger) + custom operator will
increase the latency when multip
[
https://issues.apache.org/jira/browse/FLINK-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066306#comment-16066306
]
ASF GitHub Bot commented on FLINK-6969:
---
Github user wuchong commented on the issue:
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/4200#discussion_r124506864
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ExpressionReductionTest.scala
---
@@ -458,4 +459,52 @@ class ExpressionReduction
[
https://issues.apache.org/jira/browse/FLINK-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066309#comment-16066309
]
ASF GitHub Bot commented on FLINK-7014:
---
Github user wuchong commented on a diff in
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/4194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/4193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4195#discussion_r124510489
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
---
@@ -270,10 +270,12 @@ private void u
[
https://issues.apache.org/jira/browse/FLINK-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066329#comment-16066329
]
ASF GitHub Bot commented on FLINK-7008:
---
Github user dianfu commented on a diff in t
1 - 100 of 340 matches
Mail list logo
