Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4200#discussion_r124504426
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/ExpressionReductionTest.scala
 ---
    @@ -458,4 +459,52 @@ class ExpressionReductionTest extends TableTestBase {
         util.verifySql(sqlQuery, expected)
       }
     
    +  // todo this NPE is caused by Calcite, it shall pass when [CALCITE-1860] 
is fixed
    +  @Ignore
    +  @Test(expected = classOf[NullPointerException])
    --- End diff --
    
    What is the expected result of the test given that CALCITE-1860 is fixed?
    Since the test is ignored, we should implement the test such that is 
validates the expected result. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to