Github user dianfu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4195#discussion_r124500774
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
@@ -237,8 +254,15 @@ public boolean isEmpty() {
computationState.getCounter());
newComputationStates = Collections.emptyList();
+ nfaChanged = true;
--- End diff --
I think this may not always be true. For example, the
`eventSharedBuffer.release`(NFA:250) may already have released the events that
will be pruned. This will cause the pruning sharedBuffer do nothing. Thoughts?
Anyway, leave it here will be more safe.:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
